Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/ --- (Updated Nov. 14, 2013, 6:50 a.m.) Review request for KDE Frameworks, Albe

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. Locally, I get this error: AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

> On Nov. 11, 2013, 5:45 p.m., David Faure wrote: > > Thanks for implementing that. Indeed the TODO didn't mean adding a method > > to QApplication, but it was about the member that was there in qt4, and > > that is now in QXcbConnection. > > > > The optional dependency on QtGui breaks the rul

Re: Review Request 113825: Move kmediaplayer to staging (and fix its CMake files)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113825/#review43642 --- This review has been submitted with commit f3a33e60d5c58e12dc8

Re: Review Request 113827: CMake: refer to target directly instead of getting LOCATION property

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113827/ --- (Updated Nov. 14, 2013, 12:05 a.m.) Status -- This change has been ma

Re: Review Request 113827: CMake: refer to target directly instead of getting LOCATION property

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113827/#review43643 --- This review has been submitted with commit c28742fbfebb98582b9

Re: Review Request 113825: Move kmediaplayer to staging (and fix its CMake files)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113825/ --- (Updated Nov. 14, 2013, 12:05 a.m.) Status -- This change has been ma

Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/ --- (Updated Nov. 13, 2013, 10:26 p.m.) Status -- This change has been ma

Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/#review43639 --- This review has been submitted with commit f79e0f903e0d3aee44d

Re: Review Request 113847: Remove unnecessary dependency in dnssd

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113847/#review43636 --- Ship it! Ship It! - Kevin Ottens On Nov. 13, 2013, 5:53 p.m

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

> On Nov. 13, 2013, 4:41 p.m., David Faure wrote: > > tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 93 > > > > > > this is still a C++11 initializer list, which isn't in the wiki page of > > allowed C++11

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/#review43634 --- tier1/kdbusaddons/src/kdbusservice.h

Re: Review Request 113845: Remove unnecessary dependencies in kauth

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113845/#review43633 --- Ship it! Ship It! - Kevin Ottens On Nov. 13, 2013, 5:33 p.m

Re: Review Request 113834: Use FindOpenEXR.cmake from ECM

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113834/#review43632 --- Ship it! Once 113828 is in of course - Kevin Ottens On Nov.

Re: Review Request 113827: CMake: refer to target directly instead of getting LOCATION property

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113827/#review43631 --- Ship it! Ship It! - Kevin Ottens On Nov. 12, 2013, 10:29 p.

Re: Review Request 113825: Move kmediaplayer to staging (and fix its CMake files)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113825/#review43630 --- Ship it! Ship It! - Kevin Ottens On Nov. 12, 2013, 10:09 p.

Re: Review Request 113683: Fix kdeclarative standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/#review43629 --- Ship it! Ship It! - Kevin Ottens On Nov. 12, 2013, 7:52 p.m

Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/#review43628 --- Ship it! Ship It! - Kevin Ottens On Nov. 11, 2013, 1:32 a.m

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

> On Nov. 11, 2013, 5:45 p.m., David Faure wrote: > > Thanks for implementing that. Indeed the TODO didn't mean adding a method > > to QApplication, but it was about the member that was there in qt4, and > > that is now in QXcbConnection. > > > > The optional dependency on QtGui breaks the rul

Re: Review Request 113844: Move kspeech interface to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113844/#review43622 --- This review has been submitted with commit c18ffcc197a6106f2f1

Re: Review Request 113844: Move kspeech interface to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113844/ --- (Updated Nov. 13, 2013, 6:57 p.m.) Status -- This change has been mar

Re: Review Request 113844: Move kspeech interface to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113844/#review43621 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 13, 2013, 6:

Re: Review Request 113844: Move kspeech interface to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113844/ --- (Updated Nov. 13, 2013, 11:01 a.m.) Review request for KDE Frameworks. C

Review Request 113847: Remove unnecessary dependency in dnssd

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113847/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

> On Nov. 13, 2013, 5:41 p.m., David Faure wrote: > > tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 93 > > > > > > this is still a C++11 initializer list, which isn't in the wiki page of > > allowed C++11

Re: Review Request 113844: Move kspeech interface to tier3

> On Nov. 13, 2013, 10:22 a.m., Aleix Pol Gonzalez wrote: > > Why is it tier3? It doesn't seem to depend on anything, no? No it doesn't depend on anything, but is specific to kde platform. I put it into tier3 because that's what I was told in the meeting, maybe another tier makes more sense th

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/#review43618 --- Of course, if we wanted to support Ryan's use cases (like text

Review Request 113845: Remove unnecessary dependencies in kauth

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113845/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113844: Move kspeech interface to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113844/#review43616 --- Why is it tier3? It doesn't seem to depend on anything, no? -

Review Request 113844: Move kspeech interface to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113844/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/ --- (Updated Nov. 13, 2013, 5:09 p.m.) Review request for KDE Frameworks and D

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/#review43607 --- tier3/kconfigwidgets/src/kcolorschememanager.h

Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support

On Wednesday 13 November 2013 14:20:45 Christoph Feck wrote: > On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote: > > Git commit f073b4561730ef50b4968b92b30cbcc32bccdc7e by Kevin > > Ottens. Committed on 12/11/2013 at 17:09. > > Pushed by ervin into branch 'frameworks'. > > > > Move cmake leg

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

> On Nov. 13, 2013, 1:33 p.m., David Faure wrote: > > tier1/kdbusaddons/src/kdbusservice.h, line 172 > > > > > > When is this emitted, then? Only if the dbus-based app launcher calls > > Activate? > > > >

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1662

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113821: Don't install kpagedialog_p.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/#review43603 --- This review has been submitted with commit fc714169fb713bb7424

Re: Review Request 113821: Don't install kpagedialog_p.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/ --- (Updated Nov. 13, 2013, 3:43 p.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #1661

See Changes: [aleixpol] Move KIO to tier3 -- [...truncated 198 lines...] -- Looking for include file valgrind/memcheck.h -- Looking for include file valgrind/memcheck.h - not found -- Looking f

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

> On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 18 > > > > > > I don't think we want that, superbuild shouldn't be used after the > > splitting but the kde build script. We will n

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

> On Nov. 12, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 18 > > > > > > I don't think we want that, superbuild shouldn't be used after the > > splitting but the kde build script. We will n

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

> On Nov. 13, 2013, 1:33 p.m., David Faure wrote: > > tier1/kdbusaddons/src/kdbusservice.h, line 172 > > > > > > When is this emitted, then? Only if the dbus-based app launcher calls > > Activate? > > > >

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

> On Nov. 13, 2013, 1:33 p.m., David Faure wrote: > > tier1/kdbusaddons/src/kdbusservice.h, line 172 > > > > > > When is this emitted, then? Only if the dbus-based app launcher calls > > Activate? > > > >

Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support

On 13/11/13 13:20, Christoph Feck wrote: > On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote: >> tier4/kde4support/cmake/modules-tests/OpenEXR/CMakeLists.txt >> [from: cmake/modules-tests/OpenEXR/CMakeLists.txt - 100% >> similarity] R +0-0 > > OpenEXR is needed by tier1/kguiaddons/sr

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

> On Nov. 13, 2013, 1:33 p.m., David Faure wrote: > > tier1/kdbusaddons/src/CMakeLists.txt, line 17 > > > > > > Maybe this should be called org.kde.KDBusService.xml instead. > > > > It's an implementation

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

> On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 18 > > > > > > I don't think we want that, superbuild shouldn't be used after the > > splitting but the kde build script. We will n

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/ --- (Updated Nov. 13, 2013, 1:52 p.m.) Review request for KDE Frameworks and D

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/#review43586 --- tier1/kdbusaddons/src/CMakeLists.txt

Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support

On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote: > Git commit f073b4561730ef50b4968b92b30cbcc32bccdc7e by Kevin > Ottens. Committed on 12/11/2013 at 17:09. > Pushed by ervin into branch 'frameworks'. > > Move cmake legacy to KDE4Support > > All the old CMake is now provided by KDE4Support

Re: Review Request 112874: Allow disabling of QCA plugins during build.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Nov. 13, 2013, 1:17 p.m.) Status -- This change has been mar

Re: Review Request 113821: Don't install kpagedialog_p.h

> On Nov. 13, 2013, 11:53 a.m., David Edmundson wrote: > > tier4/kcmutils/src/kcmultidialog.cpp, line 262 > > > > > > I don't think this is right. > > > > If we copy a KCMultiDialog instance, we wouldn't

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 13, 2013, 2:07 p.m.) Review request for Build System, KDE Fr

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

> On Nov. 12, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 18 > > > > > > I don't think we want that, superbuild shouldn't be used after the > > splitting but the kde build script. We will n

Jenkins build is back to normal : plasma-framework_master_qt5 #903

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113821: Don't install kpagedialog_p.h

> On Nov. 13, 2013, 11:53 a.m., David Edmundson wrote: > > tier4/kcmutils/src/kcmultidialog.cpp, line 262 > > > > > > I don't think this is right. > > > > If we copy a KCMultiDialog instance, we wouldn't

Review Request 113834: Use FindOpenEXR.cmake from ECM

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113834/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Build failed in Jenkins: plasma-framework_master_qt5 #902

See Changes: [bhush94] Make plasma-framework build without tests -- [...truncated 254 lines...] [ 7%] Automatic moc for target platformcomponentsplugin Generating moc_modeltest.cpp Generat

Re: Review Request 113821: Don't install kpagedialog_p.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/#review43573 --- tier4/kcmutils/src/kcmultidialog.cpp

Re: Review Request 113821: Don't install kpagedialog_p.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/#review43572 --- Ship it! I don't spot anything wrong. - Vishesh Handa On No

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

> On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote: > > About the .colors translations, we have this > > > > ./kdeui/colors/kcolordialog.cpp:104:{ "40.colors", > > I18N_NOOP2("palette name", "Forty Colors") }, > > ./kdeui/colors/kcolordialog.cpp:105:{ "Oxygen.colors", > > I18N

Re: Optional QtGui dependency for KDBusAddons?

On 13/11/13 05:38, Martin Gräßlin wrote: > On Tuesday 12 November 2013 23:42:36 Alex Merry wrote: >> > The latter is my personal preference (and I don't see any real issue >> > with KDBusAddons optionally using something from Qt Essentials), but >> > what are other people's thoughts? > Could you ex

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

> On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote: > > About the .colors translations, we have this > > > > ./kdeui/colors/kcolordialog.cpp:104:{ "40.colors", > > I18N_NOOP2("palette name", "Forty Colors") }, > > ./kdeui/colors/kcolordialog.cpp:105:{ "Oxygen.colors", > > I18N