----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/#review43607 -----------------------------------------------------------
tier3/kconfigwidgets/src/kcolorschememanager.h <http://git.reviewboard.kde.org/r/113685/#comment31353> Missing @since 5.0 tier3/kconfigwidgets/src/kcolorschememanager.h <http://git.reviewboard.kde.org/r/113685/#comment31352> remove space after Qt:: tier3/kconfigwidgets/src/kcolorschememanager.cpp <http://git.reviewboard.kde.org/r/113685/#comment31354> this is still a C++11 initializer list, which isn't in the wiki page of allowed C++11 constructs in KF5, is it? tier3/kconfigwidgets/tests/kcolorschemedemo.cpp <http://git.reviewboard.kde.org/r/113685/#comment31355> stray semicolon - David Faure On Nov. 12, 2013, 8:48 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113685/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2013, 8:48 a.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Gilles Caulier, and > Boudewijn Rempt. > > > Repository: kdelibs > > > Description > ------- > > This class is inspired by functionality offered by e.g. Krita and > Digikam to allow the user to select a different color scheme for the > application. > > This manager simplifies this task and also ensures that the required > property on QApplication is set, so that a QStyle can pass the scheme > to the window manager/compositor for the windows of the application. > > @boud and @cgilles: please have a look whether this approach is sufficient > for your usecases in digkam and Krita. > > > Diffs > ----- > > tier3/kconfigwidgets/src/CMakeLists.txt 36ffca8 > tier3/kconfigwidgets/src/kcolorschememanager.h PRE-CREATION > tier3/kconfigwidgets/src/kcolorschememanager.cpp PRE-CREATION > tier3/kconfigwidgets/src/kcolorschememanager_p.h PRE-CREATION > tier3/kconfigwidgets/tests/CMakeLists.txt f66dc32 > tier3/kconfigwidgets/tests/kcolorschemedemo.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113685/diff/ > > > Testing > ------- > > see demo application > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
