Re: Flaky kcodecs test depending on qt configuration

2013-10-23 Thread Kevin Ottens
Hello, On Wednesday 23 October 2013 21:43:59 Sune Vuorela wrote: > Depending on the Qt configuration (built with or without ICU), the > KCharsetsTest::testEncodingNames() test fails (in the #if) block. > > If Qt built with ICU, the tests succeeds and the ISO 8859-16, jis7 and > winsami2 codecs ar

Re: Porting away from KLocale

2013-10-23 Thread Kevin Ottens
On Wednesday 23 October 2013 20:40:19 John Layt wrote: > On 23 October 2013 12:56, Aleix Pol wrote: > > On Tue, Oct 22, 2013 at 2:03 PM, David Faure wrote: > >> On Thursday 17 October 2013 23:47:40 Aleix Pol wrote: > >> > Well maybe I could help with this, but I'd need to know what do you > >> >

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Oct. 24, 2013, 7:19 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-23 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- (Updated Oct. 23, 2013, 7:54 p.m.) Status -- This change has been mar

Re: Review Request 113376: KDirWatch: don't check for symlinks on Windows.

2013-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/#review42259 --- This review has been submitted with commit c363b940745620873e2

Re: Review Request 113376: KDirWatch: don't check for symlinks on Windows.

2013-10-23 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/ --- (Updated Oct. 23, 2013, 11:47 p.m.) Status -- This change has been ma

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/#review42257 --- Ship it! Looks good to me (although you left an odd bit of whi

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-23 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- (Updated Oct. 23, 2013, 3:45 p.m.) Review request for KDE Frameworks. Ch

Flaky kcodecs test depending on qt configuration

2013-10-23 Thread Sune Vuorela
Hi Depending on the Qt configuration (built with or without ICU), the KCharsetsTest::testEncodingNames() test fails (in the #if) block. If Qt built with ICU, the tests succeeds and the ISO 8859-16, jis7 and winsami2 codecs are as expected not found. If Qt is built without ICU, those codecs are

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-23 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42250 --- IMO the documentation could be improved. It should mention the

Re: Keep the Things You Forgot

2013-10-23 Thread John Layt
On 23 October 2013 21:49, Mark wrote: > A blog post that i'd very much like from you (Aaron) is about the next > big KDE version, the naming and how the complete collection is going > to be called or if there even will be a collection release (what KDE > SC is now). Press is still getting that wr

Re: Keep the Things You Forgot

2013-10-23 Thread Mark
On Tue, Oct 22, 2013 at 10:27 PM, Aaron J. Seigo wrote: > hi :) > > (i stole the subject without shame. but it seemed appropriate given the topic) > > we’ve all gotten out of the habit of communicating with the outside world, > with some notable exceptions. Martin, in particular, has become an out

Re: Keep the Things You Forgot

2013-10-23 Thread Mario Fux KDE ML
Am Dienstag, 22. Oktober 2013, 22.27:18 schrieb Aaron J. Seigo: > hi :) Morning guys > (i stole the subject without shame. but it seemed appropriate given the > topic) > > we’ve all gotten out of the habit of communicating with the outside world, > with some notable exceptions. Martin, in partic

Re: Porting away from KLocale

2013-10-23 Thread John Layt
On 23 October 2013 12:56, Aleix Pol wrote: > On Tue, Oct 22, 2013 at 2:03 PM, David Faure wrote: >> >> On Thursday 17 October 2013 23:47:40 Aleix Pol wrote: >> > Well maybe I could help with this, but I'd need to know what do you >> > think >> > it would be the most appropriate solution. >> >> I'

Review Request 113406: Add a macro to automatically generate forward headers

2013-10-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- Review request for Build System, KDE Frameworks and Stephen Kelly. Reposit

Re: Config files naming policy

2013-10-23 Thread Ivan Čukić
I guess I'll rename my config file then. I've been using activitymanagerrc, while the binary was actually prefixed with a 'k' and suffixed with a 'd'. :) Ch ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/l

Re: Review Request 113373: Enable C++11 support by default.

2013-10-23 Thread Ivan Čukić
> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote: > > As far as I know, only threadweaver and karchive will be released in > > December. The rest of the frameworks won't be released until summer. > > > > By summer, CMake 3.0.0 will most likely be out. > > Volker Krause wrote: > while th

Re: Review Request 113402: Fix KI18n standalone build

2013-10-23 Thread Aurélien Gâteau
> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113402: Fix KI18n standalone build

2013-10-23 Thread Chusslove Illich
> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113402: Fix KI18n standalone build

2013-10-23 Thread Aleix Pol Gonzalez
> On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113402: Fix KI18n standalone build

2013-10-23 Thread Chusslove Illich
> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113402: Fix KI18n standalone build

2013-10-23 Thread Aleix Pol Gonzalez
> On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113402: Fix KI18n standalone build

2013-10-23 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113402/#review4 --- I can only say that whatever is the proper fix here, it is fine

Review Request 113402: Fix KI18n standalone build

2013-10-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113402/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/#review42220 --- This review has been submitted with commit 9d1f66372e2510b39d2

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/ --- (Updated Oct. 23, 2013, 2:16 p.m.) Status -- This change has been mar

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-23 Thread David Edmundson
> On Oct. 15, 2013, 1:40 p.m., Kevin Ottens wrote: > > tier2/kcompletion/src/klineedit.cpp, line 1174 > > > > > > Couldn't it use QKeySequence::DeleteCompleteLine instead? or is > > KStandardShortcut::Clear diff

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-23 Thread Martin Gräßlin
> On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: > > Tested the patch in my tree, works for caps lock too. > > > > Now it highlights a dependency problem... We don't want a dependency on > > QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to > > your proposed KX11Extra

Re: Review Request 113373: Enable C++11 support by default.

2013-10-23 Thread Volker Krause
> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote: > > As far as I know, only threadweaver and karchive will be released in > > December. The rest of the frameworks won't be released until summer. > > > > By summer, CMake 3.0.0 will most likely be out. while the CMake 3 solution is obviously

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1480

2013-10-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113400: Make sure kdesu can find kdesu_export.h while building

2013-10-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113400/ --- (Updated Oct. 23, 2013, 12:34 p.m.) Status -- This change has been ma

Re: Review Request 113400: Make sure kdesu can find kdesu_export.h while building

2013-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113400/#review42208 --- This review has been submitted with commit 0003f9ca22fd5ef70a2

Re: Review Request 113400: Make sure kdesu can find kdesu_export.h while building

2013-10-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113400/#review42206 --- Ship it! Ship It! - Martin Klapetek On Oct. 23, 2013, 12:19

Review Request 113400: Make sure kdesu can find kdesu_export.h while building

2013-10-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113400/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Build failed in Jenkins: kdelibs_frameworks_qt5 #1479

2013-10-23 Thread KDE CI System
See Changes: [mgraesslin] Fix #include -- [...truncated 5733 lines...] from :25,

Re: Review Request 113365: Fix #include

2013-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113365/#review42203 --- This review has been submitted with commit d99bb1451d7c7e50d3f

Re: Review Request 113365: Fix #include

2013-10-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113365/ --- (Updated Oct. 23, 2013, 11:21 a.m.) Status -- This change has been ma

Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/ --- (Updated Oct. 23, 2013, 11:18 a.m.) Status -- This change has been di

Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/#review42201 --- Ship it! It definitely needs to be there, although Ben already

Re: Re: workspace fails in dateandtime kcm

2013-10-23 Thread Martin Gräßlin
On Sunday 20 October 2013 13:00:18 Christoph Feck wrote: > On Sunday 20 October 2013 12:30:05 Martin Graesslin wrote: > > On Sunday 20 October 2013 11:44:48 Christoph Feck wrote: > > > Hi, > > > > > > I am getting this weird error during "make" (not "make install"): > > > > > > /bin/sh: /local/gi

Re: Review Request 113395: Enable KConfig on Windows

2013-10-23 Thread Alexander Richardson
> On Oct. 23, 2013, 3:25 a.m., Andrius da Costa Ribas wrote: > > tier1/kconfig/src/core/kconfigini.cpp, line 425 > > > > > > Files have no owner on Windows. QFileInfo::ownerId() always returns -2 > > on Windows a

Re: Porting away from KLocale

2013-10-23 Thread Aleix Pol
On Tue, Oct 22, 2013 at 2:03 PM, David Faure wrote: > On Thursday 17 October 2013 23:47:40 Aleix Pol wrote: > > Well maybe I could help with this, but I'd need to know what do you think > > it would be the most appropriate solution. > > I'd say, split it out into a separate function for KF5, and

Re: Forward includes

2013-10-23 Thread Aleix Pol
On Tue, Oct 22, 2013 at 11:06 AM, Ivan Čukić wrote: > > > The above is pretty much it on my side, but I'd like to add something: > > We should get those forwarding includes generated to not have to maintain > > Lets bring this topic back from the dead. > > I don't have a real preference between i

Re: Forward includes

2013-10-23 Thread Aleix Pol
On Mon, Oct 21, 2013 at 11:39 AM, Kevin Ottens wrote: > Hello, > > On Friday 18 October 2013 20:24:00 Aleix Pol wrote: > > I realized recently that we have a weird setup for those CamelCased > > includes that now we keep in kdelibs/includes, so I was guessing that > > probably we want to split th

Review Request 113399: Fix KAuthActionReply copy constructor

2013-10-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113398: Make KNotifications build standalone

2013-10-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113398/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

phonon5 phonon4 phonon4qt5

2013-10-23 Thread Harald Sitter
since sebas asked me to bring up the phonons as he fears that lack of actual source compat in phonon5 could compromise the frameworks effort there will be the following libraries: === phonon5 === (current five branch) will *not* be 100% source compatible because pieces of the architecture disapp

kio kfilewidget.h problem

2013-10-23 Thread Treeve Jelbert
kio installs kfilewidget.h which references kio/kiofilewidgets_export.h which is not installed This causes subsequent compile failures in kross ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Config files naming policy

2013-10-23 Thread David Faure
On Monday 21 October 2013 12:03:37 Ivan Čukić wrote: > Hi all, > > Since we are now sharing the locations of our configs with non-kde software, > we can potentially get collisions with those. > > I'm proposing changing the names of the config files to org.kde.something > (or some other alternativ