----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/#review42257 -----------------------------------------------------------
Ship it! Looks good to me (although you left an odd bit of whitespace in uploaddialog_p.h) knewstuff/src/uploaddialog_p.h <http://git.reviewboard.kde.org/r/113388/#comment30754> Whitespace? - Alex Merry On Oct. 23, 2013, 9:45 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113388/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 9:45 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Ported knewstuff from KImageIO to QImageReader to get the qimage supported > file formats to put in a filter for QFileDialog. > > > Diffs > ----- > > knewstuff/src/CMakeLists.txt a42d35443c0d3596d8ef18e46a1ec905fd14a33a > knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b > knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1 > > Diff: http://git.reviewboard.kde.org/r/113388/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
