Review Request 113226: Cleanup kdirwatch includes.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113226/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #1423

2013/10/13 KDE CI System : > See This is a failure in a KArchive test, regarding the assertion dt.secsTo(creationTime) <= 1. The change that triggered this build only added comments in KDirWatch; nowhere near the KArchive code. So this

Jenkins build became unstable: kdelibs_frameworks_qt5 #1423

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/ --- (Updated Oct. 13, 2013, 3:19 a.m.) Status -- This change has been mar

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/#review41623 --- This review has been submitted with commit 9c3a5107f7939b7b6fb

Re: KNotifyConfig cmake vars problem

On Saturday, October 12, 2013 14:29:19 Stephen Kelly wrote: > Sebastian Kügler wrote: > > Hey, > > > > I'm trying to build konsole, which requires KNotifyConfig, but I'm having > > trouble importing the target. > > Update your ecm, and konsole repos and discard your patch. It is not needed. > >

Re: plasma-framework build broken

On Saturday, October 12, 2013 21:48:28 Sebastian Kügler wrote: > It seems that one of your recent commits to plasma-frameworks broke its > build: > > /home/sebas/kf5/src/plasma- > framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltes > t.cpp:23:23: fatal error: qtest_kde.h:

Jenkins build is back to normal : plasma-framework_master_qt5 #806

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #805

See Changes: [sebas] Revert bef789642e4bc245b -- [...truncated 25 lines...] libstreams - Branch master phonon - Branch master extra-cmake-modules - Branch master libstre

plasma-framework build broken

Hi Steve, It seems that one of your recent commits to plasma-frameworks broke its build: /home/sebas/kf5/src/plasma- framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23:23: fatal error: qtest_kde.h: No such file or directory Readding the things you removed ther

Re: Review Request 113215: Fix casing in KPty cmake vars

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/ --- (Updated Oct. 12, 2013, 6:55 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ --- (Updated Oct. 12, 2013, 6:30 p.m.) Review request for KDE Frameworks, kdel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review41603 --- kded/kbuildsycoca.cpp

Re: Review Request 113215: Fix casing in KPty cmake vars

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/#review41602 --- tier3/kpty/KPtyConfig.cmake.in

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: > > We are here making a 'hole' for people to do 'bad things' that wasn't > > possible in the past. I'm not sure we want that. > > Mark Gaiser wrote: > Interesting. > So that mean we simply can't use the new signal/slot syntax because of

Re: Review Request 112730: add CMake changes to knewstuff

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review41599 --- Ship it! minor things found, but don't let that stop you kne

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ --- (Updated Oct. 12, 2013, 2:08 p.m.) Review request for KDE Frameworks, kdel

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: > > We are here making a 'hole' for people to do 'bad things' that wasn't > > possible in the past. I'm not sure we want that. > > Mark Gaiser wrote: > Interesting. > So that mean we simply can't use the new signal/slot syntax because of

Jenkins build is back to normal : plasma-framework_master_qt5 #804

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #803

See Changes: [stephen.kelly] Try to fix the plasma include dirs failure on bko. -- [...truncated 464 lines...]

Build failed in Jenkins: plasma-framework_master_qt5 #802

See Changes: [stephen.kelly] Remove obsolete include_directories use. -- [...truncated 475 lines...] Generating moc_customDataContainersEngine.cpp Generating moc_httpContainer.cpp [ 16%] Bu

Re: Categorized logging in KDE?

On Sat, Oct 12, 2013 at 10:42 AM, David Faure wrote: > On Wednesday 09 October 2013 15:29:56 Mark wrote: > > Hi, > > > > As you all probably know by now, Qt has included of categorized logging > [1] > > as of 5.2. > > In KDE we've had categorized logging for ages, but while porting to > > Framewo

Re: KNotifyConfig cmake vars problem

Sebastian Kügler wrote: > Hey, > > I'm trying to build konsole, which requires KNotifyConfig, but I'm having > trouble importing the target. Update your ecm, and konsole repos and discard your patch. It is not needed. Thanks, Steve. ___ Kde-framewo

Re: [extra-cmake-modules] find-modules: Remove the check for the LIBRARIES variable.

Stephen Kelly wrote: > Some frameworks can have erroneous values (eg KConfigWidgets currently Oops, I meant KNotifyConfig. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[extra-cmake-modules] find-modules: Remove the check for the LIBRARIES variable.

Git commit b6ddac117f6e0d3e4a88ddaf8fbb769756f367ca by Stephen Kelly. Committed on 12/10/2013 at 12:24. Pushed by skelly into branch 'master'. Remove the check for the LIBRARIES variable. It is redundant and obsolete. Some frameworks can have erroneous values (eg KConfigWidgets currently sets Fo

KNotifyConfig cmake vars problem

Hey, I'm trying to build konsole, which requires KNotifyConfig, but I'm having trouble importing the target. When applying the attached patch to KNotifyConfig (which I believe should add the right variables), I'm getting CMake Error at /home/sebas/kf5/install/lib/x86_64-linux- gnu/cmake/KNotif

Review Request 113215: Fix casing in KPty cmake vars

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113157: Remove Nepomuk dependency from kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113157/#review41579 --- Ship it! Ship It! - David Faure On Oct. 7, 2013, 5:25 p.m.,

Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/#review41578 --- You should import the test app into kio/tests (and possibly men

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1413

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113197: KMessageBox: Factorize code between regular and *WId functions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113197/#review41576 --- Ship it! Looks good. - David Faure On Oct. 11, 2013, 8:56 a

Re: Review Request 113199: KHTML: KComponentData -> KAboutData

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/#review41575 --- Ship it! Ship It! - David Faure On Oct. 11, 2013, 12:16 p.m

Re: Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113182/#review41574 --- Ship it! tier1/itemviews/src/kcategorydrawer.h

Re: Categorized logging in KDE?

On Wednesday 09 October 2013 15:29:56 Mark wrote: > Hi, > > As you all probably know by now, Qt has included of categorized logging [1] > as of 5.2. > In KDE we've had categorized logging for ages, but while porting to > Frameworks we started using the "simple" Qt logging q Warning>. > > However,

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/#review41573 --- Ship it! So time_t does exist on Windows? Very interesting, I