----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113226/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kdelibs Description ------- Cleanup kdirwatch includes. * kdirwatch_p.h is including inotify.h, but it doesn't use any inotify types or macros. The types are only used in kdirwatch.cpp, so I moved the inotify includes there. * kdirwatch.cpp includes sys/ioctl.h and sys/utsname.h. These headers are not available in Windows, and they are only needed if inotify is present. Thus, include them in the #if HAVE_SYS_INOTIFY_H block. Diffs ----- tier1/kcoreaddons/src/lib/io/kdirwatch.cpp a56801a67fd787d879ac6b300f80a20a5d054bbe tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 3858bfaa68967d29327ca4319ab164af511d3186 Diff: http://git.reviewboard.kde.org/r/113226/diff/ Testing ------- Compiles and tests pass on Linux. Thanks, Nicolás Alvarez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
