Re: KIOWidgets and KFile

2013-09-29 Thread David Faure
On Sunday 29 September 2013 22:31:38 Sebastian Kügler wrote: > On Sunday, September 29, 2013 20:50:28 David Faure wrote: > > This is clearly because kbookmarks was written as part of kio, and with > > konqueror in mind. I guess the question is how generic we want KBookmarks > > to be, i.e. should

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-29 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review41013 --- The API seems too tied to the way XKB does things. I don't thin

Re: KIOWidgets and KFile

2013-09-29 Thread Mark
On Sun, Sep 29, 2013 at 10:31 PM, Sebastian Kügler wrote: > On Sunday, September 29, 2013 20:50:28 David Faure wrote: > > This is clearly because kbookmarks was written as part of kio, and with > > konqueror in mind. I guess the question is how generic we want KBookmarks > > to be, i.e. should i

Re: Making KDocTools independent of KArchive

2013-09-29 Thread Albert Astals Cid
El Diumenge, 29 de setembre de 2013, a les 12:14:49, David Faure va escriure: > On Monday 23 September 2013 20:23:13 Albert Astals Cid wrote: > > So we don't have a man page anymore? Debian will be happy :D > > > > Also we're losing the i18n-zation side of the man page, which the current > > -- he

Re: KIOWidgets and KFile

2013-09-29 Thread Sebastian Kügler
On Sunday, September 29, 2013 20:50:28 David Faure wrote: > This is clearly because kbookmarks was written as part of kio, and with > konqueror in mind. I guess the question is how generic we want KBookmarks > to be, i.e. should it work without KIO altogether (at the expense of > losing automatic

Re: KIOWidgets and KFile

2013-09-29 Thread Kevin Ottens
Hello, On Sunday 29 September 2013 20:50:28 David Faure wrote: > I need input on solving a dependency issue. > > The current kdelibs/kfile is the set of widgets that make up the contents of > the file dialog (embeddable "file widget", tree view, places model, preview > support, new file popupmenu

Re: KIOWidgets and KFile

2013-09-29 Thread Sune Vuorela
On 2013-09-29, David Faure wrote: > Help :) maybe KIOBookmarks should just be merged into KIOFileWidgets ? /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kcmutils linking issues

2013-09-29 Thread David Faure
On Wednesday 25 September 2013 16:53:23 Antonis Tsiapaliokas wrote: > Hello, > > I am trying to link kcmutils to kwincompositing > (kwincompositing is the new version of the KWin Effects KCM). > > A few days before everything was working fine, until the kdeqt5staging was > being removed from the

Re: Review Request 112730: Make knewstuff build standalone

2013-09-29 Thread David Faure
> On Sept. 17, 2013, 7:30 a.m., David Faure wrote: > > knewstuff/CMakeLists.txt, line 9 > > > > > > Does this really build when building all of kdelibs in one go? I > > thought we determined that find_package of kf

KIOWidgets and KFile

2013-09-29 Thread David Faure
I need input on solving a dependency issue. The current kdelibs/kfile is the set of widgets that make up the contents of the file dialog (embeddable "file widget", tree view, places model, preview support, new file popupmenu, breadcrumb url navigator...). It was separate for reasons that don't

Re: kde4_add_plugin on KF5

2013-09-29 Thread Stephen Kelly
David Faure wrote: > On Thursday 19 September 2013 19:39:54 Alexander Neundorf wrote: >> But I think Stephens plan is to get rid of those macros and use plain >> cmake instead, i.e. add_library(... MODULE ...), as with add_executable() >> and add_library(). > > I've always been surprised that cma

Re: Review Request 112929: Remove KPluginVerificationData

2013-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112929/#review41007 --- staging/kservice/src/plugin/kexportplugin.h

Re: Review Request 112929: Remove KPluginVerificationData

2013-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112929/#review41006 --- Ship it! Ship It! - David Faure On Sept. 25, 2013, 11:50 a.

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
> On Sept. 29, 2013, 4:24 p.m., David Faure wrote: > > The name "token" surprises me a bit. Is this a usual naming scheme for > > accessing C++ classes from QML? > > Otherwise I would think the QML code would want to just write KColorScheme. > > > > Maybe the registration could be done in a sta

Re: Review Request 112913: Move KModifierKeyInfo from GuiAddons to KWindowSystem

2013-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112913/#review41004 --- -1, see https://git.reviewboard.kde.org/r/112443/ - David Faur

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-29 Thread David Faure
> On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: > > Tested the patch in my tree, works for caps lock too. > > > > Now it highlights a dependency problem... We don't want a dependency on > > QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to > > your proposed KX11Extra

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 29, 2013, 4:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review41002 --- The name "token" surprises me a bit. Is this a usual naming sch

Re: Making KDocTools independent of KArchive

2013-09-29 Thread David Faure
On Monday 23 September 2013 20:23:13 Albert Astals Cid wrote: > So we don't have a man page anymore? Debian will be happy :D > > Also we're losing the i18n-zation side of the man page, which the current -- > help does not have. What do non-kde projects do? Write a man page by hand and translate i

Re: Review Request 112966: Dispatch KInterProcessWindowing to other frameworks

2013-09-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112966/#review40980 --- +1, but someone else has to approve - Martin Gräßlin On Sept