Jenkins build became unstable: kdelibs_stable #807

2013-09-08 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig

2013-09-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112598/ --- Review request for KDE Frameworks. Description --- The behavior to ge

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/#review39621 --- Ship it! Ship It! - David Faure On Sept. 2, 2013, 3:13 p.m.

Re: Review Request 112556: Move itemviews to tier2

2013-09-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/ --- (Updated Sept. 9, 2013, 8:44 a.m.) Review request for KDE Frameworks. Ch

Jenkins build became unstable: kdelibs_frameworks_qt5 #1164

2013-09-08 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #698

2013-09-08 Thread KDE CI System
See Changes: [mgraesslin] Rework finding of XCB -- [...truncated 436 lines...] :0: Note: N

Re: Review Request 112537: Improve signal emitting in KSelectionOwner

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112537/ --- (Updated Sept. 9, 2013, 4:29 a.m.) Status -- This change has been mar

Re: Review Request 112532: Extend KShortcutsEditor by an actionTypes property

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112532/ --- (Updated Sept. 9, 2013, 4:29 a.m.) Status -- This change has been mar

Re: Review Request 112537: Improve signal emitting in KSelectionOwner

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112537/#review39620 --- This review has been submitted with commit d5454f14f52f8c7cab6

Re: Review Request 112532: Extend KShortcutsEditor by an actionTypes property

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112532/#review39619 --- This review has been submitted with commit 4dffa921c9dee5f97ad

Re: Review Request 112499: Rework finding of XCB

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112499/ --- (Updated Sept. 9, 2013, 4:15 a.m.) Status -- This change has been mar

Re: Review Request 112499: Rework finding of XCB

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112499/#review39618 --- This review has been submitted with commit 97ce3dc808ca616445d

Re: Review Request 112500: Adjust finding of XCB to new component based FindXCB

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112500/ --- (Updated Sept. 9, 2013, 4:14 a.m.) Status -- This change has been mar

Re: Review Request 112500: Adjust finding of XCB to new component based FindXCB

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112500/#review39617 --- This review has been submitted with commit 9423dedc67319aeb3e8

Re: Review Request 112151: Use components in FindXCB

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39616 --- This review has been submitted with commit c5597c4cf761eeb9d89

Re: Review Request 112151: Use components in FindXCB

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Sept. 9, 2013, 4:13 a.m.) Status -- This change has been mar

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-08 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112527/ --- (Updated Sept. 9, 2013, 12:05 a.m.) Review request for KDE Frameworks. C

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

2013-09-08 Thread Vishesh Handa
> On Aug. 30, 2013, 11:01 p.m., David Faure wrote: > > kio/kio/kmimetypechooser.cpp, line 231 > > > > > > QStringLiteral() Ping? - Vishesh --- This is a

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-08 Thread David Faure
> On Sept. 8, 2013, 8:45 a.m., David Faure wrote: > > staging/kemoticons/src/core/kemoticonsprovider.cpp, line 146 > > > > > > file.fileName() is the same as emo. Yes, the name of the methods in > > QFile are a b

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-08 Thread David Gil Oliva
> On Sept. 8, 2013, 8:45 a.m., David Faure wrote: > > staging/kemoticons/src/core/kemoticonsprovider.h, line 85 > > > > > > absolute path, or relative path? All of them are absolute. Should I specify it in the doc

Re: Review Request 112547: avoid creating jobs on urls with double slashes

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112547/#review39581 --- Please test https://codereview.qt-project.org/64926, it should

Re: Plugin locator performance ballpark

2013-09-08 Thread Boudewijn Rempt
On Sun, 8 Sep 2013, Boudewijn Rempt wrote: I like the directoryname idea, and actually, I'd go for a hierarchy: calligra/filter calligra/parts calligra/words calligra/krita/paintop calligra/krita/filter calligra/krita/extensions etcetera. that should limit the number of plugins per directory

Re: Plugin locator performance ballpark

2013-09-08 Thread Boudewijn Rempt
On Sun, 8 Sep 2013, David Faure wrote: On Thursday 05 September 2013 01:04:52 Sebastian Kügler wrote: Reading just $PLUGINS/kf5, 52 plugins 21893.0 microsec (KServiceTypeTrader) 95835.0 microsec (Metadata) --> Reading metadata is 4-5 slower, ~100ms Reading $PLUGINS recursively, 127 plugins

Re: Plugin locator performance ballpark

2013-09-08 Thread Alexander Neundorf
On Sunday 08 September 2013, David Faure wrote: > On Thursday 05 September 2013 01:04:52 Sebastian Kügler wrote: > > Reading just $PLUGINS/kf5, 52 plugins > > > > 21893.0 microsec (KServiceTypeTrader) > > 95835.0 microsec (Metadata) > > > > --> Reading metadata is 4-5 slower, ~100ms > > > >

Re: Review Request 112574: Reorganizing knewstuff framework

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112574/#review39572 --- Ship it! knewstuff/knewstuff3/ui/entrydetailsdialog.h

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112570/#review39569 --- Anything that had "TEST" should now have ecm_mark_as_test. You

Re: Review Request 112571: enable clearButton in kpassworddialog

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112571/#review39571 --- Ship it! Ship It! - David Faure On Sept. 6, 2013, 7:01 p.m.

Re: Review Request 112537: Improve signal emitting in KSelectionOwner

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112537/#review39568 --- Ship it! If you say so :) - David Faure On Sept. 5, 2013, 2

Re: Plugin locator performance ballpark

2013-09-08 Thread David Faure
On Thursday 05 September 2013 01:04:52 Sebastian Kügler wrote: > Reading just $PLUGINS/kf5, 52 plugins > 21893.0 microsec (KServiceTypeTrader) > 95835.0 microsec (Metadata) > --> Reading metadata is 4-5 slower, ~100ms > > Reading $PLUGINS recursively, 127 plugins > 20180.0 microsec (KService

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 8, 2013, 8:54 a.m.) Review request for KDE Frameworks and A

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

2013-09-08 Thread David Faure
> On Sept. 3, 2013, 12:34 p.m., David Faure wrote: > > staging/kbookmarks/tests/CMakeLists.txt, line 9 > > > > > > Isn't that only for unittests? > > David Edmundson wrote: > If this is wrong kconfigwidgets and

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112527/#review39561 --- one last issue staging/kemoticons/src/core/kemoticonsprovider

Re: Review Request 112547: avoid creating jobs on urls with double slashes

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112547/#review39560 --- Thanks for the investigation. This check would have to be done

Re: KCompletion and KNotification

2013-09-08 Thread David Faure
On Thursday 05 September 2013 19:34:36 Aleix Pol wrote: > Hi, > KCompletion now depends on KNotification, I'd suggest to remove that > dependency (I can do it myself). > > At the moment it's generating quite a bit of DBus noise even though it's > not being consumed anywhere I could find. > It's us

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39558 --- Patch missing. - David Faure On Sept. 5, 2013, 5:23 p.m., Al

Re: Review Request 112557: Remove all links to libkdeqt5staging

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112557/#review39557 --- Ship it! Ship It! - David Faure On Sept. 6, 2013, 1:54 p.m.