-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112537/#review39568
-----------------------------------------------------------

Ship it!


If you say so :)

- David Faure


On Sept. 5, 2013, 2:34 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112537/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 2:34 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> I kind of broke it when adjusting to the unit test. We have to wait for the 
> previous owner to destroy its window before emitting the claim signal. If we 
> time out without the window closed, we should emit the failed signal though. 
> Otherwise a client will wait forever. 
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/src/kmanagerselection.cpp 9623ed6 
> 
> Diff: http://git.reviewboard.kde.org/r/112537/diff/
> 
> 
> Testing
> -------
> 
> KWin can replace itself again.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to