Re: Review Request 111644: Delete included kde_file.h actually not used

> On July 22, 2013, 8:42 p.m., David Faure wrote: > > Trivial enough. If it builds, it's correct. > > Kevin Ottens wrote: > That said, it needs 111636 to be in first. > > David Gil Oliva wrote: > Kevin, I'm surprised, I don't see the connection with #111636. I have > written this patch

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > > > > > > Should be "const QString &" > > David Gil Oliva wrote: > I think you didn't notice something import

cmake problems in KDELibs4Config

Hi, I'm getting the following two errors when trying to build plasma-framework: macro_ensure_version doesn't exist anymore, but is used in KDELibs4Config.cmake. Is there a replacement for it? Then: CMake Error at CMakeLists.txt:70 (find_package): Found package configuration file: /home/

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 11:19 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 324 > > > > > > For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm > > not sure what it difference

Re: Review Request 111644: Delete included kde_file.h actually not used

> On July 22, 2013, 8:42 p.m., David Faure wrote: > > Trivial enough. If it builds, it's correct. > > Kevin Ottens wrote: > That said, it needs 111636 to be in first. Kevin, I'm surprised, I don't see the connection with #111636. I have written this patch because I wanted to clean up the t

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > It would be nice if your test program could be turned into an automated > > test and added to this review. Ok, I'll try. > On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > >

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 11:19 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 324 > > > > > > For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm > > not sure what it difference

Jenkins build is back to stable : kdelibs_frameworks_qt5 #905

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111605: move kfreediskspace to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111605/#review36225 --- Ship it! Ship It! - David Faure On July 20, 2013, 5:11 p.m.

Re: Review Request 111605: move kfreediskspace to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111605/ --- (Updated July 20, 2013, 5:11 p.m.) Review request for KDE Frameworks. De

Re: Review Request 111539: Move kundoactions and kcheckaccelerators to xmlgui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111539/#review36214 --- This review has been submitted with commit b769c656a673aa9f0ae

Re: Review Request 111605: move kfreediskspace to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111605/#review36197 --- staging/kde4support/src/CMakeLists.txt

Re: KStandardDirs and locale path

> [: Albert Astals Cid :] > Chusslove, now that we're discussing this, the current kde4 code allows > .mo files to be under ~/.kde/ (thanks to the multiple possible paths of > kstandarddirs) while the new one only finds them on > QStandardPaths::GenericDataLocation, I know some teams (and even loka

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

> On July 23, 2013, 8:47 p.m., Alexander Neundorf wrote: > > What's the current state of dbusmenuqt ? > > Can it be built against both Qt4 and Qt5 ? > > If so, do they have different version numbers then ? > > I don't like that an old version of FindDBusMenuQt.cmake will find the Qt4 > > version

Jenkins build became unstable: kdelibs_frameworks_qt5 #903

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111530: Move KConfigDialog to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111530/ --- (Updated July 23, 2013, 7:03 p.m.) Status -- This change has been mar

Re: Review Request 111530: Move KConfigDialog to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111530/#review36410 --- This review has been submitted with commit 3aabf7e5395567ec801

Re: Review Request 111651: Move KCModule to KConfigWidgets

> On July 23, 2013, 8:52 p.m., Alexander Neundorf wrote: > > By replacing the LIBRARIES variables with the target names this broke the > > standalone build of kconfigwidgets. > > > > I can replace it again, but I saw others modules do that. This should be fixed everywhere then, or I'm wrong?

Re: Review Request 111651: Move KCModule to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111651/#review36407 --- By replacing the LIBRARIES variables with the target names this

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36406 --- What's the current state of dbusmenuqt ? Can it be built agains

Re: Review Request 111599: Move KGesture and KGestureMap to KDE4Attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111599/#review36405 --- This review has been submitted with commit b5fb5ce7b188b407465

Re: Review Request 111599: Move KGesture and KGestureMap to KDE4Attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111599/ --- (Updated July 23, 2013, 6:45 p.m.) Status -- This change has been mar

Jenkins build is back to stable : kdelibs_frameworks_qt5 #902

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111653: Move KDEUI tests in their modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/#review36391 --- This review has been submitted with commit 1ea2cab0465c941c0bb

Re: Review Request 111653: Move KDEUI tests in their modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/ --- (Updated July 23, 2013, 4:51 p.m.) Status -- This change has been mar

Re: Review Request 111653: Move KDEUI tests in their modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/#review36389 --- Ship it! Ship It! - David Faure On July 23, 2013, 4:41 p.m.

Re: Review Request 111653: Move KDEUI tests in their modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/ --- (Updated July 23, 2013, 6:41 p.m.) Review request for KDE Frameworks. Ch

Re: Fancy header policy

On Tuesday 23 July 2013, Kevin Ottens wrote: > On Saturday 20 July 2013 03:12:25 Vishesh Handa wrote: ... > > Also, under what folder name should there includes be installed? > > Currently the fancy includes are installed in a KDE folder > > (/include/KDE/fancyHeaders). Do we want to continue with

Re: Using target names directly vs. variables

On Monday 22 July 2013, David Faure wrote: > On Sunday 14 July 2013 21:44:38 Alexander Neundorf wrote: > > On Sunday 14 July 2013, David Faure wrote: > > > On Sunday 14 July 2013 11:42:26 Alexander Neundorf wrote: > > > > A good step forward to improve the experience for the user is to > > > > foll

Re: Review Request 111653: Move KDEUI tests in their modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/#review36387 --- staging/kguiaddons/CMakeLists.txt

Re: Review Request 111653: Move KDEUI tests in their modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/#review36385 --- staging/kguiaddons/tests/CMakeLists.txt

KF5 Update Meeting Minutes 2013-w30

Hello everyone, This is the minutes of the Week 30 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: ben2367, dfaure, miroslav, sandsmark, scarpino, sebas, steveire, wojtask9 and myself. Announcements: * Everyone update your qt5.git, we'll soon start to use

Re: Review Request 111653: Move KDEUI tests in their modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/ --- (Updated July 23, 2013, 4:15 p.m.) Review request for KDE Frameworks. De

Review Request 111653: Move KDEUI tests in their modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/ --- Review request for KDE Frameworks. Description --- Some {auto,}test h

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 11:19 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 324 > > > > > > For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm > > not sure what it difference

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/ --- (Updated July 23, 2013, 1:23 p.m.) Review request for KDE Frameworks and P

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review36282 --- staging/kio/src/core/authinfo.cpp

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/ --- (Updated July 23, 2013, 1:16 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

> On July 23, 2013, 11:45 a.m., Kevin Ottens wrote: > > cmake/modules/FindDBusMenuQt.cmake, line 45 > > > > > > We probably want to bump the required minimum version to 0.9 instead of > > removing that block. Not

Re: Review Request 111584: Use correct path for including export headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111584/ --- (Updated July 23, 2013, 12:38 p.m.) Review request for KDE Frameworks. C

Build failed in Jenkins: kdelibs_frameworks_qt5 #900

See Changes: [scarpino] Move KCModule to KConfigWidgets -- [...truncated 15797 lines...] from

Re: Review Request 111651: Move KCModule to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111651/ --- (Updated July 23, 2013, 9:56 a.m.) Status -- This change has been mar

Re: Review Request 111651: Move KCModule to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111651/#review36357 --- This review has been submitted with commit 2ab5ed26bc9dbf2f02c

Build failed in Jenkins: kdelibs_frameworks_qt5 #899

See Changes: [arichardson.kde] fix compilation of WeaverImplState.cpp [scarpino] Port away from MacroPushRequiredVars -- [...truncated 15800 lines...] from

Re: Review Request 111584: Use correct path for including export headers

> On July 23, 2013, 9:35 a.m., Kevin Ottens wrote: > > tier1/sonnet/src/ui/configdialog.h, line 25 > > > > > > Are you sure about this one and the followings? It's odd if you need > > them as it just change the pr

Re: Review Request 111651: Move KCModule to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111651/#review36355 --- Ship it! Ship It! - Kevin Ottens On July 23, 2013, 8:48 a.m

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/#review36354 --- Probably worth adding a typedef for QSharedPointer, just like

Re: Fancy header policy

On Tuesday, July 23, 2013 11:15:52 AM Kevin Ottens wrote: > On Tuesday 23 July 2013 10:05:59 Benjamin Port wrote: > > On Tuesday, July 23, 2013 08:49:48 AM Kevin Ottens wrote: > > > The ideal situation would be to get them generated, but I don't think > > > anyone put the work in yet. > > > > Yes,

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36353 --- cmake/modules/FindDBusMenuQt.cmake

Re: Review Request 111644: Delete included kde_file.h actually not used

> On July 22, 2013, 8:42 p.m., David Faure wrote: > > Trivial enough. If it builds, it's correct. That said, it needs 111636 to be in first. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.

Re: Review Request 111584: Use correct path for including export headers

> On July 23, 2013, 11:35 a.m., Kevin Ottens wrote: > > tier1/sonnet/src/ui/configdialog.h, line 25 > > > > > > Are you sure about this one and the followings? It's odd if you need > > them as it just change the p

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review36350 --- It would be nice if your test program could be turned into an a

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/#review36349 --- Ship it! Ship It! - Kevin Ottens On July 8, 2013, 4:09 p.m.

Re: Review Request 111599: Move KGesture and KGestureMap to KDE4Attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111599/#review36348 --- Ship it! Ship It! - Kevin Ottens On July 19, 2013, 12:15 p.

Re: Review Request 111584: Use correct path for including export headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111584/#review36347 --- tier1/sonnet/src/ui/configdialog.h

Re: Review Request 111530: Move KConfigDialog to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111530/#review36346 --- Ship it! Ship It! - Kevin Ottens On July 16, 2013, 10:41 a.

Re: Fancy header policy

On Tuesday 23 July 2013 10:05:59 Benjamin Port wrote: > On Tuesday, July 23, 2013 08:49:48 AM Kevin Ottens wrote: > > The ideal situation would be to get them generated, but I don't think > > anyone put the work in yet. > > Yes, I think we need to find a way to generate fancy header. But we probab

Build failed in Jenkins: plasma-framework_master_qt5 #521

See Changes: [ervin] Revert "Revert "Enabling C++11 flags for clang and gcc"" -- [...truncated 449 lines...] Generating moc_containmentinterface.cpp Generating declarativeappletscript.moc <

[plasma-framework] /: Revert "Revert "Enabling C++11 flags for clang and gcc""

Git commit 39cd64fc68b1dc2fc06f308e73ec5be1c78d28f6 by Kevin Ottens. Committed on 22/07/2013 at 11:21. Pushed by ervin into branch 'master'. Revert "Revert "Enabling C++11 flags for clang and gcc"" This reverts commit 597397b41f5450f24ddc784e0faa13133fed6bd5. Reverting my own revert now that we

Re: Fancy header policy

On 23/07/13 09:05, Benjamin Port wrote: > IMO we need to have subdirectory because we can't be sure that we don't have > 2 > headers with the same name in 2 differents frameworks. Except that if we did, that would suggest we had a class name duplicated across two frameworks, which would cause is

Review Request 111651: Move KCModule to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111651/ --- Review request for KDE Frameworks. Description --- = subj Diffs ---

Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/ --- Review request for KDE Frameworks and Plasma. Description --- ThreadW

Build failed in Jenkins: kdelibs_frameworks_qt5 #898

See Changes: [scarpino] Macro*.cmake ECM SourceIncompatChanges [scarpino] Move KRichTextWidget and KRichTextEdit to KTextWidgets -- [...truncated 3775 lines...] [ 22%] Building CXX object tier

Re: Fancy header policy

On Tuesday, July 23, 2013 08:49:48 AM Kevin Ottens wrote: > Hello, > > On Saturday 20 July 2013 03:12:25 Vishesh Handa wrote: > > I've been looking at the frameworks branch and I cannot help but > > notice that there is an 'include' folder which contains all the fancy > > headers. Is there any pol

Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/ --- Review request for KDE Frameworks. Description --- Prevent linking to

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111424/ --- (Updated July 23, 2013, 8:02 a.m.) Status -- This change has been mar

Re: Review Request 111080: Macro*.cmake changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111080/ --- (Updated July 23, 2013, 8:02 a.m.) Status -- This change has been mar

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111424/#review36341 --- This review has been submitted with commit b9cb4b0ac7cf06e0d15

Re: Review Request 111080: Macro*.cmake changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111080/#review36342 --- This review has been submitted with commit bef91befa6f7b289f83

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111424/#review36340 --- Ship it! Ship It! - David Faure On July 23, 2013, 7:54 a.m.

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111424/ --- (Updated July 23, 2013, 9:54 a.m.) Review request for KDE Frameworks. De

Build failed in Jenkins: kdelibs_frameworks_qt5 #897

See Changes: [mirko] Add dequeueRaw method, complement to enqueueRaw. -- [...truncated 3885 lines...] [ 24%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/devicem

Re: Using target names directly vs. variables

On Monday, July 22, 2013 10:34:33 PM David Faure wrote: > On Sunday 14 July 2013 21:44:38 Alexander Neundorf wrote: > > On Sunday 14 July 2013, David Faure wrote: > > > On Sunday 14 July 2013 11:42:26 Alexander Neundorf wrote: > > > > A good step forward to improve the experience for the user is to