----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111653/#review36385 -----------------------------------------------------------
staging/kguiaddons/tests/CMakeLists.txt <http://git.reviewboard.kde.org/r/111653/#comment26875> We have a problem here. A kguiaddons test cannot require kwidgetsaddons, these frameworks are supposed to be independent. It shouldn't even require Qt5::Widgets. If the test uses stuff from kwidgetsaddons it should move somewhere where it can use both kwidgetsaddons and kguiaddons. I suppose that would be kwidgets. The alternative is to port the test away from kwidgetsaddons and kwidgets, but we both know that QtQuick isn't really ready for the desktop :-) Let's just move the test program elsewhere. - David Faure On July 23, 2013, 2:15 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111653/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 2:15 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Some {auto,}test has not been moved in its respective module. > > This patch move: > - kactioncollectiontest > - kcategorizedviewtest > - kcolorcollectiontest > - klinkitemselectionmodeltest > - knotificationrestrictionstest > - krulertest > in their respective modules and fix kmodifierkeyinfotest. > > > Diffs > ----- > > kdeui/tests/CMakeLists.txt 19af839 > kdeui/tests/kactioncollectiontest.h > kdeui/tests/kactioncollectiontest.cpp > kdeui/tests/kcategorizedviewtest.cpp > kdeui/tests/kcolorcollectiontest.cpp b199a3a > kdeui/tests/klinkitemselectionmodeltest.h > kdeui/tests/klinkitemselectionmodeltest.cpp c3f7132 > kdeui/tests/knotificationrestrictionstest.cpp > kdeui/tests/krulertest.h > kdeui/tests/krulertest.cpp d94d73c > staging/itemviews/tests/CMakeLists.txt 46d191c > staging/kguiaddons/CMakeLists.txt d5e89d9 > staging/kguiaddons/tests/CMakeLists.txt afa6e3b > staging/kguiaddons/tests/kmodifierkeyinfotest.cpp 000fc28 > staging/knotifications/tests/CMakeLists.txt 775d811 > staging/xmlgui/autotests/CMakeLists.txt 8f56e2b > staging/xmlgui/tests/CMakeLists.txt b82364e > tier1/itemmodels/autotests/CMakeLists.txt 1a66642 > > Diff: http://git.reviewboard.kde.org/r/111653/diff/ > > > Testing > ------- > > - kactioncollectiontest: 10 passed, 0 failed, 0 skipped > - kcategorizedviewtest: works > - kcolorcollectiontest: nothing happens (do not segfault anyway) > - klinkitemselectionmodeltest: 3 passed, 0 failed, 0 skipped > - knotificationrestrictionstest: works > - krulertest: works > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
