Re: Review Request 110264: Change uses of QCoreApplication::translate() with no context to QObject::tr() in tier1 frameworks.

2013-05-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110264/#review31863 --- I'd indeed leave the QT_TRANSLATE_NOOP3 uses in even if the red

Re: Review Request 110264: Change uses of QCoreApplication::translate() with no context to QObject::tr() in tier1 frameworks.

2013-05-01 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110264/#review31864 --- tier1/kcodecs/src/kcharsets.cpp

Re: Plasma2 porting & framework-scratch branches

2013-05-01 Thread Sebastian Kügler
Hi Alex, On Wednesday, May 01, 2013 19:45:02 Alexander Neundorf wrote: > On Wednesday 01 May 2013, Sebastian Kügler wrote: > > Since we're running out of components to port in plasma-frameworks > > (*cough*), this seems like a useful point to focus our porting in > > non-random branches. Therefore

Review Request 110264: Change uses of QCoreApplication::translate() with no context to QObject::tr() in tier1 frameworks.

2013-05-01 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110264/ --- Review request for KDE Frameworks and David Faure. Description --- Ch

Re: Use of tr/i18n/QApplication::translate in tier1/2 frameworks

2013-05-01 Thread David Faure
On Tuesday 30 April 2013 19:02:40 George Goldberg wrote: > There's a task in the kdelibs_cleanup epic that's been assigned to me for a > few months, namely using the correct method call for translatable strings > in tier1/2 frameworks where ki18n isn't available. Way back, I changed > them all to

Re: Plasma2 porting & framework-scratch branches

2013-05-01 Thread Alexander Neundorf
On Wednesday 01 May 2013, Sebastian Kügler wrote: > Hi all, > > Since we're running out of components to port in plasma-frameworks > (*cough*), this seems like a useful point to focus our porting in > non-random branches. Therefore, I've created frameworks-scratch branches > in which we can merge

Re: share installPackage macro

2013-05-01 Thread Alexander Neundorf
On Wednesday 01 May 2013, Sebastian Kügler wrote: > Hi, > > Assume I want to share a macro defined in plasma-framework/CMakeLists.txt > with other repositories, how would I go about that in a few easy steps? > > (I'm talking about our installPackage macro, it's just a couple of lines, > but still

Plasma2 porting & framework-scratch branches

2013-05-01 Thread Sebastian Kügler
Hi all, Since we're running out of components to port in plasma-frameworks (*cough*), this seems like a useful point to focus our porting in non-random branches. Therefore, I've created frameworks-scratch branches in which we can merge our ported Plasma bits and pieces. They're pretty bare-bone

share installPackage macro

2013-05-01 Thread Sebastian Kügler
Hi, Assume I want to share a macro defined in plasma-framework/CMakeLists.txt with other repositories, how would I go about that in a few easy steps? (I'm talking about our installPackage macro, it's just a couple of lines, but still copying it feels wrong.) Cheers, -- sebas http://www.kde.o

Jenkins build is back to stable : plasma-framework_master_qt5 #418

2013-05-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel