----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110264/#review31863 -----------------------------------------------------------
I'd indeed leave the QT_TRANSLATE_NOOP3 uses in even if the redefine won't make it for the beauty contest. :-) I guess it's the price to pay to have that working with our infra. As for the use of QCoreApplication::translate in kconfig, the context doesn't bring much here, it could be changed to tr() just fine IMO. Rest of the patch looks fine to me, if it includes the change in kconfig it can go in IMO. - Kevin Ottens On May 1, 2013, 9:37 p.m., George Goldberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110264/ > ----------------------------------------------------------- > > (Updated May 1, 2013, 9:37 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Change uses of QCoreApplication::translate() with no context to QObject::tr() > in tier1 frameworks. > > There are no changes needed in tier 2. > > Issues outstanding: > * What do we do with the QT_TRANSLATE_NOOP_3 macro usage that we put in when > changing it to QCoreApplication::translate() previously? I'd propose leaving > it as is, because it seems like it would still work the same, but maybe > that's not the neatest plan > * kconfig/src/core/kconfig.cpp uses QCoreApplication::translate with the > "KConfig" context in one instance. Should this be left alone? > > > Diffs > ----- > > tier1/solid/src/solid/backends/kupnp/internetgatewaydevice1.cpp > 2cff30781764dcadde045fbed1f8a5ea24aa1b1f > tier1/solid/src/solid/backends/hal/haldevice.cpp > 8e433d9a96a9e15245f0c2d735950dfca8730ae6 > tier1/solid/src/solid/backends/fstab/fstabmanager.cpp > 46415e0776fcef4a8576ccc1f57417f5465d5484 > tier1/kcodecs/src/kencodingprober.cpp > 3008f3ba5fc833ae999194f7d33b9a8d95170398 > tier1/kcodecs/src/kcharsets.cpp 45f80b609abfdd131eded0cbe91e2287973046ca > tier1/solid/src/solid/backends/kupnp/kupnprootdevice.cpp > 664e72e5fbffb246402f7f1c87132125f7d87720 > tier1/solid/src/solid/backends/kupnp/mediaserver1.cpp > 28e8267afefe23382898dac5c86242db41746d6f > tier1/solid/src/solid/backends/kupnp/mediaserver2.cpp > 9967680429accc7fe7e45a73d65e7c33a6b308d5 > tier1/solid/src/solid/backends/kupnp/mediaserver3.cpp > 3805a5c52d89043046d66c2aaaf01b3699e5a13f > tier1/solid/src/solid/backends/udev/udevdevice.cpp > e00c37c816cb1c7c94a3460341f5b0b13088eb3a > tier1/solid/src/solid/backends/udev/udevmanager.cpp > 1446868cca7a42155478be0dc75be2fd47725e7f > tier1/solid/src/solid/backends/udisks/udisksdevice.cpp > e1c47afc952bf232b9fce1ffe053cce1b3b80a67 > tier1/solid/src/solid/backends/udisks/udisksmanager.cpp > 31e581656d98c0e103d6ceb605b3b0bfb4b00a54 > tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp > 1aa7b6d139be3ba5dc6d78e1ae55b2d0841dbfbd > tier1/solid/src/solid/backends/udisks2/udisksmanager.cpp > e76dfd1c94b39009ae4522ce9d3f535fc2c5eac2 > tier1/solid/src/solid/backends/upnp/upnpdevicemanager.cpp > e3cf29954da081bb5f23b859310f4f5a57e2702c > tier1/solid/src/solid/backends/upower/upowerdevice.cpp > c61bee940cf5e8295d99f055582317e7e626eedd > tier1/solid/src/solid/backends/upower/upowermanager.cpp > ee198a0ae0da44e35cc911e9fd830a78241bc867 > tier1/solid/src/solid/backends/wmi/wmibattery.cpp > 4b72f80514afa7fd7bbfe706d231ec669ed2f8d4 > tier1/solid/src/solid/backends/wmi/wmidevice.cpp > 0e85ae9c31eaab8c863e86845733dff17453456a > tier1/solid/src/solid/deviceinterface.cpp > 0cfc8e84ddbcbf31b44e881055ae173a6c589fdb > > Diff: http://git.reviewboard.kde.org/r/110264/diff/ > > > Testing > ------- > > Everything still compiles. > > > Thanks, > > George Goldberg > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
