Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review28100 --- Damn! I forgot a comment in my previous review... I was sure I

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-25 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/ --- (Updated Feb. 25, 2013, 9:03 p.m.) Review request for KDE Frameworks, Davi

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-25 Thread Valentin Rusu
> On Feb. 25, 2013, 8:54 a.m., Kevin Ottens wrote: > > kdeui/shortcuts/kglobalaccel.cpp, line 673 > > > > > > Wouldn't it be better to use actionShortcuts here? At that point, you > > could know about an action b

K_EXPORT_PLUGIN

2013-02-25 Thread Aaron J. Seigo
hi ... in kexportplugin.h there is this: #pragma message("K_EXPORT_PLUGIN is defined as a hack here, for compat. Port to new plugin system (QT_PLUGIN_METADATA) instead.") this was introduced in the first revision of this file (58606a42). i haven't been able to find any useful information onli

Re: kde4_create_manpage and translations

2013-02-25 Thread Chusslove Illich
On Saturday, 23. February 2013. 15.20.31 David Faure wrote: > This cmake macro converts docbook to man pages. It depends on kdoctools > though, so it creates an unwanted dependency, for low-level frameworks. > > Do we have to use docbook as the source for man pages? I presume this was > done >

Re: New "official" way how to use an installed kdelibs from the frameworks branch

2013-02-25 Thread Kevin Ottens
On Friday 22 February 2013 20:12:55 Alexander Neundorf wrote: > On Friday 22 February 2013, Kevin Ottens wrote: > > On Friday 22 February 2013 18:48:53 Alexander Neundorf wrote: > > > This is either > > > find_package(KConfig NO_MODULE) > > > or > > > find_package(KF5 COMPONENT KConfig) > > > > Hm,

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review27994 --- Almost there! :-) kdeui/shortcuts/kglobalaccel.h