Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-20 Thread Kevin Ottens
On Wednesday 20 February 2013 22:33:11 Valentin Rusu wrote: > > On Feb. 19, 2013, 7:20 a.m., Kevin Ottens wrote: > > > kdeui/shortcuts/kglobalaccel.h, line 167 > > > > > ine167>> > > > > Return a KShortcut here, not a cons

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-20 Thread Valentin Rusu
> On Feb. 19, 2013, 7:20 a.m., Kevin Ottens wrote: > > kdeui/actions/kaction.cpp, line 204 > > > > > > Aren't those checks already done in KGlobalAccel somehow? Just > > wondering if that makes sense to keep them

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-20 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/ --- (Updated Feb. 20, 2013, 10:32 p.m.) Review request for KDE Frameworks, Dav

Review Request 109056: remove KCoreConfigSkeleton::ItemEnum::Choice2

2013-02-20 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109056/ --- Review request for KDE Frameworks. Description --- remove KCoreConfig

Re: "kde5" or "kf5" ?

2013-02-20 Thread Alexander Neundorf
On Sunday 17 February 2013, David Faure wrote: > On Saturday 16 February 2013 17:23:46 Sune Vuorela wrote: > > On 2013-02-16, Alexander Neundorf wrote: ... > > > _set_fancy(XDG_APPS_INSTALL_DIR > > > "${SHARE_INSTALL_PREFIX}/applications/kde5" ) > > > > I'm also a bit unsure about this one. Sure

Re: "kde5" or "kf5" ?

2013-02-20 Thread Alexander Neundorf
On Monday 18 February 2013, Alexander Neundorf wrote: > On Sunday 17 February 2013, David Faure wrote: > > On Saturday 16 February 2013 17:23:46 Sune Vuorela wrote: > > > On 2013-02-16, Alexander Neundorf wrote: > > > > _set_fancy(LIBEXEC_INSTALL_DIR "${LIB_INSTALL_DIR}/kde5/libexec") > > > > >

Jenkins build is back to stable : kdelibs_frameworks_qt5 #431

2013-02-20 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdelibs frameworks buildsystem under Windows

2013-02-20 Thread Alexander Neundorf
On Wednesday 20 February 2013, Patrick Spendrin wrote: > Am 16.02.2013 18:48, schrieb Alexander Neundorf: > > Hi, > > First sorry for needing that long, the mail got into the wrong folder here. > > > we are doing quite some rework of the build system in the frameworks > > branch of kdelibs. > >

Build failed in Jenkins: kdelibs_frameworks_qt5 #427

2013-02-20 Thread KDE CI System
See Changes: [ervin+bluesystems] Position properly __KDE_HAVE_GCC_VISIBILITY for KJS_EXPORT [ervin+bluesystems] plugin -> src [ervin+bluesystems] Moving the framework integration plugin in a subdir [ervin+bluesystems] Add platform t

Re: qt5 includes

2013-02-20 Thread Stephen Kelly
Treeve Jelbert wrote: > I am trying to build kf5libs using the latest extra-cmake-modules and > yesterday's qtbase. > > At first I encountered a problem regarding qt support for SSL. I > bypassed that and then got several compile errors. > > They all seemed to be related to > > #include > > I

Re: "kde5" or "kf5" ?

2013-02-20 Thread Aaron J. Seigo
On Monday, February 18, 2013 21:35:07 Kevin Ottens wrote: > There's no will or indication that we'll release anything named KDE 5. If it > was me the next release of our workspaces would be Plasma Workspaces 2... It is likely we will not even release Plasma Workspaces $NEXT_VERSION_NUMBER at the

qt5 includes

2013-02-20 Thread Treeve Jelbert
I am trying to build kf5libs using the latest extra-cmake-modules and yesterday's qtbase. At first I encountered a problem regarding qt support for SSL. I bypassed that and then got several compile errors. They all seemed to be related to #include I then noticed that the compile flags had

Build failed in Jenkins: kdelibs_frameworks_qt5 #426

2013-02-20 Thread KDE CI System
See Changes: [jigneshhk1992] Port KDESRCDIR to QFINDTESTDATA. -- [...truncated 4888 lines...] CMakeFiles/ktranscript.dir/ktranscript.cpp.o:(.data.rel.ro._ZTV15ScriptfaceProto[vtable for Scriptf

Re: Patch: Port KDESRCDIR to QFINDTESTDATA.

2013-02-20 Thread David Faure
On Wednesday 20 February 2013 00:21:57 Jignesh Kakadiya wrote: > Hi David, > > I am able to port all the KDESRCDIR instances to QFINDTESDATA. Compiled and > tested. Please review. Good job. The only thing I don't like is the .toAscii(), which is wrong in case paths contain non-ascii characters.

Patch: Port KDESRCDIR to QFINDTESTDATA.

2013-02-20 Thread Jignesh Kakadiya
Hi David, I am able to port all the KDESRCDIR instances to QFINDTESDATA. Compiled and tested. Please review. Thanks, Jignesh QFINDTESTDATA_v3.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mai

Re: kdelibs frameworks buildsystem under Windows

2013-02-20 Thread Ralf Habacker
Am 17.02.2013 14:47, schrieb Laszlo Papp: Off-topic for now, but I would like to leave a note here: it would be nice to find the time to eliminate kdewin from as many places as possible. There are lots of things that are available in Qt nowadays. It would be worth the effort to give it a try

Re: Global shortcuts for clean qml plasmoids

2013-02-20 Thread Mark
On Wed, Feb 20, 2013 at 7:01 AM, Rick Stockton wrote: > On 02/14/2013 12:17 AM, Mark wrote: >> On Thu, Feb 14, 2013 at 8:43 AM, Michail Vourlakos >> wrote: >>> Based on >>> http://kdeblog.mageprojects.com/2012/12/07/application-wide-shortcuts-in-qml-this-time-without-qshortcut/ >>> >>> can you p

Build failed in Jenkins: kdelibs_frameworks_qt5 #425

2013-02-20 Thread KDE CI System
See Changes: [steveire] Fix constness of method override. [steveire] Trim trailing whitespace. -- [...truncated 4879 lines...]