----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109056/ -----------------------------------------------------------
Review request for KDE Frameworks. Description ------- remove KCoreConfigSkeleton::ItemEnum::Choice2 The obsolete Choice struct was removed, Choice2 has been renamed to Choice and Choice2 has been made a deprecated typedef. Should the deprecated version stay, or should it be removed? I don't think many people use this. According to http://lxr.kde.org/ident?i=Choice2 there are only two uses in kdepim Diffs ----- kdeui/tests/kconfigdialog_unittest.cpp 4f1a7a7d65aa08de29a8745ebc9cd7507bcb283d tier2/kconfig/autotests/kconfig_compiler/test1.cpp.ref 2f2977c160d83360aabb62bf36438b76aa61fb58 tier2/kconfig/autotests/kconfig_compiler/test11.cpp.ref 6daf86664aadd307d111be86c32db3bb74ef309f tier2/kconfig/autotests/kconfig_compiler/test11a.cpp.ref a0378a407c290a775c16fe9b8877fe298e2d456c tier2/kconfig/autotests/kconfig_compiler/test2.cpp.ref 447e837775336ca3d74c34f2506998dd293b74dd tier2/kconfig/autotests/kconfig_compiler/test4.cpp.ref 6f304738bdef675a92317b37ae682e803094ddde tier2/kconfig/autotests/kconfig_compiler/test5.cpp.ref af458e6152179eccbb2015ded995cb1237f0ff0a tier2/kconfig/autotests/kconfig_compiler/test_dpointer.cpp.ref 6aa770197c4f1a6b6f203c03443c8d539f387fec tier2/kconfig/src/core/kcoreconfigskeleton.h 5dc9e804d46651e052d53cff2a306f3b909604c5 tier2/kconfig/src/core/kcoreconfigskeleton.cpp aff4d4766a82509865459a85aa2928159b52f671 tier2/kconfig/src/kconfig_compiler/kconfig_compiler.cpp 60a8873e1017f9af759e6561ae1acc8c1e9b3f10 Diff: http://git.reviewboard.kde.org/r/109056/diff/ Testing ------- build works, kconfig unit test work Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
