Re: Review Request 108495: Make kimgio compile on Qt5

2013-01-19 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108495/#review25815 --- As far as I know, you need to add some JSON stuff to make plugi

Re: Review Request 108495: Make kimgio compile on Qt5

2013-01-19 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108495/ --- (Updated Jan. 19, 2013, 10:57 p.m.) Review request for KDE Frameworks. C

Review Request 108495: Make kimgio compile on Qt5

2013-01-19 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108495/ --- Review request for KDE Frameworks. Description --- The plugins are st

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread Jon Severinsson
> On Jan. 19, 2013, 2:15 p.m., Oswald Buddenhagen wrote: > > fwiw, we have a similar problem in kconfig (iirc). I think that problem is the opposite. From my reading of the code it seams to use qgetenv("HOME"), falling back on QDir::homePath(), which is implemented by qgetenv("HOME"), falling

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread Jon Severinsson
> On Jan. 19, 2013, 2:14 p.m., Oswald Buddenhagen wrote: > > kdecore/util/kuser_unix.cpp, line 67 > > > > > > i don't think it's actually useful to check the euid. HOME is supposed > > to match the real uid, and s

Re: Review Request 108487: Make kjsembed build on Qt5 rather than on Qt4

2013-01-19 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108487/ --- (Updated Jan. 19, 2013, 10:29 p.m.) Review request for KDE Frameworks. D

FindLibintl.cmake does not set LIBINTL_LIBRARIES correctly

2013-01-19 Thread Treeve Jelbert
# grep LIBINTL CMakeCache.txt LIBINTL_INCLUDE_DIR:PATH=/usr/include //ADVANCED property for variable: LIBINTL_INCLUDE_DIR LIBINTL_INCLUDE_DIR-ADVANCED:INTERNAL=1 //ADVANCED property for variable: LIBINTL_LIBC_HAS_DGETTEXT LIBINTL_LIBC_HAS_DGETTEXT-ADVANCED:INTERNAL=1 LIBINTL_LIBC_HAS_DGETTEXT:INTE

Re: Qt5 is required

2013-01-19 Thread David Faure
On Saturday 19 January 2013 15:07:50 Jon Severinsson wrote: > lördagen den 19 januari 2013 13:36:37 skrev David Faure: > > Dear KDE Frameworks hackers, > > > > It's time to drop the Qt4 compatibility, in order to use the new things > > from Qt 5 which we need to continue simplifying dependencies

Re: Qt5 is required

2013-01-19 Thread Stephen Kelly
David Faure wrote: > On Saturday 19 January 2013 19:07:39 Stephen Kelly wrote: >> David Faure wrote: >> > Stephen, you mentionned a script to get rid of the ifdefs for Qt4/Qt5, >> > do you have that at hand, or does it need to be written? >> >> It needed to be adapted from another script that I h

Re: Qt5 is required

2013-01-19 Thread David Faure
On Saturday 19 January 2013 14:59:54 Alexander Neundorf wrote: > On Saturday 19 January 2013, David Faure wrote: > > Dear KDE Frameworks hackers, > > > > It's time to drop the Qt4 compatibility, in order to use the new things > > from Qt 5 which we need to continue simplifying dependencies between

Re: Qt5 is required

2013-01-19 Thread David Faure
On Saturday 19 January 2013 19:07:39 Stephen Kelly wrote: > David Faure wrote: > > Stephen, you mentionned a script to get rid of the ifdefs for Qt4/Qt5, do > > you have that at hand, or does it need to be written? > > It needed to be adapted from another script that I have. Actually I needed > tw

Re: Qt5 is required

2013-01-19 Thread Stephen Kelly
David Faure wrote: > Stephen, you mentionned a script to get rid of the ifdefs for Qt4/Qt5, do > you have that at hand, or does it need to be written? It needed to be adapted from another script that I have. Actually I needed two scripts - one to handle #if < 5.0.0, and another for #if >= 5.0.0.

[kdelibs/frameworks] /: Bump required ecm version.

2013-01-19 Thread Stephen Kelly
Git commit 6013607009a9bb04860e4a743ad35f4dfae8860f by Stephen Kelly. Committed on 19/01/2013 at 17:21. Pushed by skelly into branch 'frameworks'. Bump required ecm version. The ecm version was bumped in November, but the frameworks requirement was not. An indication for me that that version-in-

Re: Plans and status Frameworks5, Plasma2, Qt5 and Wayland

2013-01-19 Thread Valentin Rusu
Hello Sebas, On Wednesday 16 January 2013 17:42:26 Sebastian Kügler wrote: > Hi all, > > I've compiled a document that contains our technical direction and its > status. This hopefully gives us a common understanding of where we're going > and where we are right now. > > Feedback is of course we

Re: Review Request 108487: Make kjsembed build on Qt5 rather than on Qt4

2013-01-19 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108487/#review25797 --- CMakeLists.txt

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25789 --- fwiw, we have a similar problem in kconfig (iirc). - Oswald Bu

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25788 --- kdecore/util/kuser_unix.cpp

Re: Qt5 is required

2013-01-19 Thread Jon Severinsson
lördagen den 19 januari 2013 13:36:37 skrev David Faure: > Dear KDE Frameworks hackers, > > It's time to drop the Qt4 compatibility, in order to use the new things > from Qt 5 which we need to continue simplifying dependencies between > frameworks. A follow up question: What should we do with kd

Re: Qt5 is required

2013-01-19 Thread Alexander Neundorf
On Saturday 19 January 2013, David Faure wrote: > Dear KDE Frameworks hackers, > > It's time to drop the Qt4 compatibility, in order to use the new things > from Qt 5 which we need to continue simplifying dependencies between > frameworks. > > Please compile Qt5 using the "dev" branch. Qt 5.0 is

Review Request 108487: Make kjsembed build on Qt5 rather than on Qt4

2013-01-19 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108487/ --- Review request for KDE Frameworks. Description --- As we are dropping

Re: Review Request 107696: kcalendarsystem: Simplify weekday naming a lot.

2013-01-19 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107696/ --- (Updated Jan. 19, 2013, 12:41 p.m.) Review request for KDE Frameworks, Dav

Qt5 is required

2013-01-19 Thread David Faure
Dear KDE Frameworks hackers, It's time to drop the Qt4 compatibility, in order to use the new things from Qt 5 which we need to continue simplifying dependencies between frameworks. Please compile Qt5 using the "dev" branch. Either qtbase + qtsvg + qtx11extras (at a minimum), if you don't have m

Re: Review Request 107688: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

2013-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107688/#review25783 --- This review has been submitted with commit 8de21f60dc2c90912fe

Re: Review Request 107687: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

2013-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107687/#review25782 --- This review has been submitted with commit 2a2ae1d676fc3f3e9b8

Re: Review Request 108263: kcalendarsystem: Merge KCalendarSystemQDate into KCalendarSystemGregorian.

2013-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108263/#review25784 --- This review has been submitted with commit f20cdc3fda7c77d79c6

Re: Review Request 107690: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

2013-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107690/#review25781 --- This review has been submitted with commit b6eb191012ed736a923

ktcpsockettest again

2013-01-19 Thread David Faure
Hi Andreas, Can you shed some light on the intent of this famous test? s->write(HTTPREQUEST); s->waitForReadyRead(); s->close(); //What happens is that during waitForReadyRead() the write buffer is written out //completely so that the socket can shut down without having to wa

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- (Updated Jan. 19, 2013, 10:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 108449: Adjust to Julian Day computation in Qt5's QDate

2013-01-19 Thread David Faure
On Friday 18 January 2013 11:34:13 Jon Severinsson wrote: > This is essentially a small subset of my review 108263. I see nothing wrong > with it, but I think it is unnecessary as we could just push my more > extensive patch directly instead. Yes, please push 108263 then, and let's declare Qt5 req