Re: Coding style: const QString foo = foo();

2024-10-29 Thread Sune Vuorela
On 2024-10-28, Albert Astals Cid wrote: > My vote goes for rename the variable, there's 2 reasons i can think why you > do > > const QString foo = foo(); > > (there's probably many more, i spent 5 seconds thinking) > > Reason 1: You're caching it because foo is expensive, rename the variable to

Re: Coding style: const QString foo = foo();

2024-10-29 Thread Ingo Klöcker
On Dienstag, 29. Oktober 2024 09:43:06 Mitteleuropäische Normalzeit Sune Vuorela wrote: > On 2024-10-28, Albert Astals Cid wrote: > > My vote goes for rename the variable, there's 2 reasons i can think why > > you do I second this. I dislike symbol shadowing more than I dislike having to find a

KDE Gear projects with failing CI (master) (29 October 2024)

2024-10-29 Thread Albert Astals Cid
Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Good news: 4 repositories were fixed Bad news: 7 repositories started failing, 1 is still failing mimetreeparser - 2nd week * https:

KDE Gear projects with failing CI (release/24.08) (29 October 2024)

2024-10-29 Thread Albert Astals Cid
Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Good news: 3 repositories have been fixed Bad news: 3 repositories have started failing and 3 are still failing kate - 2nd week * h

Re: KDE Gear projects with failing CI (master) (29 October 2024)

2024-10-29 Thread Mark Penner
On Tuesday, October 29, 2024 5:51:18 PM CDT Albert Astals Cid wrote: > kwave - NEW > * https://invent.kde.org/multimedia/kwave/-/pipelines/806639 > * cmake stage fails >* The cmake code in the doc folder looks like it could be simplified https://invent.kde.org/multimedia/kwave/-/merge_requ

Re: KDE Gear projects with failing CI (master) (29 October 2024)

2024-10-29 Thread Mark Penner
On Tuesday, October 29, 2024 5:51:18 PM CDT Albert Astals Cid wrote: > kwave - NEW > * https://invent.kde.org/multimedia/kwave/-/pipelines/806639 > * cmake stage fails >* The cmake code in the doc folder looks like it could be simplified https://invent.kde.org/multimedia/kwave/-/merge_reque

[ANNOUNCE] CMake 3.31.0-rc3 is ready for testing

2024-10-29 Thread John Parent
I am proud to announce the third CMake 3.31 release candidate. https://cmake.org/download/ Documentation is available at: https://cmake.org/cmake/help/v3.31 Release notes appear below and are also published at https://cmake.org/cmake/help/v3.31/release/3.31.html Release milestone is availa