Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-14 Thread David Edmundson
>Aren't the problems described in task https://phabricator.kde.org/T11214 specific enough? There's one comment about constructor initialisers, which seems resolvable. So if there's anything else, then yes, please be more specific. If we find we we can't do this until we get some more features in

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-14 Thread Alexey Min
> There's one comment about constructor initialisers, which seems resolvable. If that solvable, then it's great. I'm in favour of this idea, maybe even extend to frameworks repos? > So if there's anything else, then yes, please be more specific. No, so far that was the only problem we've found.

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-14 Thread Albert Astals Cid
El dijous, 11 de juliol de 2019, a les 16:18:08 CEST, David Edmundson va escriure: > One topic discussed at the recent Plasma sprint was that we should run > a code formatting tool (clang-format) over all our repos to ease all > future review comments about whitespace. > > All new contributions s