Review Request 124919: Re-organize D-Bus interfaces

2015-08-25 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 124843: Use json metadata in KDED module and fix plugin name

2015-08-25 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124843/#review84350 --- Ship it! Looks great! - Vishesh Handa On Aug. 20, 2015, 6:

Re: Review Request 124919: Re-organize D-Bus interfaces

2015-08-25 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/#review84352 --- Looks good. The only minor thing I realized is that I'm not su

Re: Review Request 124919: Re-organize D-Bus interfaces

2015-08-25 Thread Pinak Ahuja
> On Aug. 25, 2015, 4:54 p.m., Vishesh Handa wrote: > > Looks good. The only minor thing I realized is that I'm not sure how QtDbus > > behaves with interfaces which appear and disappear (contentIndexer). ContentIndexer doesn't appear and disappear now, it's a long lived class, with this patch

Re: Review Request 124919: Re-organize D-Bus interfaces

2015-08-25 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/ --- (Updated Aug. 25, 2015, 5:52 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 124919: Re-organize D-Bus interfaces

2015-08-25 Thread Pinak Ahuja
> On Aug. 25, 2015, 4:54 p.m., Vishesh Handa wrote: > > src/file/filecontentindexer.cpp, line 134 > > > > > > This might not be thread safe. > > > > It calls batchTimings which accesses `m_batchTimeBuffe

Re: Help wanted to evolve KDEs music players

2015-08-25 Thread Pinak Ahuja
So, what's up with this? Anyone working on something? I'm planning to start work on a simple player based on the VDG's design using https://github.com/vlc-qt/vlc-qt for audio playback. The player will not support any online accounts, will only be for local music playback. IMO if a user needs online

Re: Review Request 124843: Use json metadata in KDED module and fix plugin name

2015-08-25 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124843/ --- (Updated Aug. 25, 2015, 8:42 p.m.) Status -- This change has been ma