----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124843/#review84350 -----------------------------------------------------------
Ship it! Looks great! - Vishesh Handa On Aug. 20, 2015, 6:43 p.m., Ragnar Thomsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124843/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 6:43 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > This patch ports the kded-module of baloo to use json metadata and disables > installation of the desktop file. Additionally, the name of the plugin and > desktop file is changed to be similar to the class (baloosearchmodule), and > the two parameters in the desktop file (`X-KDE-Library` and > `X-KDE-DBus-ModuleName`) are also set to baloosearchmodule. The latter was > causing an issue with the kded kcm failing to load the baloo module. > > If the name baloosearchmodule is not descriptive enough we can change it. > However, the different components should have the same name to avoid problems > with kded. > > > Diffs > ----- > > src/kioslaves/kded/baloosearchmodule.desktop 9d84e2b > src/kioslaves/kded/CMakeLists.txt 41f1ef2 > src/kioslaves/kded/baloosearchmodule.cpp 93afa79 > > Diff: https://git.reviewboard.kde.org/r/124843/diff/ > > > Testing > ------- > > The baloo kded module now appears in the kded kcm, and can be > enabled/disabled. > > > Thanks, > > Ragnar Thomsen > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
