Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119415/ --- (Updated Juli 23, 2014, 8:36 vorm.) Review request for Baloo and Vishesh

Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119415/ --- (Updated Juli 23, 2014, 8:39 vorm.) Review request for Baloo and Vishesh

Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119415/#review62926 --- src/file/lib/autotests/filemodifyjobtest.cpp

Re: Review Request 118438: Add an option to only build baloo's libraries

2014-07-23 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/ --- (Updated Juli 23, 2014, 9:29 vorm.) Review request for Baloo. Changes -

Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Felix Eisele
> On Juli 23, 2014, 9:13 vorm., Vishesh Handa wrote: > > src/file/lib/autotests/filemodifyjobtest.cpp, line 78 > > > > > > Hi. You're on the right track, but this isn't the exact way to fix the > > test. > >

Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Vishesh Handa
> On July 23, 2014, 9:13 a.m., Vishesh Handa wrote: > > src/file/lib/autotests/filemodifyjobtest.cpp, line 78 > > > > > > Hi. You're on the right track, but this isn't the exact way to fix the > > test. > >

Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Felix Eisele
> On Juli 23, 2014, 9:13 vorm., Vishesh Handa wrote: > > src/file/lib/autotests/filemodifyjobtest.cpp, line 78 > > > > > > Hi. You're on the right track, but this isn't the exact way to fix the > > test. > >

Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119415/ --- (Updated Juli 23, 2014, 10:55 vorm.) Review request for Baloo and Vishesh

Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Felix Eisele
> On Juli 23, 2014, 9:13 vorm., Vishesh Handa wrote: > > src/file/lib/autotests/filemodifyjobtest.cpp, line 78 > > > > > > Hi. You're on the right track, but this isn't the exact way to fix the > > test. > >

Re: Review Request 119415: Patch to delete xattr from untagged file

2014-07-23 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119415/#review62946 --- Ship it! I'll commit the patch for you! Good job. - Vishesh

Review Request 119441: Akonadi-Indexer: Collection indexing

2014-07-23 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119441/ --- Review request for Baloo. Repository: baloo Description --- Akonad