----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119415/#review62926 -----------------------------------------------------------
src/file/lib/autotests/filemodifyjobtest.cpp <https://git.reviewboard.kde.org/r/119415/#comment43609> Hi. You're on the right track, but this isn't the exact way to fix the test. Lets take a look at what was happening before? * baloo_getxattr returns -1 if the value does not exist and a positive value indicating the length if it does exist. * Previously, the "user.xdg.tags" xatrr was always being set, even if it did not have any value. * What value should you be checking for now? - Vishesh Handa On July 23, 2014, 8:39 a.m., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119415/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 8:39 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Bugs: 333478 > http://bugs.kde.org/show_bug.cgi?id=333478 > > > Repository: baloo > > > Description > ------- > > Pacth to delete xattr from untagged file > > > Diffs > ----- > > src/file/lib/autotests/filemodifyjobtest.cpp ebfc9d9 > src/file/lib/baloo_xattr_p.h 87dc55f > src/file/lib/filecustommetadata.cpp 664b13f > > Diff: https://git.reviewboard.kde.org/r/119415/diff/ > > > Testing > ------- > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
