Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-12-05 Thread Christoph Feck
> On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: > do you want me to move this fro

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-12-04 Thread Laurent Navet
> On Aug. 12, 2014, 11:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: > do you want me to move this fr

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-09-19 Thread Dominik Haumann
> On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: > do you want me to move this fro

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-09-18 Thread Christoph Feck
> On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: > do you want me to move this fro

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-12 Thread Christoph Feck
> On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: > do you want me to move this fro

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-12 Thread Laurent Navet
> On août 12, 2014, 11:33 matin, Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. do you want me to move this from kdeexamples to kwidgetsaddo

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review64357 --- After some discussion with the SDK and Book groups in the spri

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-12 Thread Laurent Navet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/ --- (Updated Aug. 12, 2014, 9:33 a.m.) Review request for KDE Examples, KDE F

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-11 Thread Laurent Navet
> On août 5, 2014, 5:52 après-midi, Aleix Pol Gonzalez wrote: > > Is it meant to go to master? isn't it KDE4? IMHO, it should be a frameworks branch, but I let you and sune decide what to do with this patch - Laurent --- This is an aut

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review63870 --- Is it meant to go to master? isn't it KDE4? - Aleix Pol Gonza

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-05 Thread Laurent Navet
> On août 5, 2014, 8:20 matin, David Faure wrote: > > Looks good to me. I hope the commit log isn't the same as the reviewboard > > description though - it should be about what the patch does, instead. > > Laurent Navet wrote: > The commit log is : > --- > examples/k

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-05 Thread David Faure
> On Aug. 5, 2014, 6:20 a.m., David Faure wrote: > > Looks good to me. I hope the commit log isn't the same as the reviewboard > > description though - it should be about what the patch does, instead. > > Laurent Navet wrote: > The commit log is : > --- > examples/kd

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-05 Thread Laurent Navet
> On août 5, 2014, 8:20 matin, David Faure wrote: > > Looks good to me. I hope the commit log isn't the same as the reviewboard > > description though - it should be about what the patch does, instead. The commit log is : --- examples/kdeui/kmessagewidgetdemo : Port to KF5 Chan

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review63828 --- Ship it! Looks good to me. I hope the commit log isn't the sa

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-04 Thread Laurent Navet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/ --- (Updated Aug. 4, 2014, 10:51 p.m.) Review request for KDE Examples and Su

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-07-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review63469 --- bump! - Aleix Pol Gonzalez On Jan. 16, 2014, 7:30 p.m., Lau

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review54469 --- kdeui/kmessagewidgetdemo/window.cpp

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-02-04 Thread Laurent Navet
> On Jan. 15, 2014, 10:17 a.m., Sune Vuorela wrote: > > kdeui/kmessagewidgetdemo/CMakeLists.txt, line 23 > > > > > > Would it be hard to get rid of XmlGui here? I don't see what it really > > buy us for this exam

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-16 Thread Laurent Navet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/ --- (Updated Jan. 16, 2014, 8:30 p.m.) Review request for KDE Examples and Su

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-16 Thread Sune Vuorela
> On Jan. 15, 2014, 9:17 a.m., Sune Vuorela wrote: > > kdeui/kmessagewidgetdemo/CMakeLists.txt, line 23 > > > > > > Would it be hard to get rid of XmlGui here? I don't see what it really > > buy us for this examp

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-15 Thread Laurent Navet
> On Jan. 15, 2014, 10:17 a.m., Sune Vuorela wrote: > > kdeui/kmessagewidgetdemo/CMakeLists.txt, line 23 > > > > > > Would it be hard to get rid of XmlGui here? I don't see what it really > > buy us for this exam

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-15 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review47428 --- kdeui/kmessagewidgetdemo/CMakeLists.txt

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-10 Thread Laurent Navet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/ --- (Updated Jan. 10, 2014, 9:49 p.m.) Review request for KDE Examples and Su

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review47138 --- kdeui/kmessagewidgetdemo/window.cpp

Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-09 Thread Laurent Navet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/ --- Review request for KDE Examples and Sune Vuorela. Repository: kdeexamples