---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/#review61032
---
This review has been submitted with commit
a47292be3ca6fb9704
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/
---
(Updated June 26, 2014, 2:44 p.m.)
Status
--
This change has been ma
> On June 12, 2014, 6:05 p.m., Aleix Pol Gonzalez wrote:
> > Looks good to me, if there's anything you're doubting I'd suggest you to
> > take a look at another framework, such as KParts.
If you guys are ok with the patch, can you please push it?
I don't have commit access.
- Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/#review59899
---
Ship it!
Looks good to me, if there's anything you're doubtin
> On June 12, 2014, 5:25 p.m., Aleix Pol Gonzalez wrote:
> > In practice, every KF5KFileMetaData should be KF5FileMetaData
>
> Bernd Steinhauser wrote:
> What about the other uses of "KFileMetaData"?
>
> This definitely goes beyond changing the cmake files (to which I tried to
> st
> On June 12, 2014, 7:25 p.m., Aleix Pol Gonzalez wrote:
> > In practice, every KF5KFileMetaData should be KF5FileMetaData
>
> Bernd Steinhauser wrote:
> What about the other uses of "KFileMetaData"?
>
> This definitely goes beyond changing the cmake files (to which I tried to
> st
> On June 12, 2014, 5:25 p.m., Aleix Pol Gonzalez wrote:
> > In practice, every KF5KFileMetaData should be KF5FileMetaData
What about the other uses of "KFileMetaData"?
This definitely goes beyond changing the cmake files (to which I tried to stick
at this point).
What about the include direct
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/
---
(Updated June 12, 2014, 5:47 p.m.)
Review request for Baloo, Aleix Pol Go
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/#review59890
---
In practice, every KF5KFileMetaData should be KF5FileMetaData
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/
---
(Updated June 12, 2014, 2:30 p.m.)
Review request for Baloo, Aleix Pol Go
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/#review59884
---
Looks good to me otherwise. Let Aleix comment on this.
src/e
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118670/#review59853
---
Thanks for working on this. I've been missing being able to ru
12 matches
Mail list logo
