> On June 12, 2014, 6:05 p.m., Aleix Pol Gonzalez wrote: > > Looks good to me, if there's anything you're doubting I'd suggest you to > > take a look at another framework, such as KParts.
If you guys are ok with the patch, can you please push it? I don't have commit access. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/#review59899 ----------------------------------------------------------- On June 12, 2014, 5:47 p.m., Bernd Steinhauser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118670/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 5:47 p.m.) > > > Review request for Baloo, Aleix Pol Gonzalez and Vishesh Handa. > > > Repository: kfilemetadata > > > Description > ------- > > Submitting as an official review request, so progress can be properly tracked. > > As of now, libraries installed from the frameworks branch (based on KF5) > collide with the kdelibs4 based libraries from master. > Modifying the cmake files allows for parallel installation without too much > effort while maintaining the capability to use either mater's or framework's > version by finding the appropriate cmake file, thus making life much easier > for distributions. > > Now one option would be to invent some different name to prevent the > collisions, but instead we chose a different way: > kfilemetadata, just as baloo's libraries, will be a framework at some future > point. Then it is likely to use the same notation anyway. So why changing > names several times without any real advantages? > Therefore the patch changes kfilemetadata's framework branch to match KF5 > terminology. > > The patch was rebased on current framework's head. Additionally, Heiko and I > decided to squash our patches as they are trying to achieve the same goal. > > > Diffs > ----- > > CMakeLists.txt 5a9eefa > KFileMetaDataConfig.cmake.in b4d1c93 > autotests/CMakeLists.txt c657a70 > src/CMakeLists.txt 82dbd5c > src/extractors/CMakeLists.txt 0099c08 > > Diff: https://git.reviewboard.kde.org/r/118670/diff/ > > > Testing > ------- > > > Thanks, > > Bernd Steinhauser > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
