Re: Review Request 118231: Scheduler for the akonadi indexer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/ --- (Updated July 13, 2014, 3:22 p.m.) Status -- This change has been ma

Re: Review Request 118231: Scheduler for the akonadi indexer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review61574 --- I still haven't had time to look into the latest code, but tha

Re: Review Request 118231: Scheduler for the akonadi indexer.

> On June 13, 2014, 10:17 a.m., Thomas Braxton wrote: > > src/pim/agent/agent.h, line 80 > > > > > > Couldn't they just not be pointers? Then you don't have to worry about > > deleting them. hmmm... can't rememb

Re: Review Request 118231: Scheduler for the akonadi indexer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review59957 --- src/pim/agent/agent.h

Re: Review Request 118231: Scheduler for the akonadi indexer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review59951 --- some small nitpicks from my side - no clue about the actual fu

Re: Review Request 118231: Scheduler for the akonadi indexer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review59935 --- ping? Are there still things that need to be addressed? - Chr

Re: Review Request 118231: Scheduler for the akonadi indexer.

> On May 22, 2014, 4 p.m., Vishesh Handa wrote: > > src/pim/agent/scheduler.cpp, line 97 > > > > > > So each time an item is added, you pass the parent collection to the > > CollectionIndexingJob and there you fe

Re: Review Request 118231: Scheduler for the akonadi indexer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/ --- (Updated June 3, 2014, 11:18 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 118231: Scheduler for the akonadi indexer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/ --- (Updated June 2, 2014, 10:13 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 118231: Scheduler for the akonadi indexer.

> On May 22, 2014, 4 p.m., Vishesh Handa wrote: > > src/pim/agent/collectionindexingjob.h, line 66 > > > > > > Whoa. This variable name is very very confusing. It's true, if there > > are indexed items which are

Re: Review Request 118231: Scheduler for the akonadi indexer.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review58317 --- Overall, the code is getting quite complex, and it's at a stat