----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review59951 -----------------------------------------------------------
some small nitpicks from my side - no clue about the actual functionality src/pim/agent/agent.h <https://git.reviewboard.kde.org/r/118231/#comment41731> if these are owned (you manually delete them), use QScopedPointer src/pim/agent/collectionindexingjob.cpp <https://git.reviewboard.kde.org/r/118231/#comment41732> spaces around operators please src/pim/agent/index.h <https://git.reviewboard.kde.org/r/118231/#comment41736> qhash? src/pim/agent/index.cpp <https://git.reviewboard.kde.org/r/118231/#comment41733> indent src/pim/agent/scheduler.h <https://git.reviewboard.kde.org/r/118231/#comment41734> break overly long line src/pim/agent/scheduler.h <https://git.reviewboard.kde.org/r/118231/#comment41735> is this supposed to be sorted? if not, maybe use a hash? src/pim/agent/scheduler.h <https://git.reviewboard.kde.org/r/118231/#comment41737> qhash? - Milian Wolff On June 3, 2014, 11:18 p.m., Christian Mollekopf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118231/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 11:18 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > A scheduler for baloo: > * delays the indexing until no new item has been added for at least 5 seconds > to avoid indexing during a collection sync. > * remembers if it failed to index something and triggers recovery path on > next start. > * supports manual triggering of recovery path if required. > > > Diffs > ----- > > src/file/fileexcludefilters.cpp e1f2ed7f64353d098327e5eff44a5e5a17a48da2 > src/pim/agent/CMakeLists.txt e917915a3414738595caea5497859ef4810ec44c > src/pim/agent/agent.h 1dbf0fc0a16d0615dbfa4878706359bb687facd0 > src/pim/agent/agent.cpp 8904d49d3579b58b634d2570fbcc8007e5ee41ed > src/pim/agent/autotests/CMakeLists.txt > 5ee987aad0d09c28da868ac8cd1c308f673bb7bf > src/pim/agent/autotests/collectionindexingjobtest.cpp PRE-CREATION > src/pim/agent/autotests/schedulertest.cpp PRE-CREATION > src/pim/agent/autotests/unittestenv/config-mysql-db.xml PRE-CREATION > src/pim/agent/autotests/unittestenv/config-sqlite-db.xml PRE-CREATION > src/pim/agent/autotests/unittestenv/kdehome/share/config/akonadi-firstrunrc > PRE-CREATION > > src/pim/agent/autotests/unittestenv/kdehome/share/config/akonadi_knut_resource_0rc > PRE-CREATION > src/pim/agent/autotests/unittestenv/kdehome/share/config/kdebugrc > PRE-CREATION > src/pim/agent/autotests/unittestenv/kdehome/share/config/kdedrc > PRE-CREATION > src/pim/agent/autotests/unittestenv/kdehome/testdata-res1.xml PRE-CREATION > src/pim/agent/autotests/unittestenv/xdgconfig/akonadi/akonadiserverrc > PRE-CREATION > src/pim/agent/collectionindexingjob.h PRE-CREATION > src/pim/agent/collectionindexingjob.cpp PRE-CREATION > src/pim/agent/index.h PRE-CREATION > src/pim/agent/index.cpp PRE-CREATION > src/pim/agent/scheduler.h PRE-CREATION > src/pim/agent/scheduler.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118231/diff/ > > > Testing > ------- > > I'm running it for a while, and it reduced the stress that baloo imposed on > my system and all my mails are indexed since I'm using it (wasn't the case > before). > > > Thanks, > > Christian Mollekopf > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
