Jenkins-kde-ci: kdelibs KDE-4.14 latest-qt4 » Linux,gcc - Build # 55 - Still Unstable!

2016-01-23 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20latest-qt4/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 23 Jan 2016 07:23:05 + Build duration: 32 min CHANGE SET Revision 52d0a81376e95e7d800f79faca363bdbeabcdfc

Re: Review Request 126249: Fix apidoc format

2016-01-23 Thread Frederik Schwarzer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126249/#review91464 --- Ping? - Frederik Schwarzer On Dec. 5, 2015, 8:38 a.m., Fre

Re: Review Request 126249: Fix apidoc format

2016-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126249/#review91465 --- Ship it! Ship It! - David Faure On Jan. 23, 2016, 10:25

Re: Review Request 120127: Don't show overwrite dialog if file name is empty

2016-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120127/#review91466 --- Ship it! Ship It! - David Faure On Sept. 12, 2014, 8:09

Re: Review Request 126249: Fix apidoc format

2016-01-23 Thread Frederik Schwarzer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126249/ --- (Updated Jan. 23, 2016, 11:20 a.m.) Status -- This change has been m

Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/ --- Review request for kde-workspace and Plasma. Repository: plasma-workspace

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/#review91476 --- id isn't particularly better either as that's also a reserved

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
> On Jan. 23, 2016, 2:22 p.m., Kai Uwe Broulik wrote: > > id isn't particularly better either as that's also a reserved QML keyword. > > > > Also, you can access any role with a name clash by accessing it through > > "model", ie. model.index id is the first thing that came to mind, of cause it

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Kai Uwe Broulik
> On Jan. 23, 2016, 1:22 nachm., Kai Uwe Broulik wrote: > > id isn't particularly better either as that's also a reserved QML keyword. > > > > Also, you can access any role with a name clash by accessing it through > > "model", ie. model.index > > Daniel Faust wrote: > id is the first thin

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/ --- (Updated Jan. 23, 2016, 3 p.m.) Review request for kde-workspace and Plas

Jenkins-kde-ci: kdelibs KDE-4.14 stable-qt4 » Linux,gcc - Build # 53 - Still Unstable!

2016-01-23 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20stable-qt4/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 23 Jan 2016 12:58:43 + Build duration: 17 min CHANGE SET Revision 32dc425f4ca616fef7a5f193bf79d38f0465f8b

Jenkins-kde-ci: kdelibs KDE-4.14 latest-qt4 » Linux,gcc - Build # 56 - Still Unstable!

2016-01-23 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20latest-qt4/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 23 Jan 2016 12:58:43 + Build duration: 35 min CHANGE SET Revision 32dc425f4ca616fef7a5f193bf79d38f0465f8b

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas the "Kill specific > > window"

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review91486 --- > If someone has changed the shortcut, they should know what

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Thomas Pfeiffer
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Ken Vermette
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Thomas Lübking
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Thomas Pfeiffer
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Ken Vermette
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th