----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/ -----------------------------------------------------------
Review request for kde-workspace and Plasma. Repository: plasma-workspace Description ------- I wrote a qml applet using the places data engine and noticed that I can't access the index variable of ListView items because it gets overwritten by the places model. This patch renames the "index" role name to "id" in order to avoid this naming conflict. Diffs ----- dataengines/places/org.kde.places.operations 98a951d dataengines/places/placeservice.cpp e0c93c5 dataengines/places/placesproxymodel.h 467fe83 dataengines/places/placesproxymodel.cpp 5ea807b Diff: https://git.reviewboard.kde.org/r/126851/diff/ Testing ------- I couldn't find any other model that is using the places data engine so I hope renaming the model role is fine. The provided model still works and I tested the "Setup Device" and "Teardown Device" operations of the service. The operations "Show" and "Hide" don't seem to work anyway and the others were not tested. Thanks, Daniel Faust
