https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #25 from Nick Nethercote ---
(In reply to Nick Nethercote from comment #23)
> FYI: several people are experiencing this when running Valgrind on code
> compiled with the current nightly Rust compiler.
Unfortunately, this is still hap
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #35 from Nick Nethercote ---
With the additional commits things are working again for Rust code, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #46 from Nick Nethercote ---
> Could you test again with top of tree and see whether --read-var-info=yes
> also works OK?
My normal workflow works well. It uses Cachegrind and DHAT, which don't need
`--read-var-info=yes`.
I
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #47 from Nick Nethercote ---
My test Rust program was this, in `a.rs`:
> fn main() {
> println!("hello world");
> }
And I compiled with `rustc +nightly a.rs` to produce the executable `a`.
--
You are receiving thi
https://bugs.kde.org/show_bug.cgi?id=467472
Bug ID: 467472
Summary: Rewrite `cg_annotate` in Python
Classification: Developer tools
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: REPORT
https://bugs.kde.org/show_bug.cgi?id=467472
--- Comment #1 from Nick Nethercote ---
Created attachment 157348
--> https://bugs.kde.org/attachment.cgi?id=157348&action=edit
Patch
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=467472
--- Comment #2 from Nick Nethercote ---
Created attachment 157349
--> https://bugs.kde.org/attachment.cgi?id=157349&action=edit
Patch minus cg_annotate.in changes (easier to read)
--
You are receiving this mail because:
You are watching
https://bugs.kde.org/show_bug.cgi?id=467472
--- Comment #3 from Nick Nethercote ---
Created attachment 157350
--> https://bugs.kde.org/attachment.cgi?id=157350&action=edit
New cg_annotate.in file
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=467472
Nick Nethercote changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=469146
--- Comment #17 from Nick Nethercote ---
It has been a long time since I looked at this code. I don't have much to add
other than the changes seem plausible
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=445668
Bug ID: 445668
Summary: Inline stack frame generation is broken for Rust
binaries
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Stat
https://bugs.kde.org/show_bug.cgi?id=445668
Nick Nethercote changed:
What|Removed |Added
CC||m...@klomp.org
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=445668
--- Comment #2 from Nick Nethercote ---
> (*) BTW. What is this? It looks like a mangled Rust v0 symbol, but it isn't
> because it (I also checked with c++filt) cannot be demangled.
The Rust compiler currently sometimes generates sym
https://bugs.kde.org/show_bug.cgi?id=445668
--- Comment #3 from Nick Nethercote ---
Created attachment 143713
--> https://bugs.kde.org/attachment.cgi?id=143713&action=edit
Rust reproducer
I've written a tiny program that reproduces the problem.
- I compiled with Rust 1.56.1 wi
https://bugs.kde.org/show_bug.cgi?id=445668
--- Comment #4 from Nick Nethercote ---
Created attachment 143715
--> https://bugs.kde.org/attachment.cgi?id=143715&action=edit
Compiled file
Here's the binary produced by Rust 1.56.1 for `rustc -g a.rs` on my x86-64
Linux box.
https://bugs.kde.org/show_bug.cgi?id=445668
--- Comment #7 from Nick Nethercote ---
The one-line fix works on the big example! Thank you.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=445668
--- Comment #8 from Nick Nethercote ---
> The Rust compiler currently sometimes generates symbols with a
> `.llvm.` suffix. These violate the v0 spec, which doesn't allow '.'
> chars, and the libiberty/Valgrind demangler doesn
https://bugs.kde.org/show_bug.cgi?id=445916
Nick Nethercote changed:
What|Removed |Added
CC||n.netherc...@gmail.com
--- Comment #1 from
https://bugs.kde.org/show_bug.cgi?id=445916
--- Comment #2 from Nick Nethercote ---
https://github.com/rust-lang/rust/issues/60705#issuecomment-976064467 suggests
that we should only cut off what comes after '.', *not* '$'.
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=452758
Nick Nethercote changed:
What|Removed |Added
CC||n.netherc...@gmail.com
--- Comment #23 from
https://bugs.kde.org/show_bug.cgi?id=452058
--- Comment #4 from Nick Nethercote ---
> Does this depend on the rustc version used?
I tried a few versions: 1.57.0, 1.60.0, nightly 1.62, they all behaved the same
on my Ubuntu 21.10 box.
It looks to me like you're not getting any inline f
https://bugs.kde.org/show_bug.cgi?id=452058
Bug ID: 452058
Summary: Generated suppressions contain a mix of mangled
(physical) and demangled (inline) frames
Product: valgrind
Version: unspecified
Platform: Other
https://bugs.kde.org/show_bug.cgi?id=445184
Bug ID: 445184
Summary: Rust v0 symbol demangling is broken
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
https://bugs.kde.org/show_bug.cgi?id=445184
--- Comment #1 from Nick Nethercote ---
I have push permission for the repository, so once people are happy with this
(assuming they are) I can push it myself. Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=445184
--- Comment #3 from Nick Nethercote ---
> What about the Java Ada/gnat and D demangling defined in ML_(cplus_demangle)?
> We seem to miss demangling them too because they (probably) don't start with
> _Z or _R and aren't guarded
https://bugs.kde.org/show_bug.cgi?id=445235
Bug ID: 445235
Summary: Java/Ada/D demangling is probably broken
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: norm
https://bugs.kde.org/show_bug.cgi?id=445184
Nick Nethercote changed:
What|Removed |Added
Blocks||445235
Referenced Bugs:
https
https://bugs.kde.org/show_bug.cgi?id=445184
--- Comment #4 from Nick Nethercote ---
I filed #445235 for Java/Ada/D.
Pushed as:
commit 4831385c6706b377851284adc4c4545fff4c6564 (HEAD -> master, origin/master,
origin/HEAD)
Author: Nicholas Nethercote
Date: Tue Nov 9 12:30:07 2021 +1
https://bugs.kde.org/show_bug.cgi?id=445235
Bug 445235 depends on bug 445184, which changed state.
Bug 445184 Summary: Rust v0 symbol demangling is broken
https://bugs.kde.org/show_bug.cgi?id=445184
What|Removed |Added
---
https://bugs.kde.org/show_bug.cgi?id=445184
Nick Nethercote changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=465465
--- Comment #15 from Nick Nethercote ---
The existing cache and branch simulations are very simplistic, and about 20
years out of date. I think hardware counters are a much better way of getting
cache statistics. I recently made `--cache-sim=no` the
https://bugs.kde.org/show_bug.cgi?id=399301
--- Comment #2 from Nick Nethercote ---
Any reason not to land this? I think it's ready. It's a simple change and a
clear improvement.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=406352
Nick Nethercote changed:
What|Removed |Added
CC||n.netherc...@gmail.com
--- Comment #1 from
https://bugs.kde.org/show_bug.cgi?id=406578
--- Comment #1 from Nick Nethercote ---
Valgrind 3.15 just came out and it completely overhauled DHAT. The new version
is much better.
The output is now in a tree. The root node of the tree covers the entire
program, and looks like this:
> AP 1/1
https://bugs.kde.org/show_bug.cgi?id=409678
--- Comment #5 from Nick Nethercote ---
FWIW, you can run some tests of DHAT's viewer by loading dhat with `?test=1`
appended to the URL.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=399355
--- Comment #13 from Nick Nethercote ---
I haven't looked into the problems reported in comment 6. I don't see why this
shouldn't be able to work, but the Callgrind format does have a lot of bells
and whistles that the Cachegrind form
https://bugs.kde.org/show_bug.cgi?id=402369
--- Comment #10 from Nick Nethercote ---
> I think the order of the Sort Metrics in the documentation should match that
> in dh_view.html.
I just double-checked; as far as I can tell it does match. Which ones do you
think are out of order?
>
https://bugs.kde.org/show_bug.cgi?id=402369
Nick Nethercote changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=402369
Bug ID: 402369
Summary: Overhaul DHAT
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
https://bugs.kde.org/show_bug.cgi?id=402369
--- Comment #1 from Nick Nethercote ---
Created attachment 117022
--> https://bugs.kde.org/attachment.cgi?id=117022&action=edit
Sample output file
Here is output from a run of the Rust compiler under DHAT.
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=402369
--- Comment #2 from Nick Nethercote ---
If you want to try it out easily:
- save the attached file
- visit http://njn.valgrind.org/dh_view.html and load the saved file.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=402369
Nick Nethercote changed:
What|Removed |Added
Attachment #117020|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=402369
--- Comment #5 from Nick Nethercote ---
> It might be interesting to replace the wordFM by an xtree,
It may. Nonetheless, I'd rather land the code as-is, because it's a major
improvement over the existing DHAT. We can consider optimiz
https://bugs.kde.org/show_bug.cgi?id=399301
Bug ID: 399301
Summary: Use inlined frames in Massif XTree output.
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: no
https://bugs.kde.org/show_bug.cgi?id=399301
Nick Nethercote changed:
What|Removed |Added
Blocks||399322
Referenced Bugs:
https
https://bugs.kde.org/show_bug.cgi?id=399322
Bug ID: 399322
Summary: Improve callgrind_annotate output
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
https://bugs.kde.org/show_bug.cgi?id=399355
Bug ID: 399355
Summary: Add callgrind_diff
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority:
https://bugs.kde.org/show_bug.cgi?id=399301
Nick Nethercote changed:
What|Removed |Added
Blocks||399355
Referenced Bugs:
https
https://bugs.kde.org/show_bug.cgi?id=399322
Nick Nethercote changed:
What|Removed |Added
Blocks||399355
Referenced Bugs:
https
https://bugs.kde.org/show_bug.cgi?id=399355
--- Comment #2 from Nick Nethercote ---
Is it really worth splitting the patch? I guess you could put the threshold
changes in one patch and everything else in another, but it doesn't seem worth
the effort.
I did the original threshold chang
https://bugs.kde.org/show_bug.cgi?id=399355
--- Comment #4 from Nick Nethercote ---
Thank you for the feedback. I will look at the failures next week.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=399301
Nick Nethercote changed:
What|Removed |Added
Blocks|399322 |
Referenced Bugs:
https://bugs.kde.org
https://bugs.kde.org/show_bug.cgi?id=399355
Bug 399355 depends on bug 399322, which changed state.
Bug 399322 Summary: Improve callgrind_annotate output
https://bugs.kde.org/show_bug.cgi?id=399322
What|Removed |Added
-
https://bugs.kde.org/show_bug.cgi?id=399322
Nick Nethercote changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=399355
Nick Nethercote changed:
What|Removed |Added
Depends on|399322 |
Referenced Bugs:
https://bugs.kde.org
https://bugs.kde.org/show_bug.cgi?id=399322
Nick Nethercote changed:
What|Removed |Added
Blocks|399355 |
Referenced Bugs:
https://bugs.kde.org
https://bugs.kde.org/show_bug.cgi?id=399355
Nick Nethercote changed:
What|Removed |Added
Attachment #115396|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=401454
Bug ID: 401454
Summary: Add a --show-percs option to cg_annotate and
callgrind_annotate.
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=401454
--- Comment #1 from Nick Nethercote ---
I don't think this will be a controversial change, given that it doesn't change
default behaviours. I will land it early next week if there are no objections
in the meantime.
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=401454
--- Comment #2 from Nick Nethercote ---
Landed as
https://sourceware.org/git/?p=valgrind.git;a=commit;h=e6e837752183dd2c0ef00bf687b9fe759bd6553c
--
You are receiving this mail because:
You are watching all bug changes.
60 matches
Mail list logo
