Hi,
I had a look into the code and tested it : works fine!
Thanks you Landon
Michaël
Stefan Steiniger a écrit :
>> Do you want me to make these changes to my patch and then commit again?
>>
>
> no its fine
> stefan
>
>
>> SS
>>
>>
>> On Fri, Mar 13, 2009 at 9:27 AM, Stefan Steiniger wr
>
> Do you want me to make these changes to my patch and then commit again?
no its fine
stefan
> SS
>
>
> On Fri, Mar 13, 2009 at 9:27 AM, Stefan Steiniger wrote:
>> I checked your code visually.. looks good
>>
>> But I have two comments:
>>
>> 1) you replaced
>> -if (createLayer) {
>> by
Stefan,
I apologize about the bracket change. That is an almost unconcious
habbit of mine, and wasn't done intentionally.
I ususally only initialize my member variables in a constructor. I
also initialize local variables within a method. However, if I don't
see a problem with initializing the boo
I checked your code visually.. looks good
But I have two comments:
1) you replaced
-if (createLayer) {
by
+if (createLayer)
+{
however, we should avoid this bracket style and use the previous one
(also used by Jon, Martin, Michael and myself)
2) I wonder if it makes sense to always
Stefan wrote: "On the LinearRing thing.. that is solved (I did fix it
on the weekend -
and closed the bug report)."
Sweet.
I'll get the commit in right now.
SS
On Thu, Mar 12, 2009 at 2:51 PM, Stefan Steiniger wrote:
> Hei Landon,
>
> thank you and pls. commit. If there is a problem I/we will
Hei Landon,
thank you and pls. commit. If there is a problem I/we will find it after
the commit.
On the LinearRing thing.. that is solved (I did fix it on the weekend -
and closed the bug report).
stefan
Sunburned Surveyor wrote:
> I have fixed the spatial query bug. If the user chooses not to
I have fixed the spatial query bug. If the user chooses not to create
a new layer for the features selected as a result of the query, a
"normal" JUMP selection is created in the source layer. This allows
the user to delete the selected features IF THE LAYER IS EDITABLE. In
this scenario the feature