Stefan,
I apologize about the bracket change. That is an almost unconcious
habbit of mine, and wasn't done intentionally.
I ususally only initialize my member variables in a constructor. I
also initialize local variables within a method. However, if I don't
see a problem with initializing the boolean flag outside of the
constructor.
Do you want me to make these changes to my patch and then commit again?
SS
On Fri, Mar 13, 2009 at 9:27 AM, Stefan Steiniger <sst...@geo.uzh.ch> wrote:
> I checked your code visually.. looks good
>
> But I have two comments:
>
> 1) you replaced
> - if (createLayer) {
> by
> + if (createLayer)
> + {
>
> however, we should avoid this bracket style and use the previous one
> (also used by Jon, Martin, Michael and myself)
>
> 2) I wonder if it makes sense to always add a default value when
> declaring the variable (i.e. boolean createNewLayer=false)
>
> thanx for the fix
>
> stefan
>
> Sunburned Surveyor wrote:
>> Stefan wrote: "On the LinearRing thing.. that is solved (I did fix it
>> on the weekend -
>> and closed the bug report)."
>>
>> Sweet.
>>
>> I'll get the commit in right now.
>>
>> SS
>>
>> On Thu, Mar 12, 2009 at 2:51 PM, Stefan Steiniger <sst...@geo.uzh.ch> wrote:
>>> Hei Landon,
>>>
>>> thank you and pls. commit. If there is a problem I/we will find it after
>>> the commit.
>>> On the LinearRing thing.. that is solved (I did fix it on the weekend -
>>> and closed the bug report).
>>>
>>> stefan
>>>
>>> Sunburned Surveyor wrote:
>>>> I have fixed the spatial query bug. If the user chooses not to create
>>>> a new layer for the features selected as a result of the query, a
>>>> "normal" JUMP selection is created in the source layer. This allows
>>>> the user to delete the selected features IF THE LAYER IS EDITABLE. In
>>>> this scenario the features are simply selected through the
>>>> SelectionManager, and not cloned prior to selection.
>>>>
>>>> I did not need to modify the constructor of the SpatialQueryExecutor
>>>> class to accomplish this change.
>>>>
>>>> I build OJ from SVN with my changes and everything works fine. I also
>>>> removed one "illegal" character in a comment of the ShapefileWriter
>>>> class that was causing a compile error.
>>>>
>>>> Does anyone want to look at my code before I commit?
>>>>
>>>> The Sunburned Surveyor
>>>>
>>>> P.S. - If no one has looked at the JML ring bug, I will do so tomorrow.
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
>>>> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
>>>> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
>>>> software that enables intelligent coding and step-through debugging.
>>>> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
>>>> _______________________________________________
>>>> Jump-pilot-devel mailing list
>>>> Jump-pilot-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>>
>>>>
>>> ------------------------------------------------------------------------------
>>> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
>>> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
>>> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
>>> software that enables intelligent coding and step-through debugging.
>>> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
>>> _______________________________________________
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>
>>
>> ------------------------------------------------------------------------------
>> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
>> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
>> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
>> software that enables intelligent coding and step-through debugging.
>> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
>> _______________________________________________
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>>
>
> ------------------------------------------------------------------------------
> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
> software that enables intelligent coding and step-through debugging.
> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
