Re: [JPP-Devel] Cleaning, formatting rewriting

2016-04-01 Thread Stefan Steiniger
w someone made advertisement for OJ? keep up the good work! On 4/1/16 04:25, Michaël Michaud wrote: Hi, Thanks, I'm not sure it worthwhile, but I prefer to take the following graphic as an encouragement. These figures are probably much distorted by automatic downloads, but it is the

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-04-01 Thread Michaël Michaud
Hi, Thanks, I'm not sure it worthwhile, but I prefer to take the following graphic as an encouragement. These figures are probably much distorted by automatic downloads, but it is the first time we exceeded 4000 downloads a month, and the same month, we nearly reached 5000 (stable release onl

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-31 Thread Giuseppe Aruta
Yes! Landon is right! Thanks Michael for your job. 2016-03-30 23:00 GMT+02:00 Landon Blake : > Thanks for your work cleaning the code Michael. I appreciate it. > > Landon > > On Sun, Mar 27, 2016 at 7:28 AM, Edgar Soldin wrote: > >> On 24.03.2016 13:55, Michaël Michaud wrote: >> > Thanks, >> > I

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-30 Thread Landon Blake
Thanks for your work cleaning the code Michael. I appreciate it. Landon On Sun, Mar 27, 2016 at 7:28 AM, Edgar Soldin wrote: > On 24.03.2016 13:55, Michaël Michaud wrote: > > Thanks, > > I also can undertake some changes with more confidence because I know I > > can get excellent support on thi

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-27 Thread Edgar Soldin
On 24.03.2016 13:55, Michaël Michaud wrote: > Thanks, > I also can undertake some changes with more confidence because I know I > can get excellent support on this list either in GIS area or in java > programming area ;-) noted :).. happy bunny days.. ede -

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-24 Thread Michaël Michaud
Hi, >> Hi, >> >> I was not frightened at all, > maybe you should be ;) Yes of course I can introduce new bugs. The risk is quite low with the kind of changes I've done since 1.9.1, but I don't exclude to do deeper changes. Hopefully, we have a good and stable 1.9.1 release, and it seems a good

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-24 Thread edgar . soldin
On 24.03.2016 11:38, Rahkonen Jukka (MML) wrote: > Hi, > > I was not frightened at all, maybe you should be ;) >just curious and also glad. Cleaning old code that is not really broken is >something that usually remains undone. "never touch a running system" >Another example is developer "g

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-24 Thread Rahkonen Jukka (MML)
Hi, I was not frightened at all, just curious and also glad. Cleaning old code that is not really broken is something that usually remains undone. Another example is developer "goatbar" who has been cleaning the codebase of GDAL with his +1400 changesets https://trac.osgeo.org/gdal/search?q=go

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-24 Thread edgar . soldin
as far as i have seen the changes were more of a formatting natures so far. but, Jukka is right of course, touching existing working code is prone to introduce errors. that being said, i trust you'll be extra careful and try not to introduce new code if not absolutely needed. ..ede rOn 24.03.

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-23 Thread Michaël Michaud
Hi Jukka, Some benefits are : - making the code more readable (with for each loop, generics, autoboxing : formatting and using simpler syntax help to understand the code more quickly) - making the code more safe (using generics, try with resource) - most of things I rewrite are suggestions fro

[JPP-Devel] Cleaning, formatting rewriting

2016-03-23 Thread Rahkonen Jukka (MML)
Hi, Michaël seems to do much work with "Cleaning, formatting rewriting". As a non-programmer I would like to know what and why, and what benefit OpenJUMP will have from this code review. Regards, -Jukka Rahkonen- -- Tr