On 24.03.2016 11:38, Rahkonen Jukka (MML) wrote: > Hi, > > I was not frightened at all,
maybe you should be ;) >just curious and also glad. Cleaning old code that is not really broken is >something that usually remains undone. "never touch a running system" >Another example is developer "goatbar" who has been cleaning the codebase of >GDAL with his +1400 changesets > https://trac.osgeo.org/gdal/search?q=goatbar&noquickjump=1&changeset=on not saying it shouldn't be done. just has to be done carefully and while functionality does not increase it inherently has the danger of breaking things. > I have also seen in the Geoserver project how much work it can require if > there is a need to migrate over very many library versions like with Wicket > 1.4 from 2009 -> Wicket 7.x > https://wiki.osgeo.org/wiki/GeoServer_Code_Sprint_2016. Upgrading to Spring-4 > is also a big task even it is not so much delayed > https://github.com/geoserver/geoserver/wiki/Spring-4-Upgrade. yeah, but at least upgrading dependencies usually gives you more stable, better libs you work w/ in the future. anyway.. i have full confidence in the french/czech teamup Mike&IntelliJ ..ede > > -Jukka Rahkonen- > > edgar.soldin wrote: > >> as far as i have seen the changes were more of a formatting natures so far. >> but, Jukka is right of course, touching existing working code is prone to >> introduce errors. > >> that being said, i trust you'll be extra careful and try not to introduce >> new code if not absolutely needed. > > ..ede > > rOn 24.03.2016 00:01, Michaël Michaud wrote: >> Hi Jukka, >> >> Some benefits are : >> - making the code more readable (with for each loop, generics, >> autoboxing : formatting and using simpler syntax help to understand >> the code more quickly) >> - making the code more safe (using generics, try with resource) >> - most of things I rewrite are suggestions from my IDE (it may detect actual >> bugs, but more often >> "potential" bug or simply bad practises ) >> - removing dead code (useless bytes to load) or duplicated code (error >> prone) >> - for me, it is also a good way to have a better knowledge of the codebase. >> ... >> >> Benefit is not very high for the short term (it is not supposed to change >> the way OJ works). >> But I hope it will make the code more attractive. I think it may also >> be a first step for bigger refactoring task if needed. >> >> Michaël >> >> Le 23/03/2016 22:49, Rahkonen Jukka (MML) a écrit : >>> >>> Hi, >>> >>> >>> >>> Michaël seems to do much work with "Cleaning, formatting rewriting". As a >>> non-programmer I would like to know what and why, and what benefit OpenJUMP >>> will have from this code review. >>> >>> >>> >>> Regards, >>> >>> >>> >>> -Jukka Rahkonen- >>> >>> >>> >>> --------------------------------------------------------------------- >>> --------- >>> Transform Data into Opportunity. >>> Accelerate data analysis in your applications with Intel Data >>> Analytics Acceleration Library. >>> Click to learn more. >>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 >>> >>> >>> _______________________________________________ >>> Jump-pilot-devel mailing list >>> Jump-pilot-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> >> >> >> ---------------------------------------------------------------------- >> -------- >> Transform Data into Opportunity. >> Accelerate data analysis in your applications with Intel Data >> Analytics Acceleration Library. >> Click to learn more. >> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 >> >> >> >> _______________________________________________ >> Jump-pilot-devel mailing list >> Jump-pilot-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with Intel Data Analytics > Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
