Re: Future of the Charm Review Queue

2017-08-07 Thread Sandor Zeestraten
that >> a much more lightweight process is the way forward. >> >> The biggest change is actually the sunsetting of the charm review queue. >> The reality is the process as it stands cannot keep up with the demand for >> reviews. We’ve decided to take a community curation ap

Re: Future of the Charm Review Queue

2017-08-07 Thread Tim Van Steenburgh
ore. We’ve taken a look >> at what’s happened in the past and where we want to get to and decided that >> a much more lightweight process is the way forward. >> >> The biggest change is actually the sunsetting of the charm review queue. >> The reality is the process as

Re: Future of the Charm Review Queue

2017-08-04 Thread Merlijn Sebrechts
andle charm > reviews and the top-level namespace of the charm store. We’ve taken a look > at what’s happened in the past and where we want to get to and decided that > a much more lightweight process is the way forward. > > The biggest change is actually the sunsetting of the charm r

Future of the Charm Review Queue

2017-08-04 Thread Tim Van Steenburgh
change is actually the sunsetting of the charm review queue. The reality is the process as it stands cannot keep up with the demand for reviews. We’ve decided to take a community curation approach. A charm review is no longer a prerequisite for promulgation to the top-level namespace of the charm

Re: [Review Queue]: elasticsearch (v5!) and general cleanup

2017-04-22 Thread Ante Karamatić
problem on Trusty). Kibana charm is also based on James Beedy's work. I'd be happy to drop my repos and charms (cs:~ivoks/kibana and cs:~ivoks/elasticsearch) in favor of what comes out of elastic-ops team. On Thu, Apr 20, 2017 at 5:52 PM Kevin Monroe wrote: > Hey Juju, I spent some time in

[Review Queue]: elasticsearch (v5!) and general cleanup

2017-04-20 Thread Kevin Monroe
Hey Juju, I spent some time in the review queue today: - Cleanup - Moved reviews that were awaiting author feedback into “Needs Fixing” - Elasticsearch - https://review.jujucharms.com/reviews/103?revision=270 - Minor README suggestions

[Review Queue] ibm-was-nd-dm, ibm-was-nd-node, autoscaler, spectrum-scale-client

2017-04-14 Thread Pete Vander Giessen
Yesterday, Cory, Kevin and I took a trip through the review queue. Here's what we did: April 13, 2017: Cory, Kevin, Pete - Ibm-was-nd-dm - https://review.jujucharms.com/reviews/68?revision=153 - Charm code review looks good, with a minor exce

[Review Queue] landscape-dense, charmscaler, k8s-*, ibm-*

2017-04-06 Thread Kevin Monroe
Hi folks, Konstantinos, Pete, Cory and I had some time in the queue today: - Landscape-dense - https://review.jujucharms.com/reviews/113?revision=307 - Previous issue of insufficient machine constraints has been resolved. - This bundle does not include

[Review Queue] landscape-scalable, landscape-dense, ibm-was-base, ibm-was-nd, kubernetes, mongodb, ibm-spectrum-scale-manager

2017-03-30 Thread Cory Johns
Greetings, Kevin, Pete, and I took a stab at the review queue today. March 30, 2017: Kevin, Pete, Cory - Landscape-scalable - https://review.jujucharms.com/reviews/112 - Looks good, promulgated to: - https://jujucharms.com/landscape-scalable

[Review Queue] ibm-was-nd, ganglia, ganglia-node, ibm-was-base, ibm-was-nd-node, ibm-dsm-base, ibm-platform-ac, ibm-cinder-storwize-svc

2017-03-24 Thread Pete Vander Giessen
Hi All, Konstantinos, Kevin, Cory and I took a trip through the review queue yesterday. Here's what we did: - Ibm-was-nd - https://review.jujucharms.com/reviews/40?revision=277 - I was able to deploy this successfully, but I’m not sure if that was a good

[Review Queue] apache2

2017-03-22 Thread Matt Bruzek
I spent some time reviewing the changes to enable xenial for the apache2 charm by user ack. The charm is still original and needs to be updated to reactive but the author didn't make any changes to the code, just the metadata. Also this charm needs a new maintainer as the existing one has moved on

Re: [Review Queue] Elastisys Charmscaler Promulgated!

2017-03-21 Thread Merlijn Sebrechts
PS: The in-page links in your README don't work in the charm store because of this bug: https://github.com/juju/juju-gui/issues/2650 If you want' add a :+1: to that bug so they know I'm not the only one using such links ;) PPS: I saw *"By using the Elastisys CharmScaler, you agree to its license a

Re: [Review Queue] Elastisys Charmscaler Promulgated!

2017-03-21 Thread Merlijn Sebrechts
The issue I see here is that there is much more momentum behind stuff like Nagios. It would be great if you could just plug this into existing monitoring/metrics solutions. I see the Charm has some Nagios-related config options and relations, is there some documentation about how this charm integr

Re: [Review Queue] Elastisys Charmscaler Promulgated!

2017-03-21 Thread Simon Kollberg
On 21 March 2017 at 13:00, Merlijn Sebrechts wrote: > Awesome stuff! > > Would it make sense to expose the autoscaling options over an > interface/relationship? So that you can connect the autoscaler to a charm > and the charm tells the autoscaler how it should be scaled > Yea! It would be r

Re: [Review Queue] Elastisys Charmscaler Promulgated!

2017-03-21 Thread Rick Harding
The question there is how different businesses will have different rules. I think it makes sense for a relation to describe what the charm author thinks is useful parameters/etc and maybe some default scaling config but I think that different folks will have different tastes to this. Especially as

Re: [Review Queue] Elastisys Charmscaler Promulgated!

2017-03-21 Thread Merlijn Sebrechts
Awesome stuff! Would it make sense to expose the autoscaling options over an interface/relationship? So that you can connect the autoscaler to a charm and the charm tells the autoscaler how it should be scaled 2017-03-20 21:54 GMT+01:00 Simon Kollberg : > > > On 20 March 2017 at 18:13, Char

Re: [Review Queue] Elastisys Charmscaler Promulgated!

2017-03-20 Thread Simon Kollberg
On 20 March 2017 at 18:13, Charles Butler wrote: > Greetings, > > I realized last week I had completed a review and failed to send an update > to the mailing list. As some of you may have heard on the Juju Show that > Elastisys released their Charm Scaler to the promulgated channel. > > > This wa

[Review Queue] Elastisys Charmscaler Promulgated!

2017-03-20 Thread Charles Butler
Greetings, I realized last week I had completed a review and failed to send an update to the mailing list. As some of you may have heard on the Juju Show that Elastisys released their Charm Scaler to the promulgated channel. This was an easy +1 from me, with comprehensive test suites, and exampl

[Review Queue] kubernetes-*, flannel, ibm-mobilefirst-server, Ibm-websphere-liberty and more

2017-03-17 Thread Konstantinos Tsakalozos
that the review queue can see it. - Ibm-dsm-enterprise - https://review.jujucharms.com/reviews/57 - Marked as “needs fixing”, per the comments on the review. - Ibm-was-nd - https://review.jujucharms.com/reviews/40?revision=245

[Review Queue] docker-registry charm

2017-03-08 Thread Matt Bruzek
I took some time to review the docker-registry charm from Caio Begotti today. The charm was written in reactive and the code looked good to me, but the charm did not deploy cleanly and had some other things that could be improved such as setting the application version. This will be a very useful

[Review Queue] giraph, ghost, charmscaler, ibm-was-nd-dm, ibm-dsm-enterprise, ibm-cinder-storewize, ibm-was-nd-node

2017-03-02 Thread Cory Johns
Greetings! Kevin, Pete, Konstantinos, and I got in our time on the queue this week: March 2, 2017 - giraph - https://review.jujucharms.com/reviews/82 - PR from last week was approved by the author. - Deployed fine and tests passed. Congrats! +1 and pr

[Review Queue]: giraph, ibm-*, mongodb, odoo, ntp

2017-02-24 Thread Kevin Monroe
Hi friends! Cory, Kostas, Pete, and I have 2 weeks worth of reviews to note: Feb 23, 2017: - giraph - https://review.jujucharms.com/reviews/82 - This has been on our radar for a few review cycles now. We added a proper giraph interface so this charm no longer

[Review Queue]: openvpn, interface-ibm-mq, canonical-livepatch, Eclipse Che, Pgbouncer

2017-02-13 Thread Konstantinos Tsakalozos
Hi everyone, Cory, Kevin and I spent some time reviewing charm. Here is what we got: - openvpn - https://review.jujucharms.com/reviews/58 - Promulgated! - interface-ibm-mq - https://bugs.launchpad.net/charms/+bug/1636120 - Raised a

Re: [Review Queue]: websphere liberty, canonical-livepatch, ganglia-node, gluster, openvpn

2017-02-04 Thread Antonio Rosales
On Sat, Feb 4, 2017 at 9:48 AM, Merlijn Sebrechts wrote: > Thanks Cory and team! > > > I didn't test my Charm on a public cloud, which meant I had a code path that > wasn't executed before. I fixed it and used my Charm Developer Program > Credentials® verify on AWS. Mentioning it because those are

Re: [Review Queue]: websphere liberty, canonical-livepatch, ganglia-node, gluster, openvpn

2017-02-04 Thread Merlijn Sebrechts
Thanks Cory and team! I didn't test my Charm on a public cloud, which meant I had a code path that wasn't executed before. I fixed it and used my Charm Developer Program Credentials® verify on AWS. Mentioning it because those are very useful! :) I uploaded the next version to the Charm Store; do

[Review Queue]: websphere liberty, canonical-livepatch, ganglia-node, gluster, openvpn

2017-02-03 Thread Cory Johns
Greetings! Kevin, Konstantinos, Pete, and I worked on the queue yesterday. Got a new promulgation, and some feedback. Thanks to the charming community! Feb 2, 2017: Cory, Kevin, Kostas, Pete - Websphere Liberty - https://review.jujucharms.com/reviews/48 - Deploym

[Review Queue]: ibm-platform-*, dokuwiki, kubes-*, znc, giraph, easyrsa, flannel, ganglia

2017-01-27 Thread Kevin Monroe
Hi Juju! Cory, Kostas, Pete, and myself ran through the queue yesterday. We have lots of great +1 / promulgation to announce! Here's the rundown: Jan 26, 2017: Cory, Kevin, Kostas, Pete - IBM-platform-lsf-server - https://review.jujucharms.com/reviews/18 - Tests

[Review Queue] ODOO, ZNC, Dokkuwiki, ibm-platform-symphony-master, ibm-http

2017-01-25 Thread Charles Butler
Greetings! The ~containers team took a stroll through the review queue today and reviewed several submissions. We had some findings and the full report can be found below: ZNC Charm Review: (Disapprove Vote) By @cynerva Had a look through the ZNC charm submitted by adam-stokes. The charm looks

[Review Queue] giraph, dokuwiki, znc, kubernetes-master

2017-01-13 Thread Konstantinos Tsakalozos
Hi everyone, Kevin, Pete, and me went through the queue. Here is what we worked on: Jan 12, 2017: Konstantinos, Kevin, Pete - giraph - https://review.jujucharms.com/reviews/82 - Did initial code pass, but the charm submitted for review (https:// jujucharms.c

[Review Queue]: ghost, znc, IBM-*

2016-12-16 Thread Kevin Monroe
Hi Juju, Cory, Kostas, Pete, and I waded through https://review.jujucharms.com/ this week. Here's what we found: - ghost - https://review.jujucharms.com/reviews/62 - Ghost is a simple, powerful publishing platform. - The charm is in a good shape (24th

[Review Queue] dokuwiki, telegraph, websphere liberty, odoo, nrpe and lsf server

2016-12-09 Thread Konstantinos Tsakalozos
Hi everyone, Cory, Kevin, Pete, and I went through the queue. Here is what we worked on: - dokuwiki - https://review.jujucharms.com/reviews/22?revision=113 - The author addressed many of the comments we had in the previous review cycle - The amule

Re: Charm Review Queue & Charm Testing

2016-12-07 Thread Mark Shuttleworth
Nicely done, all. Glad to see the source of the review queue mechanism published, too. Mark On 06/12/16 08:15, Tim Van Steenburgh wrote: > > Hi everyone, > > To follow up on ideas discussed at the past Juju Charmer summit, we've > been working to improve the Juju Charm rev

Charm Review Queue & Charm Testing

2016-12-06 Thread Tim Van Steenburgh
Hi everyone, To follow up on ideas discussed at the past Juju Charmer summit, we've been working to improve the Juju Charm review queue experience. The Juju Charm Store is no longer tied to Launchpad, and thus we no longer rely on branch merges and auto-ingestion to get reviewed items int

[Review Queue] IBM WAS Base, IBM Websphere Liberty, MySQL, Squid Reverse Proxy, Bip IRC Proxy, Ghost

2016-12-01 Thread Pete Vander Giessen
Hi All, The Big Data team (Konstantinos, Kevin, Cory and Pete) took a trip through the review queue today, with a focus on wrapping things up in the old queue, and preparing to move things to the new queue. Here's what we did: - IBM WAS Base - https://review.jujucharm

[Review Queue] ibm-platform-lsf-master

2016-11-30 Thread Matt Bruzek
I spent some time reviewing charms from our IBM partners. The ibm-platform-lsf-master passed my tests and I promoted it to recommended status. https://jujucharms.com/ibm-platform-lsf-master/ Congratulations and great job to the IBM charmers who made this possible. Cheers! - Matt Bruzek --

[Review Queue] ntp, ntpmaster, nagios, ibm-http, ghost, ibm-spectrum-symphony-master

2016-11-17 Thread Cory Johns
Greetings, all. Kevin, Konstantinos, Pete, and I reviewed some charms in the new review queue this week and last week, which I forgot to send out an email for. Nov 17, 2016: Cory, Konstantinos, Kevin - IBM HTTP Server - https://bugs.launchpad.net/charms/+bug/1612535

[Review Queue] MySQL, IBM Platform Application Center

2016-10-27 Thread Pete Vander Giessen
Hi All, I took a trip through the review queue is week. Here's what I did: Oct 27, 2016: Pete - MySQL - https://code.launchpad.net/~jillrouleau/charms/trusty/mysql/raise-max-conns-lp1382386/+merge/303638 - I believe that the codebase for this charm has

[Review Queue] IBM Platform RTM, LSF, Symphony, and Websphere Base

2016-10-21 Thread Kevin Monroe
://review.jujucharms.com/reviews/15 - Finished a read-through of code, and checked off most of the boxes in our new review queue. - Rebuilt the charm locally and re-ran the tests. Am still seeing linter errors (though there are fewer, now that the storage layer has been

[Review Queue]: IBM NFS Storage and IBM Platform Master interfaces

2016-10-19 Thread Kevin Monroe
Matt and I took a look at the following interfaces from IBM today: - IBM NFSStorage interface - https://bugs.launchpad.net/charms/+bug/1578166 - +1 from us after lint fixes - IBM PlatformMaster interface - https://bugs.launchpad.net/charms/+bug/15

[Review Queue] IBM Http Server, LSF Master, LSF Server, DB2, Symphony Master

2016-10-17 Thread Konstantinos Tsakalozos
Hi everyone, Cory, Kevin, Pete and me got together to do some charm reviewing. Here is the summary: Oct 13, 2016: Pete, Kevin, Cory, Kostas - IBM HTTP Server - https://bugs.launchpad.net/charms/+bug/1612535 - This new subordinate charm deploys IBM Http Server that

[Review Queue] ibm-http, gluster, docker, ntpmaster, bip, mongodb, lsf, ibm spectrum symphony

2016-08-26 Thread Pete Vander Giessen
Hi All, This week, Kevin, Kostas, Cory and I reviewed the following: - ibm-http - https://bugs.launchpad.net/charms/+bug/1612535 - - gluster - https://bugs.launchpad.net/charms/+bug/1469213 - Promulgated! - Docker - htt

[Review Queue] IBM IM, Pubphoto, Wordpress, Bip

2016-08-15 Thread Kevin Monroe
Last week, Kostas, Pete, and I reviewed the following: - IBM Installation Manager - https://bugs.launchpad.net/charms/+bug/1575746 - Good example of a charm utilizing Resources and Terms. - Deployed with trusty and xenial and successfully exercised insta

[Review Queue] Ubuntu-repository-cache

2016-08-05 Thread Charles Butler
Greetings, I spent some time today reviewing charm submissions and here are the results: - https://code.launchpad.net/~daniel-thewatkins/charms/trusty/ubuntu-repository-cache/error-message-fix/+merge/292622 - The submission looks fine, however the charm fails deployment in its

[Review Queue] nagios, pubphoto, apache2, nrpe-external-master, couchbase, kibana, big data conjure-up spells

2016-08-04 Thread Cory Johns
Greetings. Konstantinos, Pete, and I reviewed some items from the RQ today. We also forgot to send out notification of some reviews we did the week before last. Aug 4, 2016: Cory/Konstantinos/Pete - Nagios - cross platform support (centos) - https://code.launchpad.net/~dbulig

[Review Queue] collectd, and prometheus

2016-08-03 Thread Matt Bruzek
I reviewed the collectd and prometheus charms today. The reactive code is very well written and both charms deployed correctly. The charms still had the basic auto-generated tests, and the readme files were VERY minimal. Both charms would fail the lint step on bundletester (our automated testing t

[Review Queue] Nexenta Edge Suite

2016-07-19 Thread Charles Butler
Greetings Anton, I took a moment to take a look today and they were +1 LGTM and have pushed your proposed changes to the nexenta edge charms. The following is the result of the review/publication cycle: url: cs:~nexenta-charmers/trusty/nexentaedge-iscsi-gw-4 channel: stable url: cs:~nexenta-ch

[Review Queue] Abot, ubuntu-repo-cache, IBM, mongodb, haproxy, wordpress, squid

2016-07-15 Thread Konstantinos Tsakalozos
Hi all, Here is the work the BigData team was doing on the review queue in the past weeks: July 14, 2016: Cory/Kevin/Kostas/Pete - squid (centos) - https://code.launchpad.net/~dbuliga/charms/trusty/squid-reverseproxy/centos/+merge/287481 - This merge request

[Review Queue] ibm-mq and ibm-pac designs

2016-07-13 Thread Matt Bruzek
Hello, Kevin and I spent some time reviewing the design documents for IBM MQ and the IBM Platform Application Center (PAC). ibm-mq: https://docs.google.com/document/d/1C2Rlo1hwTcHljO1NacsQKfcBMki7wKI9WgAPUuv0Yy0/edit ibm-pac: https://docs.google.com/document/d/1JJRJM-UDZHsC1gGaU1j17oCWdg8ywYbzh_

Re: [Review Queue] multiple IBM designs

2016-07-06 Thread Mark Shuttleworth
Yes, it's great to see this shift towards up-front professional design for charms. The new reactive framework has really made it essential to think of charms as full-blown open source code with reusable aspects that are shared across the ops community. Mark On 06/07/16 15:22, Kevin Monroe wrote:

[Review Queue] multiple IBM designs

2016-07-06 Thread Kevin Monroe
Hi folks, the IBM Charmers have adjusted several of their in-flight designs to use Juju 2.0 features (specifically, Terms and Resources). Matt and I took a look at the following: - IBM Installation Manager : https://docs.google.com/document/d/1qBzMO_Zgy35ty6NCBfdI5Utn7B4I4sTX3_FtPs3UndY/pub - IBM

Re: [Review Queue] rlec, nrpe-external, nagios, squid-reverseproxy, ubuntu-repository-cache, ibm-im

2016-06-24 Thread Kevin Monroe
Hmph, i'll have to double check, but I'm fairly sure the resource was getting fetched every time -- even if it did not change. Regardless, in the upgrade-hook handler, we were resource-get'ing a resource, checking its md5 against a previous md5, and if it did not match, we were removing it and cal

Re: [Review Queue] rlec, nrpe-external, nagios, squid-reverseproxy, ubuntu-repository-cache, ibm-im

2016-06-24 Thread Nate Finch
Yeah, resource-get is specifically optimized to be able to be called as often as you want. Each one makes a network call to the controller, but unless the resource has changed, no data will be downloaded. On Fri, Jun 24, 2016 at 4:24 PM Jay Wren wrote: > Could you expand on the resource-get ine

Re: [Review Queue] rlec, nrpe-external, nagios, squid-reverseproxy, ubuntu-repository-cache, ibm-im

2016-06-24 Thread Jay Wren
Could you expand on the resource-get inefficiencies? The resource-get docs say this: If "resource-get" for a resource has not been run before (for the unit) > > then the resource is downloaded from the controller at the revision > > associated with the unit's application. That file is stored in t

[Review Queue] rlec, nrpe-external, nagios, squid-reverseproxy, ubuntu-repository-cache, ibm-im

2016-06-24 Thread Kevin Monroe
Andrew, Cory, Kostas, Pete, and I went through the queue. Here's what we found: - RLEC (Kostas) - https://bugs.launchpad.net/charms/+bug/1551133 - This charm deploys Redis Labs Enterprise Cluster that enables you to install an enterprise-grade cluster for mana

[Review Queue] Auditd

2016-06-17 Thread Charles Butler
Tim Kuhlman needed a hot review for auditd. This was a good looking submission, primarily a sync of lower layers and some minor top layer edits. Approved has been pushed to: cs:trusty/auditd-1 All the best, Charles -- Juju Charmer Canonical Group Ltd. Ubuntu - Linux for human beings | www.ub

[Review Queue] Abot, Rabbitmq-server, IBM, and npm-app

2016-06-17 Thread Konstantinos Tsakalozos
Hi everyone, The big data team (Kevin, Pete, Andrew and me) got together to do some reviews: June 16, 2016: Kevin/Kostas/Pete/Andrew - Abot - https://bugs.launchpad.net/charms/+bug/1582176 - The initial version of the Test Automation Framework charm -

[Review Queue] ibm-spectrum-scale and ibm-ucd

2016-06-10 Thread Matt Bruzek
Kevin and I spent some time reviewing design documents for IBM Spectrum Scale (formerly gpfs), and UrbanCode Deploy (UCD). The IBM Spectrum Scale design felt like a bundle already because it had a client to manager relationship. We had some comments about using terms and resources but feel this de

[Review Queue] MariaDB

2016-06-06 Thread Charles Butler
Greetings, Today I took some time to peruse the MariaDB Charm submission by dbart https://bugs.launchpad.net/charms/+bug/1587641 +1 - merged and published as cs:trusty/mariadb-3 https://jujucharms.com/mariadb/ All the best, Charles -- Juju Charmer Canonical Group Ltd. Ubuntu - Linux for human

[Review Queue] diaspora, npm-app, pubphoto, ELK stack, MongoDB, saiku, IBM Installation Manager

2016-06-02 Thread Pete VanderGiessen
Hi Everyone, Cory, Konstantinos, Kevin, Andrew and I took a trip through the review queue this week. Here is what we did: - diaspora - https://bugs.launchpad.net/charms/+bug/1553534 - All items from previous review were addressed - This has been

[Review Queue] cassandra (x2), openjdk, logstash, ganglia-node

2016-05-26 Thread Kevin Monroe
Hi folks, Cory, Kostas, new guy Pete, and myself took a trip down the queue today. Here's what we found: - cassandra (fix disk checks) - https://code.launchpad.net/~stub/charms/trusty/cassandra/fix-diskchecks/+merge/283760 - +1, merged - cassandra (wait

[Review Queue] autotest, ibm-java, interface:ibm-db2, ibm-db2, rsyslog, rsyslog-forwarder-ha

2016-05-22 Thread Cory Johns
Last week, the big data team, myself, Kevin, Konstantios, and Andrew, reviewed several charms, and an interface layer: - Autotest - https://bugs.launchpad.net/charms/+bug/1516654 - The propose of this Charm is to provide the autotest framework to execute client

[Review Queue] ibm-java

2016-05-17 Thread Kevin Monroe
Matt and I took a look at the ibm-java charm today. We had trouble deploying this as it requires a 3rd party to host the installer (something which will be a thing of the past with juju resources!). We sorted our issues and were able to verify this charm deployed and worked successfully. Working

Re: [Review Queue] ibm-xl-fortran and the ibm-pac design

2016-05-11 Thread Antonio Rosales
On Wed, May 11, 2016 at 3:43 PM, Matt Bruzek wrote: > I reviewed the ibm-xl-fortran charm today. The charm got my +1 and was > promulgated to the recommended section of the Juju charm store. Thanks for your review on the charm. Shilpa and Sunitha thanks for your contribution to the Charm communit

[Review Queue] ibm-xl-fortran and the ibm-pac design

2016-05-11 Thread Matt Bruzek
I reviewed the ibm-xl-fortran charm today. The charm got my +1 and was promulgated to the recommended section of the Juju charm store. This is a Power *only* charm only supported on ppc64le Ubuntu. The README clearly calls out this limitation and when you try to install on amd64 it correctly sets

[Review Queue] ibm-xCAT, ibm-was-nd

2016-04-27 Thread Kevin Monroe
Matt and I spent some time reviewing the design documents for the ibm-xCAT and ibm-was-nd layered charms today: xCAT: https://docs.google.com/document/d/1DgK79jsP2mnxfu_5uHWDSgMriy1VN3kYUK2On2OCSU8/edit# WAS ND: https://docs.google.com/document/d/17Uh_EghiBKZiDf8ZiM6T-VQzVfoTj4gOlwTl9oieBwc/edit

[Review Queue] ibm-was-base, ibm-http-server

2016-04-20 Thread Matt Bruzek
Kevin and I spent some time reviewing the design documents for the IBM layers ibm-was-base and ibm-http-server today. https://docs.google.com/document/d/1O7J_SLDdCD-D7J8xG7k_9hAGTo8j7BcfCXbA3iTtkR8/edit https://docs.google.com/document/d/1PQjZofa9aK4s9m2yKcvMkqsLT_esgZ2iJVf-DnVdNEU/edit These ar

[Review Queue] ubuntu-devel, Openjdk, OpenAirInterface LTE eNB-UE simulator, ELK and more...

2016-04-08 Thread Konstantinos Tsakalozos
Hi all, Here is what the big data team has been reviewing the past weeks. April 7, 2016: Cory/Kevin/Kostas - Bird lint fixes - https://code.launchpad.net/~johnsca/charms/trusty/bird/lint/+merge/287962 - Fixes lint errors - Merged - haproxy

[Review Queue] ubuntu, mongodb, ntpmaster, cassandra, rsyslog, rsyslog-forwarder-ha, auditd

2016-03-30 Thread Adam Israel
*ubuntu* Update the charm proof command to be backwards-compatible. +1, merged. https://code.launchpad.net/~1chb1n/charms/trusty/ubuntu/update-charm-proof/+merge/290196 *mongodb* Update the charm proof command to be backwards-compatible and update the maintainers list. +1, merged. https://code.l

[Review Queue] minecraft, rsyslog-fowarder-ha, zulu8, rlec, haproxy, apache2 (x2), fiche, midonet-gateway, collectd

2016-03-11 Thread Kevin Monroe
Hey Juju, Andrew, Kostas, Cory, and I made our way through a slew of reviews. It went something like this: - minecraft - https://bugs.launchpad.net/charms/+bug/1523896 - This is a rewrite of the precise minecraft charm, now using layers and targeting trusty.

[Review Queue] fiche

2016-03-07 Thread Adam Israel
*fiche* This is a new layered charm submission, "for a Netcat-based command line pastebin". The layer itself looks solid. There is one bug in the amulet tests, though, and I'd like to see one update to the README to clarify the default port in use in the example code. The author responded quickly

[Review Queue] haproxy

2016-03-04 Thread Adam Israel
*haproxy - trusty* I fixed a lint error[1] in trunk in order to unblock lp: 285937 - liberty support[2]. Note: there is currently a bug in jujucharms.com where the latest revision isn't reflected on the charm page, i.e., https://jujucharms.com/haproxy/trusty/#revisions does not show the latest r

[Review Queue]

2016-03-02 Thread Adam Israel
Memcached I reviewed two memcached-related proposals today, the former unblocking the latter. Allow memcached connections from non-related units: https://code.launchpad.net/~freyes/charms/trusty/memcached/lp1525026/+merge/287213 Add support for local-monitor interface. My only note here is that

[Review Queue] apache2, cassandra, haproxy, ibm-java-sdk, midonet-gateway

2016-02-29 Thread Cory Johns
Hello all. The Big Data Team (myself, Kevin, Andrew, and Kostas) spent some time last week on the review queue: Feb 25, 2016: Andrew/Cory/Kevin/Kostas - apache2 (add apt config options) - https://code.launchpad.net/~evarlast/charms/trusty/apache2/trunk/+merge/278220

[Review Queue] collectd, mysqltest, apache2 (x2)

2016-02-22 Thread Kevin Monroe
Hi folks, Kostas, Cory, and I had some RQ time last week. Here's what we found - collectd - https://bugs.launchpad.net/charms/+bug/1538573 - The author addressed the comments we had on the previous review round. - A few minor issues still remain. We of

[Review Queue] neutron-openvswitch, ceph, ceph-osd, nova-compute, heat, neutron-api and nova-cloud-controller

2016-02-22 Thread Liam Young
Tidy of package selection code. https://code.launchpad.net/~james-page/charms/trusty/neutron-openvswitch/optmize-headers/+merge/282931 Expose journal dio option in ceph charms to support deployments using LXD containers, backed by ZFS volumes. https://code.launchpad.net/~james-page/charms/trusty/

[Review Queue] lis-test-charm, etcd

2016-02-17 Thread Matt Bruzek
I reviewed the HyperV lis-test-charm today that had a few boilerplate files left inside the charm that should be removed before it passes review: https://bugs.launchpad.net/charms/+bug/1513612 I also reviewed a change to the etcd charm. I pushed this charm to the charm store using the new charm2

[Review Queue] apache2, IBM XL C/C++, IBM Java SDK, collectd, tomcat-webapp

2016-02-16 Thread Konstantinos Tsakalozos
Hi everyone, Here are our notes from reviewing charms on the 11th of Feb. Many thanks to Cory, Kevin and Andrew. - apache2 - https://code.launchpad.net/~evarlast/charms/trusty/apache2/trunk/+merge/278220 - Multiple tests still failing (though maybe unrelated to th

Review Queue: midonet-api, midonet-agent, neutron-agents-midonet

2016-02-04 Thread James Page
Hi All I've spent most of the last two days working with Toni from Midonet to review and test their proposed charms to support deployment of the Midonet SDN as part of the OpenStack charms. Alongside reviewing the actual charm code (they are all services framework integrated with puppet modules f

[Review Queue]

2016-01-30 Thread Adam Israel
Jenkins While sprinting, I did an out of band review of a merge against the jenkins charm, which allows for executor customization, updates the jenkin plugins url, and allows the installation of remote .debs The change raises a couple of minor points, neither of which were blockers in this cas

[Review Queue] Tomcat, SpagoBi, xl c/c++, Minecraft, postgresql, ibm-db2

2016-01-29 Thread Andrew Mcleod
Hello! Yesterday, Corry, Kevin, Konstantinos and I had our combined review queue session, and here are the notes: - tomcat - https://bugs.launchpad.net/charms/+source/tomcat/+bug/1538715 - Community request to have a webapp-container subordinate relation

[Review Queue] memcached

2016-01-28 Thread Adam Israel
https://code.launchpad.net/~freyes/charms/trusty/memcached/lp1525026/+merge/281254 I reviewed a fix to allow the memcached charm’s tests to work (due to firewall issues). I reran tests on LXC and AWS and they f

Re: [Review Queue] bird, neutron-calico, openbook, plumgrid-gateway

2016-01-25 Thread Charles Butler
an 25, 2016 at 9:20 AM, Cory Johns wrote: > Greetings, > > This past Friday, Andrew, Konstantinos, and I spent some time on the > review queue. > > We'd like to thank the fine folks at MetaSwitch for their work on the bird > and neutron-calico charms, which add Project Cali

[Review Queue] bird, neutron-calico, openbook, plumgrid-gateway

2016-01-25 Thread Cory Johns
Greetings, This past Friday, Andrew, Konstantinos, and I spent some time on the review queue. We'd like to thank the fine folks at MetaSwitch for their work on the bird and neutron-calico charms, which add Project Calico and its virtual networking support to OpenStack. -

[Review Queue] apache2, rsyslog-forwarder, cassandra

2016-01-18 Thread Adam Israel
apache2 Confirmed that this merge introduced some test failures, in addition to existing failing tests in the upstream apache2 charm. https://code.launchpad.net/~evarlast/charms/trusty/apache2/trunk/+merge/278220

[Review Queue] nfs, zulu8, saiku, nuage, quobyte, apache2

2016-01-14 Thread Kevin Monroe
Happy 2016 folks! The Big Data team has been rocking the queue this year, and I had the pleasure of announcing our RQ time last week. Unfortunately, I didn't get the note sent out, so I got the chance to cover this week's RQ time as well! Here's what we found: Jan 14, 2016: - nfs -

[Review Queue] MYSQL Charm helpers sync targeted @ mitaka

2016-01-14 Thread Charles Butler
I had a chance to do a quick review today on an update for the MySQL charm to support OpenStack Mitaka https://code.launchpad.net/~1chb1n/charms/trusty/mysql/ch-sync-mitaka/+merge/282209 approved / merged Charles Butler - Juju Charmer Come see the future of datacenter orchestration: http://juju

[Review Queue] - Nexenta Nedge stack

2016-01-13 Thread Charles Butler
I took some time out today to review the Nexenta Nedge cluster, which is an OpenStack deployment storage provider, enabling you to bridge storage from cinder, swift, and aws S3. There were some policy violations and code cleanup - but its coming along nicely and i'm sure that by the second or thir

[Review Queue] ibm-was-base

2016-01-13 Thread Matt Bruzek
I reviewed the ibm-was-base charm today. The charm has made some significant improvement in the code quality, and now uses a sftp transfer protocol. This brings up an interesting topic. Does the use of sftp eliminate the need to check the sha1sum for downloaded packages. The charm had some other

[Review Queue] mysql

2016-01-13 Thread Ryan Beisner
Good day, I tested, reviewed and discussed the following *mysql* charm proposal [1] with peers. The Ubuntu OpenStack Engineering team supports this change as an improved behavior. The impact of the default change has been assessed as very low, both for existing deployments and for new deployment

[Review Queue] nova-cloud-controller keystone ceph-radosgw rabbitmq-server

2016-01-11 Thread Liam Young
Fix upgrades from old versions of the charm https://code.launchpad.net/~hopem/charms/trusty/nova-cloud-controller/lp1519035/+merge/281991 Configure keystone to always create and sync ssl certs https://code.launchpad.net/~hopem/charms/trusty/keystone/lp1520339/+merge/279005 Configure rados gatew

Re: [Review Queue] IBM XL Fortran, IBM DB2

2016-01-08 Thread Adam Israel
Oops. The link to the IBM DB2 bug is: https://bugs.launchpad.net/charms/+bug/1477057 Cheers, -- Adam Israel - Software Engineer Canonical Ltd. http://juju.ubuntu.com/ - Automate your Cloud Infrastructure > On Jan 8, 2016, at 6:13 PM, Adam Israel

[Review Queue] IBM XL Fortran, IBM DB2

2016-01-08 Thread Adam Israel
IBM XL Fortran There’s good progress being made on this charm, including the change to make the charm a subordinate. There are a handful of recommended changes to make, and clarification about the upgrade path as the charm currently installs an evaluation version of IBM XL Fortran but does not

[Review Queue] heat

2016-01-07 Thread Liam Young
Make instance_user configurable for Heat https://code.launchpad.net/~macgreagoir/charms/trusty/heat/instance_user/+merge/276499 Needs fixing: Enable integration with hacluster. Looks good but needs some tweaks to unit and functional tests. https://code.launchpad.net/~cbjchen/charms/trusty/hea

Re: [Review Queue] - kafka, kibana, apache2 x2, mariadb, memcached

2015-12-22 Thread Felipe Reyes
Hi Andrew, On Fri, 11 Dec 2015 17:37:16 +0100 Andrew Mcleod wrote: >memcached (local-monitor interface) >- > > > > https://code.launchpad.net/~brad-marshall/charms/trusty/memcached/add-monitors-relation/+merge/276958 > - > > The charm tests fail. Test 10_deploy_test

Re: Review Queue - midonet-api

2015-12-19 Thread Stuart Bishop
On 17 December 2015 at 20:10, James Page wrote: > datastax and midonet repositories and some DNS hijacking (I'll write that up I'd be interested in knowing what would be required of the Cassandra charm for it to be used, rather than having Cassandra embedded. -- Stuart Bishop -- Juju mailin

[Review Queue] - cassandra (x2), ethercalc, IBM XLC/C++, New Charm: minecraft, Saiku Enterprise Analytics

2015-12-18 Thread Konstantinos Tsakalozos
Hi, The Big Data team spent some time on the review queue. Here's what we came up with: - cassandra/noppa - https://code.launchpad.net/~stub/charms/trusty/cassandra/noppa/+merge/278097 - The proposed MP contains significantly more changes than th

Review Queue - midonet-api

2015-12-17 Thread James Page
Hi Folks I spent my morning reviewing the Midonet charms proposed under: https://bugs.launchpad.net/charms/+bug/1453678 I set myself a challenge of managing to run the amulet tests in our egress limited QA cloud; managed to get most of that working with local mirrors of datastax and midonet re

[Review Queue] mongodb, cassandra, ubuntu-repository-cache

2015-12-16 Thread Matt Bruzek
Charles Butler and I spent some time reviewing charms that were in the Review Queue. We process the queue top down, so the oldest charms first. Here is a summary of what we found with links to the merge proposals for more details. *mongodb * - https://code.launchpad.net/~tvansteenburgh

[Review Queue] rabbitmq-server

2015-12-15 Thread Ryan Beisner
Good day, I tested, reviewed and discussed the following *rabbitmq-server* charm proposal with peers. While the Ubuntu OpenStack Engineering team supports the essence of this proposal as a more secure default stance for the charm to take, and the impact of the default change has been assessed as

[Review Queue] - kafka, kibana, apache2 x2, mariadb, memcached

2015-12-11 Thread Andrew Mcleod
It's that time again; the Big Data team had a go at the review queue, and here's what we came up with: - kafka - https://code.launchpad.net/~merlijn-sebrechts/charms/trusty/apache-kafka/trunk/+merge/276647 - New actions and upstart job work a

  1   2   3   4   >