[GitHub] [kafka] omkreddy closed pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

omkreddy closed pull request #9050: URL: https://github.com/apache/kafka/pull/9050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ableegoldman commented on pull request #8976: KIP-617: Allow Kafka Streams State Stores to be iterated backwards

ableegoldman commented on pull request #8976: URL: https://github.com/apache/kafka/pull/8976#issuecomment-670624337 Awesome, thanks @jeqo ! Let me know when the first PR is ready for review again (or is it ready now?) This i

[GitHub] [kafka] omkreddy commented on pull request #8878: MINOR: Generator config-specific HTML ids

omkreddy commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-670626828 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mimaison commented on pull request #9131: KAFKA-10367: Allow running the Streams demo app with a config file

mimaison commented on pull request #9131: URL: https://github.com/apache/kafka/pull/9131#issuecomment-670634953 Thanks @mjsax, I wasn't expecting a review this quickly! Sorry for not fully checking the changes before opening the PR.

[GitHub] [kafka] lct45 opened a new pull request #9141: MINOR: Improve checks for CogroupedStreamAggregateBuilder

lct45 opened a new pull request #9141: URL: https://github.com/apache/kafka/pull/9141 Updated `CogroupedStreamAggregateBuilder` to have individual builders depending on the windowed aggregation, or lack thereof. This replaced passing in all options into the builder, with all but the curren

[GitHub] [kafka] hachikuji commented on a change in pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

hachikuji commented on a change in pull request #7222: URL: https://github.com/apache/kafka/pull/7222#discussion_r467143222 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1120,17 +1123,28 @@ Node selectReadReplica(TopicParti

[GitHub] [kafka] lbradstreet closed pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

lbradstreet closed pull request #9123: URL: https://github.com/apache/kafka/pull/9123 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] lbradstreet commented on a change in pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

lbradstreet commented on a change in pull request #7222: URL: https://github.com/apache/kafka/pull/7222#discussion_r467187874 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -422,10 +421,13 @@ synchronized int numAss

[GitHub] [kafka] hachikuji merged pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

hachikuji merged pull request #9110: URL: https://github.com/apache/kafka/pull/9110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r467191680 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -508,7 +563,15 @@ object ConfigCommand extends Config { val entityStr

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r467193718 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1251,15 +1267,28 @@ private ListOffsetRequest createL

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r467194925 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1221,28 +1226,39 @@ private DeleteGroupsResponse cre

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-670643947 @abbccdda I've addressed your comments, can you take another look? This is an automated message from the Apache G

[GitHub] [kafka] mimaison commented on a change in pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

mimaison commented on a change in pull request #9136: URL: https://github.com/apache/kafka/pull/9136#discussion_r467206725 ## File path: clients/src/main/java/org/apache/kafka/common/config/provider/DirectoryConfigProvider.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apach

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r467214507 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -497,10 +497,10 @@ class AuthorizerIntegrationTest extends Ba

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r467215647 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -497,10 +497,10 @@ class AuthorizerIntegrationTest extends B

[GitHub] [kafka] skaundinya15 opened a new pull request #9142: MINOR: fixing delete topic for system tests

skaundinya15 opened a new pull request #9142: URL: https://github.com/apache/kafka/pull/9142 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* The current impl

[GitHub] [kafka] ableegoldman commented on a change in pull request #9141: MINOR: Improve checks for CogroupedStreamAggregateBuilder

ableegoldman commented on a change in pull request #9141: URL: https://github.com/apache/kafka/pull/9141#discussion_r467210400 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -47,18 +47,96 @@ Cogrou

[GitHub] [kafka] skaundinya15 opened a new pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer

skaundinya15 opened a new pull request #9143: URL: https://github.com/apache/kafka/pull/9143 Currently the way we calculate the number of total consumed messages for the verifiable consumer overcounts the number of actually consumed messages. This PR is to fix that to ensure we count the n

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r467231847 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] mjsax commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.

mjsax commented on a change in pull request #9133: URL: https://github.com/apache/kafka/pull/9133#discussion_r467233225 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f

[GitHub] [kafka] johnthotekat commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.

johnthotekat commented on a change in pull request #9133: URL: https://github.com/apache/kafka/pull/9133#discussion_r467235567 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] lct45 commented on a change in pull request #9141: MINOR: Improve checks for CogroupedStreamAggregateBuilder

lct45 commented on a change in pull request #9141: URL: https://github.com/apache/kafka/pull/9141#discussion_r467236081 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -47,18 +47,96 @@ CogroupedStre

[GitHub] [kafka] johnthotekat commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.

johnthotekat commented on a change in pull request #9133: URL: https://github.com/apache/kafka/pull/9133#discussion_r467236707 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] johnthotekat commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.

johnthotekat commented on a change in pull request #9133: URL: https://github.com/apache/kafka/pull/9133#discussion_r467236707 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] mjsax commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

mjsax commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-670689958 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.

mjsax commented on a change in pull request #9133: URL: https://github.com/apache/kafka/pull/9133#discussion_r467244495 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f

[GitHub] [kafka] cmccabe commented on pull request #9103: Add redirection for (Incremental)AlterConfig

cmccabe commented on pull request #9103: URL: https://github.com/apache/kafka/pull/9103#issuecomment-670693346 I think it would be good to split this PR up a little bit. It seems like we could have a split like this: PR 1. `Add flag to the RequestContext` and `Add initial principal

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r467260318 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,389 @@ +/* + * Licensed to th

[GitHub] [kafka] rondagostino commented on a change in pull request #9142: MINOR: Fix delete_topic for system tests

rondagostino commented on a change in pull request #9142: URL: https://github.com/apache/kafka/pull/9142#discussion_r467263885 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None, use_zk_to_create_topic=True)

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r467273920 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -504,6 +515,7 @@ public void onSuccess(Byt

[GitHub] [kafka] skaundinya15 commented on a change in pull request #9142: MINOR: Fix delete_topic for system tests

skaundinya15 commented on a change in pull request #9142: URL: https://github.com/apache/kafka/pull/9142#discussion_r467274037 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None, use_zk_to_create_topic=True)

[GitHub] [kafka] mjsax commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

mjsax commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r466716421 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -49,6 +61,30 @@ this.stateDirectory = state

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r467296111 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void sh

[GitHub] [kafka] soondenana commented on pull request #9140: KAFKA-10371; Partition reassignments can result in crashed ReplicaFetcherThreads

soondenana commented on pull request #9140: URL: https://github.com/apache/kafka/pull/9140#issuecomment-670730240 I can confirm that this fixes the issue. I ran system test 18 times and didn't hit this issue. Without this fix, when I run the system test 10 times I hit the issue 2 times.

[GitHub] [kafka] mjsax commented on pull request #9141: MINOR: Improve checks for CogroupedStreamAggregateBuilder

mjsax commented on pull request #9141: URL: https://github.com/apache/kafka/pull/9141#issuecomment-670745736 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji merged pull request #9140: KAFKA-10371; Partition reassignments can result in crashed ReplicaFetcherThreads

hachikuji merged pull request #9140: URL: https://github.com/apache/kafka/pull/9140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] abbccdda opened a new pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

abbccdda opened a new pull request #9144: URL: https://github.com/apache/kafka/pull/9144 Add the redirection supporting fields, including: 1. initial principal name 2. initial client id 3. the flag to indicate whether a given request is coming from the control plane in a secure

[GitHub] [kafka] cmccabe commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

cmccabe commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467330529 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java ## @@ -37,11 +37,22 @@ public RequestHeader(Struct struct, short he

[GitHub] [kafka] cmccabe commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

cmccabe commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467330705 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java ## @@ -69,4 +69,11 @@ * Returns the correlatio

[GitHub] [kafka] cmccabe commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

cmccabe commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467330968 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -309,7 +309,10 @@ object RequestChannel extends Logging { } } -class Reques

[GitHub] [kafka] cmccabe commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

cmccabe commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467331218 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -88,15 +88,17 @@ class SocketServer(val config: KafkaConfig, private val memoryP

[GitHub] [kafka] cmccabe commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

cmccabe commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467331218 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -88,15 +88,17 @@ class SocketServer(val config: KafkaConfig, private val memoryP

[GitHub] [kafka] ning2008wisc opened a new pull request #9145: KAFKA-10370: rewind consumer to SinkTaskContext's offsets when init

ning2008wisc opened a new pull request #9145: URL: https://github.com/apache/kafka/pull/9145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] ning2008wisc commented on pull request #9145: KAFKA-10370: rewind consumer to SinkTaskContext's offsets when init

ning2008wisc commented on pull request #9145: URL: https://github.com/apache/kafka/pull/9145#issuecomment-670820575 As mentioned in https://stackoverflow.com/questions/54480715/no-current-assignment-for-partition-occurs-even-after-poll-in-kafka, another potential resolution could be "call

[GitHub] [kafka] mjsax commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

mjsax commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r467291346 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -93,9 +90,7 @@ public boolean isActive() { publi

[GitHub] [kafka] johnthotekat opened a new pull request #9146: KAFKA-10316 Updated Kafka Streams upgrade-guide.html

johnthotekat opened a new pull request #9146: URL: https://github.com/apache/kafka/pull/9146 * This PR updates the upgrade guide for the changes in https://github.com/apache/kafka/pull/9120. * Added the details on KIP-648 to 2.7.0 upgrade notes - docs/streams/upgrade-guide.html. @mjs

[GitHub] [kafka] johnthotekat closed pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.

johnthotekat closed pull request #9133: URL: https://github.com/apache/kafka/pull/9133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] johnthotekat commented on pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.

johnthotekat commented on pull request #9133: URL: https://github.com/apache/kafka/pull/9133#issuecomment-670823191 This branch got a little messed up during the rebase :( Raised another PR https://github.com/apache/kafka/pull/9146 -

[GitHub] [kafka] johnthotekat edited a comment on pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.

johnthotekat edited a comment on pull request #9133: URL: https://github.com/apache/kafka/pull/9133#issuecomment-670823191 Closing this PR. Raised another PR https://github.com/apache/kafka/pull/9146 . This branch got a little messed up during the rebase :( ---

[GitHub] [kafka] ning2008wisc removed a comment on pull request #9145: KAFKA-10370: rewind consumer to SinkTaskContext's offsets when init

ning2008wisc removed a comment on pull request #9145: URL: https://github.com/apache/kafka/pull/9145#issuecomment-670820575 As mentioned in https://stackoverflow.com/questions/54480715/no-current-assignment-for-partition-occurs-even-after-poll-in-kafka, another potential resolution could b

[GitHub] [kafka] jeqo commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

jeqo commented on pull request #9137: URL: https://github.com/apache/kafka/pull/9137#issuecomment-670850075 cc @ableegoldman This PR is ready for review, covering related feedback from #8976 This is an automated messa

[GitHub] [kafka] lbradstreet opened a new pull request #9147: MINOR: supervise TransactionalMessageCopier producer

lbradstreet opened a new pull request #9147: URL: https://github.com/apache/kafka/pull/9147 transactions_test and group_mode_transactions_test have proven quite brittle around timeouts (see 67f5b5de77d67c02edb335737215312d099a1cac, e099b58df5b3e4f87173fc55880f9c343308739f, d9fe30dab

[GitHub] [kafka] lbradstreet commented on a change in pull request #9147: MINOR: supervise TransactionalMessageCopier producer

lbradstreet commented on a change in pull request #9147: URL: https://github.com/apache/kafka/pull/9147#discussion_r467590975 ## File path: tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java ## @@ -345,39 +357,55 @@ public void onPartitionsAssigned(Col

[GitHub] [kafka] vvcephei commented on pull request #9004: KAFKA-10261: Introduce the KIP-478 apis with adapters

vvcephei commented on pull request #9004: URL: https://github.com/apache/kafka/pull/9004#issuecomment-671134339 Just one unrelated test failure: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] failed, log available in /

[GitHub] [kafka] vvcephei merged pull request #9004: KAFKA-10261: Introduce the KIP-478 apis with adapters

vvcephei merged pull request #9004: URL: https://github.com/apache/kafka/pull/9004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9004: KAFKA-10261: Introduce the KIP-478 apis with adapters

vvcephei commented on pull request #9004: URL: https://github.com/apache/kafka/pull/9004#issuecomment-671134513 Merged to trunk. Thanks for the review @abbccdda ! This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] vvcephei opened a new pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

vvcephei opened a new pull request #9148: URL: https://github.com/apache/kafka/pull/9148 From KIP-478, implement the new StreamBuilder#addGlobalStore() overload that takes a stateUpdateSupplier fully typed Processor. Where necessary, use the adapters to make the old APIs defer to t

[GitHub] [kafka] vvcephei commented on a change in pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

vvcephei commented on a change in pull request #9148: URL: https://github.com/apache/kafka/pull/9148#discussion_r467671774 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -499,7 +500,7 @@ public synchronized StreamsBuilder addStateStore(fi

[GitHub] [kafka] showuon opened a new pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

showuon opened a new pull request #9149: URL: https://github.com/apache/kafka/pull/9149 Improve the logging in `maybeCreateTopic` to let user know if `!topicCreation.isTopicCreationRequired(topic)`, we won't create this topic because the topic creation setting is disabled or the topic nam

[GitHub] [kafka] showuon commented on a change in pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

showuon commented on a change in pull request #9149: URL: https://github.com/apache/kafka/pull/9149#discussion_r467713932 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -363,6 +363,7 @@ private boolean sendRecords() {

[GitHub] [kafka] showuon commented on pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

showuon commented on pull request #9149: URL: https://github.com/apache/kafka/pull/9149#issuecomment-671191319 @kkonstantine , could you help review this PR to improve logging? Thanks. This is an automated message from the Ap

[GitHub] [kafka] viktorsomogyi opened a new pull request #9150: KAFKA-9839; Broker should accept control requests with newer broker epoch

viktorsomogyi opened a new pull request #9150: URL: https://github.com/apache/kafka/pull/9150 This is a backport of #8509. A broker throws IllegalStateException if the broker epoch in the LeaderAndIsr/UpdateMetadataRequest/StopReplicaRequest is larger than its current broker epoch.

[GitHub] [kafka] viktorsomogyi commented on pull request #9150: KAFKA-9839; Broker should accept control requests with newer broker epoch

viktorsomogyi commented on pull request #9150: URL: https://github.com/apache/kafka/pull/9150#issuecomment-671213384 @apovzner @hachikuji would you please review this backport? And while I'm at it, I can backport these onto the 2.3 and 2.4 lines as well.

[GitHub] [kafka] showuon commented on a change in pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

showuon commented on a change in pull request #9149: URL: https://github.com/apache/kafka/pull/9149#discussion_r467755721 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -430,7 +434,7 @@ private void maybeCreateTopic(Str

[GitHub] [kafka] viktorsomogyi opened a new pull request #9152: KAFKA-9839; Broker should accept control requests with newer broker epoch

viktorsomogyi opened a new pull request #9152: URL: https://github.com/apache/kafka/pull/9152 A broker throws IllegalStateException if the broker epoch in the LeaderAndIsr/UpdateMetadataRequest/StopReplicaRequest is larger than its current broker epoch. However, there is no guarantee that

[GitHub] [kafka] viktorsomogyi opened a new pull request #9151: KAFKA-9839; Broker should accept control requests with newer broker epoch

viktorsomogyi opened a new pull request #9151: URL: https://github.com/apache/kafka/pull/9151 A broker throws IllegalStateException if the broker epoch in the LeaderAndIsr/UpdateMetadataRequest/StopReplicaRequest is larger than its current broker epoch. However, there is no guarantee that

[GitHub] [kafka] viktorsomogyi commented on pull request #9150: KAFKA-9839; Broker should accept control requests with newer broker epoch

viktorsomogyi commented on pull request #9150: URL: https://github.com/apache/kafka/pull/9150#issuecomment-671323114 2.3: https://github.com/apache/kafka/pull/9151 2.4: https://github.com/apache/kafka/pull/9151 This is an

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #9150: KAFKA-9839; Broker should accept control requests with newer broker epoch

viktorsomogyi edited a comment on pull request #9150: URL: https://github.com/apache/kafka/pull/9150#issuecomment-671323114 2.3: https://github.com/apache/kafka/pull/9151 2.4: https://github.com/apache/kafka/pull/9152 This

[GitHub] [kafka] cadonna opened a new pull request #9153: MINOR: Fix state transition diagram for stream threads

cadonna opened a new pull request #9153: URL: https://github.com/apache/kafka/pull/9153 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] cadonna commented on a change in pull request #9153: MINOR: Fix state transition diagram for stream threads

cadonna commented on a change in pull request #9153: URL: https://github.com/apache/kafka/pull/9153#discussion_r467871730 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -93,7 +95,7 @@ * | +-+

[GitHub] [kafka] cadonna commented on a change in pull request #9153: MINOR: Fix state transition diagram for stream threads

cadonna commented on a change in pull request #9153: URL: https://github.com/apache/kafka/pull/9153#discussion_r467872227 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -80,11 +80,13 @@ * | +-+--

[GitHub] [kafka] cadonna commented on pull request #9153: MINOR: Fix state transition diagram for stream threads

cadonna commented on pull request #9153: URL: https://github.com/apache/kafka/pull/9153#issuecomment-671328193 Call for review: @guozhangwang @ableegoldman This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-671337544 @guozhangwang @abbccdda More comments? This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] astubbs opened a new pull request #9154: Threadsafe mock producer

astubbs opened a new pull request #9154: URL: https://github.com/apache/kafka/pull/9154 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

[GitHub] [kafka] vvcephei commented on a change in pull request #9073: MINOR: add task ':streams:testAll'

vvcephei commented on a change in pull request #9073: URL: https://github.com/apache/kafka/pull/9073#discussion_r467975526 ## File path: build.gradle ## @@ -1266,6 +1266,27 @@ project(':streams') { if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() } standar

[GitHub] [kafka] abbccdda commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

abbccdda commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467975394 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java ## @@ -69,4 +69,11 @@ * Returns the correlati

[GitHub] [kafka] abbccdda commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

abbccdda commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467975757 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java ## @@ -37,11 +37,22 @@ public RequestHeader(Struct struct, short h

[GitHub] [kafka] tombentley commented on a change in pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

tombentley commented on a change in pull request #9136: URL: https://github.com/apache/kafka/pull/9136#discussion_r467984879 ## File path: clients/src/main/java/org/apache/kafka/common/config/provider/DirectoryConfigProvider.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] tombentley commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

tombentley commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-671424344 @mimaison done. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] stanislavkozlovski opened a new pull request #9155: MINOR: Ensure a single version of scala-library is used

stanislavkozlovski opened a new pull request #9155: URL: https://github.com/apache/kafka/pull/9155 This patch ensures we use a force resolution strategy for the scala-library dependency I've tested this locally and saw a difference in the output: With the change (using 2.4 and the

[GitHub] [kafka] stanislavkozlovski commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

stanislavkozlovski commented on pull request #9155: URL: https://github.com/apache/kafka/pull/9155#issuecomment-671429610 In 2.4 we use `def defaultScala212Version = '2.12.10'` yet it gets updated to `2.12.12` due to the jackson-module-scala library using the 2.12.12 version of scala-libra

[GitHub] [kafka] abbccdda commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

abbccdda commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r468005080 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -88,15 +88,17 @@ class SocketServer(val config: KafkaConfig, private val memory

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rajinisivaram commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r467848781 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ScramMechanism.java ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r467279790 ## File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] ijuma commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

ijuma commented on pull request #9155: URL: https://github.com/apache/kafka/pull/9155#issuecomment-671482140 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] big-andy-coates opened a new pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

big-andy-coates opened a new pull request #9156: URL: https://github.com/apache/kafka/pull/9156 fixes: [KAFKA-10077](https://issues.apache.org/jira/browse/KAFKA-10077). Enable sending old values on `KTable.filter` call to avoid the filter forwarding tombstones for rows that do not ex

[GitHub] [kafka] skaundinya15 commented on pull request #9142: MINOR: Fix delete_topic for system tests

skaundinya15 commented on pull request #9142: URL: https://github.com/apache/kafka/pull/9142#issuecomment-671498810 Link to system test run from this branch: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-08-07--001.1596866417--skaundinya15--minor-

[GitHub] [kafka] hachikuji commented on pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

hachikuji commented on pull request #9112: URL: https://github.com/apache/kafka/pull/9112#issuecomment-671500806 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] big-andy-coates commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

big-andy-coates commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-671501927 @mjsax as discussed. Please review. I think this change makes the output from the table filter semantically correct, i.e. we no longer output tombstones for rows tha

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468084269 ## File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468085443 ## File path: clients/src/main/resources/common/message/UpdateFeaturesResponse.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] skaundinya15 commented on pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer

skaundinya15 commented on pull request #9143: URL: https://github.com/apache/kafka/pull/9143#issuecomment-671506739 Link for system test run for this branch: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-08-07--001.1596860596--skaundinya15--minor-

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468089357 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -266,6 +275,199 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] dajac commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

dajac commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r468090360 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java ## @@ -74,7 +77,9 @@ public RequestAndSize parseRequest(ByteBuffer b

[GitHub] [kafka] dajac commented on a change in pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

dajac commented on a change in pull request #9136: URL: https://github.com/apache/kafka/pull/9136#discussion_r468093788 ## File path: clients/src/main/java/org/apache/kafka/common/config/provider/DirectoryConfigProvider.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] lct45 opened a new pull request #9157: Update for KIP-450 to handle early records

lct45 opened a new pull request #9157: URL: https://github.com/apache/kafka/pull/9157 Handles records that fall between 0 and the timeDifference that would normally create negative windows. This puts a new record that falls into this range in a window from [0, timeDifference] and creates t

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468097360 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -266,6 +275,199 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468101982 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -977,14 +1179,30 @@ class KafkaController(val config: KafkaConfig, /**

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-671520491 @chia7712 : I agree mostly with your assessment. For most delayed operations, the checking for the completeness of the operation and the calling of onComplete() don't have to be pr

<    4   5   6   7   8   9   10   11   12   13   >