mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r467193718
##########
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##########
@@ -1251,15 +1267,28 @@ private ListOffsetRequest createListOffsetRequest(int
version) {
private ListOffsetResponse createListOffsetResponse(int version) {
if (version == 0) {
- Map<TopicPartition, ListOffsetResponse.PartitionData> responseData
= new HashMap<>();
- responseData.put(new TopicPartition("test", 0),
- new ListOffsetResponse.PartitionData(Errors.NONE,
asList(100L)));
- return new ListOffsetResponse(responseData);
+ ListOffsetResponseData data = new ListOffsetResponseData()
Review comment:
I'm not sure about adding extra methods to `ListOffsetResponse` just to
remove a few lines in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
