chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-666882466
> Were there significant changes since the last review?
I rebased code base to include
https://github.com/apache/kafka/commit/96e0719e421a91b5fa289dc0d23276977655633e
whic
abbccdda commented on pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#issuecomment-666894017
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
abbccdda merged pull request #9087:
URL: https://github.com/apache/kafka/pull/9087
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463395140
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +313,96 @@ public void handleAssignment
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463395497
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +313,96 @@ public void handleAssignment
hachikuji commented on a change in pull request #8891:
URL: https://github.com/apache/kafka/pull/8891#discussion_r463396781
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -647,8 +647,14 @@ class KafkaController(val config: KafkaConfig,
i
albert02lowis opened a new pull request #9108:
URL: https://github.com/apache/kafka/pull/9108
…treamTableJoinIntegrationTest into its own test
The main goal is to remove usage of embedded broker (EmbeddedKafkaCluster)
in AbstractJoinIntegrationTest and its subclasses.
This is beca
chia7712 commented on pull request #9079:
URL: https://github.com/apache/kafka/pull/9079#issuecomment-666938366
@ijuma Could you please take a look?
This is an automated message from the Apache Git Service.
To respond to the
chia7712 commented on pull request #8978:
URL: https://github.com/apache/kafka/pull/8978#issuecomment-666943950
@kkonstantine Could you please take a look?
This is an automated message from the Apache Git Service.
To respond
inponomarev edited a comment on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-666749809
⚠️ Two differences with KIP specification, discussion needed⚠️
1. Instead of multiple overloaded variants of `Branched.with` we now have
`Branched.withFunction`
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-667010664
The test failure is unrelated. It's
`org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest >
shouldUpgradeFromEosAlphaToEosBeta[true]` again
--
cadonna commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463514179
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -668,6 +671,9 @@ private void checkKeyValueStore
cadonna commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463514179
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -668,6 +671,9 @@ private void checkKeyValueStore
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r463578816
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/processor/MockProcessorContext.java
##
@@ -227,7 +228,8 @@ public MockProcessorCont
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r463617899
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,23 +181,39 @@ void openDB(final ProcessorContext
rajinisivaram commented on pull request #9092:
URL: https://github.com/apache/kafka/pull/9092#issuecomment-667147526
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log o
abbccdda commented on pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#issuecomment-667173698
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, p
hachikuji opened a new pull request #9109:
URL: https://github.com/apache/kafka/pull/9109
Add some notable changes to the reassignment tool for the 2.6 release.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test cover
abbccdda commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r463682515
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -4068,6 +4093,58 @@ public void testListOffsetsMetadata
rhauch commented on a change in pull request #9109:
URL: https://github.com/apache/kafka/pull/9109#discussion_r463705431
##
File path: docs/upgrade.html
##
@@ -49,6 +49,14 @@ Notable changes in 2
Fetch requests and other requests intended only for the leader or
follow
vvcephei commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-667212439
Sounds good, @guozhangwang . Another option is to make an internal config so
that we can parameterize the benchmarks and get a more thorough understanding
of the impact of this c
abbccdda commented on a change in pull request #9078:
URL: https://github.com/apache/kafka/pull/9078#discussion_r463708722
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java
##
@@ -272,8 +272,16 @@ public MBeanInfo getMBeanInfo() {
vvcephei edited a comment on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-667212439
Sounds good, @guozhangwang . Another option is to make an internal config so
that we can parameterize the benchmarks and get a more thorough understanding
of the impact of
abbccdda commented on a change in pull request #9105:
URL: https://github.com/apache/kafka/pull/9105#discussion_r463708981
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -197,8 +197,8 @@ synchronized boolean lock(fina
vvcephei merged pull request #8993:
URL: https://github.com/apache/kafka/pull/8993
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei commented on pull request #8993:
URL: https://github.com/apache/kafka/pull/8993#issuecomment-667214395
Thanks @guozhangwang ! I've merged to 2.5. If we do an 2.5.1RC1, it'll be
included. Otherwise, it'll go into 2.5.2. Either way, it will run as part of
nightly branch tests.
---
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-667233872
@chia7712 : So, it's just a rebase and there is no change in your PR?
This is an automated message from the Apache
hachikuji merged pull request #9109:
URL: https://github.com/apache/kafka/pull/9109
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
abbccdda commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-667241038
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463738138
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +313,96 @@ public void handleAssignment
ableegoldman commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463750941
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -668,6 +671,9 @@ private void checkKeyValue
ableegoldman commented on a change in pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#discussion_r463752139
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -144,15 +144,35 @@ private boolean a
guozhangwang commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-667297400
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-667297606
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
Johnny-Malizia commented on pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#issuecomment-667297977
Apologies for my inactivity here, I had to take a little more time to
understand how/when the index files are currently being opened. I'll try to
have this resolved sometim
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463780418
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +313,96 @@ public void handleAssignment
ableegoldman commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-667306865
Kicked off system tests
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4080/
This is an a
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463790190
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +313,96 @@ public void handleAssignment
vvcephei commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-667352270
Hey @mjsax , do you have time to give this a first pass?
This is an automated message from the Apache Git Service
rgroothuijsen commented on a change in pull request #9078:
URL: https://github.com/apache/kafka/pull/9078#discussion_r463845316
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java
##
@@ -272,8 +272,16 @@ public MBeanInfo getMBeanInfo() {
ableegoldman edited a comment on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-667306865
Kicked off system tests
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4081
This i
vvcephei commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463867098
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -461,6 +463,42 @@ public void flush() {
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463880076
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1215,71 @@ default AlterClientQuotasResult
alterClientQuotas(C
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-667442912
> So, it's just a rebase and there is no change in your PR?
The last change to this PR is to rename a class (according to @ijuma’s
comment)
--
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-667445902
`EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta` failed,
all other tests passed
This is an
ableegoldman commented on pull request #9024:
URL: https://github.com/apache/kafka/pull/9024#issuecomment-667447234
Ok I totally forgot about this PR.
Let's just merge the demotion of broker/zookeeper logs and leave streams
logs at INFO for now. If that's not sufficient for debugging
ableegoldman edited a comment on pull request #9024:
URL: https://github.com/apache/kafka/pull/9024#issuecomment-667447234
Ok I totally forgot about this PR.
@guozhangwang @mjsax Let's just merge the demotion of broker/zookeeper logs
and leave streams logs at INFO for now. If that's
dhruvilshah3 opened a new pull request #9110:
URL: https://github.com/apache/kafka/pull/9110
This PR improves the logging for segment deletion to ensure that a reason is
logged for every segment that is deleted.
This is an a
dhruvilshah3 commented on pull request #8850:
URL: https://github.com/apache/kafka/pull/8850#issuecomment-667454222
I attempted to improve the logging further. This also removes the side
effect of logging as part of evaluating the predicate.
https://github.com/apache/kafka/pull/9110
chia7712 commented on pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#issuecomment-667456986
> Are there any serde use cases that require client id?
I observed this issue when we are removing custom client id config. It
causes error as the metrics of our serde is e
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463912157
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4052,6 +4058,128 @@ void handleFailure(Throwable throwable)
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463912498
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/FeatureUpdateFailedException.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Sof
kowshik commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r463914087
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File,
* @param segments The log s
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463912498
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/FeatureUpdateFailedException.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Sof
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463915406
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1647,6 +1844,188 @@ class KafkaController(val config: KafkaConfig,
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463915553
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -266,6 +275,178 @@ class KafkaController(val config: KafkaConfig,
}
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916219
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -3615,6 +3662,137 @@ public void testListOffsetsNonRetri
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916470
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softwar
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916688
##
File path:
clients/src/main/resources/common/message/UpdateFinalizedFeaturesResponse.json
##
@@ -0,0 +1,28 @@
+// Licensed to the Apache Software Founda
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916610
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -983,8 +1144,25 @@ class KafkaController(val config: KafkaConfig,
*/
p
albert02lowis commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-667462930
Hi, there's another unit test that need to be moved out
(`StreamStreamJoinIntegrationTest.shouldNotAccessJoinStoresWhenGivingName`) but
I thought of doing that in another PR
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916470
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softwar
abbccdda commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-667466886
@albert02lowis I see, let's try to do all of them in one PR then.
This is an automated message from the Apache Gi
abbccdda commented on a change in pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#discussion_r463920622
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -228,6 +228,13 @@ public Password getPassword(String key) {
chia7712 commented on pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#issuecomment-667482560
> Btw, I don't think this is an improvement rather than a bug, as we don't
have any guarantee to see client id in serdes before.
There is another reason. We do pass generat
chia7712 commented on a change in pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#discussion_r463930430
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -228,6 +228,13 @@ public Password getPassword(String key) {
dongjinleekr commented on pull request #9007:
URL: https://github.com/apache/kafka/pull/9007#issuecomment-667483663
@tombentley Congratulations! :congratulations: @omkreddy @mimaison Thanks
again for the detailed review, as usual! :smiley:
kowshik commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r463914087
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File,
* @param segments The log s
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463934710
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -266,6 +275,179 @@ class KafkaController(val config: KafkaConfig,
}
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463934948
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1395,7 +1596,7 @@ class KafkaController(val config: KafkaConfig,
if (ne
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463935718
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1647,6 +1844,185 @@ class KafkaController(val config: KafkaConfig,
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463936048
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1647,6 +1844,185 @@ class KafkaController(val config: KafkaConfig,
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463936098
##
File path: core/src/main/scala/kafka/server/BrokerFeatures.scala
##
@@ -0,0 +1,178 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463936412
##
File path: core/src/main/scala/kafka/server/FinalizedFeatureCache.scala
##
@@ -82,18 +108,54 @@ object FinalizedFeatureCache extends Logging {
"
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463937032
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -109,7 +109,9 @@ class KafkaApis(val requestChannel: RequestChannel,
b
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463937184
##
File path: core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala
##
@@ -0,0 +1,550 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463935718
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1647,6 +1844,185 @@ class KafkaController(val config: KafkaConfig,
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463935718
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1647,6 +1844,185 @@ class KafkaController(val config: KafkaConfig,
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463936098
##
File path: core/src/main/scala/kafka/server/BrokerFeatures.scala
##
@@ -0,0 +1,178 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
dhruvilshah3 commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r463975069
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File,
* @param segments The
ijuma commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r463980962
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File,
* @param segments The log seg
ijuma commented on pull request #9070:
URL: https://github.com/apache/kafka/pull/9070#issuecomment-667595437
Nice improvement!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ijuma commented on a change in pull request #5374:
URL: https://github.com/apache/kafka/pull/5374#discussion_r464007379
##
File path: release.py
##
@@ -479,16 +479,16 @@ def select_gpg_key():
for root, dirs, files in os.walk(artifacts_dir):
assert root.startswith(artifact
rhauch commented on pull request #9070:
URL: https://github.com/apache/kafka/pull/9070#issuecomment-667606488
Agreed! This significantly sped up putting together 2.6.0RC2.
On Sat, Aug 1, 2020 at 5:35 PM Ismael Juma wrote:
> Nice improvement!
>
> —
> You are receiving
thomaslee opened a new pull request #9111:
URL: https://github.com/apache/kafka/pull/9111
The contract for `commitSync()` guarantees that the callbacks for all
prior async commits will be invoked before it (successfully?) returns.
Prior to this change the contract could be violated if
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r462738230
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java
##
@@ -85,11 +89,12 @@ public ApiKeys apiKey() {
public RequestHeader
abbccdda commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r464040484
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java
##
@@ -71,21 +73,20 @@
private final S
ijuma commented on pull request #8399:
URL: https://github.com/apache/kafka/pull/8399#issuecomment-667686748
@soenkeliebau did you file the JIRA @junrao mentioned above? It would be
good to reference it here.
This is an auto
ijuma closed pull request #1417:
URL: https://github.com/apache/kafka/pull/1417
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #1417:
URL: https://github.com/apache/kafka/pull/1417#issuecomment-667686994
Superseded by #8399.
This is an automated message from the Apache Git Service.
To respond to the message, please log
dhruvilshah3 commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r464100823
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File,
* @param segments The
RamanVerma opened a new pull request #9112:
URL: https://github.com/apache/kafka/pull/9112
MetadataCache#getPartitionMetadata returns an error when the topic's leader
Id
is present at MetadataCache but listener endpoint is not present for this
leader.
For older version, LEADER_NOT_AV
RamanVerma commented on pull request #9112:
URL: https://github.com/apache/kafka/pull/9112#issuecomment-667719141
Ran `./gradlew core:test` locally. All tests passed.
This is an automated message from the Apache Git Service.
RamanVerma commented on pull request #9112:
URL: https://github.com/apache/kafka/pull/9112#issuecomment-667719404
cc @hachikuji
Not sure why I am not able to add anyone as a reviewer to the PR. I am not
getting the add reviewers/recommended reviewers options.
-
guozhangwang commented on pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#issuecomment-667734629
This change makes sense to me, thanks @chia7712
One (very) minor thing is that, `enableAutoCommit` may also be overridden
when passing into the coordinator object, i.e
showuon commented on pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#issuecomment-667784086
Thanks @ableegoldman . I've updated based on your suggestion. Thanks.
This is an automated message from the Apache
abbccdda commented on pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#issuecomment-667819088
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chia7712 commented on pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#issuecomment-667819033
@guozhangwang thanks for reviews
> One (very) minor thing is that, may also be overridden when passing into
the coordinator object, i.e. the value read from ConsumerConfig
kowshik commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r464213840
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,13 +2210,16 @@ class Log(@volatile private var _dir: File,
* @param segments The log s
highluck commented on a change in pull request #9105:
URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -197,8 +197,8 @@ synchronized boolean lock(fina
301 - 400 of 51557 matches
Mail list logo
