hachikuji commented on a change in pull request #8891:
URL: https://github.com/apache/kafka/pull/8891#discussion_r463396781
##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -647,8 +647,14 @@ class KafkaController(val config: KafkaConfig,
info(s"Skipping reassignment of $tp since the topic is currently being
deleted")
new ApiError(Errors.UNKNOWN_TOPIC_OR_PARTITION, "The partition does
not exist.")
} else {
- val assignedReplicas = controllerContext.partitionReplicaAssignment(tp)
- if (assignedReplicas.nonEmpty) {
+ val assignment = controllerContext.partitionFullReplicaAssignment(tp)
+ if (assignment == ReplicaAssignment.empty) {
+ new ApiError(Errors.UNKNOWN_TOPIC_OR_PARTITION, "The partition does
not exist.")
+ } else if (assignment == reassignment) {
Review comment:
I ended up reverting this change because the controller integration
tests were failing. I'll consider opening a separate jira for the problem of
avoiding the epoch bump when the reassignment does not change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
