[GitHub] [kafka] showuon commented on pull request #9179: KAFKA-10390: Remove ignore case option when grep process info to be more specific

2020-08-13 Thread GitBox
showuon commented on pull request #9179: URL: https://github.com/apache/kafka/pull/9179#issuecomment-673858393 @cmccabe @lbradstreet , could you help review this small PR? Thanks. This is an automated message from the Apache

[GitHub] [kafka] showuon edited a comment on pull request #9175: KAFKA-8362: Fix the old checkpoint data won't be removed after alter log dir

2020-08-13 Thread GitBox
showuon edited a comment on pull request #9175: URL: https://github.com/apache/kafka/pull/9175#issuecomment-673423404 @showuon , could you help review this PR? Thanks. This is an automated message from the Apache Git Service.

[GitHub] [kafka] showuon commented on pull request #9175: KAFKA-8362: Fix the old checkpoint data won't be removed after alter log dir

2020-08-13 Thread GitBox
showuon commented on pull request #9175: URL: https://github.com/apache/kafka/pull/9175#issuecomment-673860247 @showuon hellp This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-14 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-673942147 only ```shouldUpgradeFromEosAlphaToEosBeta``` fails. retest this please This is an automated message from the Apa

[GitHub] [kafka] jeqo commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-14 Thread GitBox
jeqo commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r470536034 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java ## @@ -188,7 +188,55 @@ public void testPutGetRang

[GitHub] [kafka] sanketfajage opened a new pull request #9180: MINOR: corrected unit tests

2020-08-14 Thread GitBox
sanketfajage opened a new pull request #9180: URL: https://github.com/apache/kafka/pull/9180 Corrected unit tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-14 Thread GitBox
bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-674091814 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-14 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470673412 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-14 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470675300 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-14 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470678123 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -255,6 +255,10 @@ class Partition(val topicPartition: TopicPartition, def isAdding

[GitHub] [kafka] rajinisivaram opened a new pull request #9181: KAFKA-9516; Increase timeout in testNonBlockingProducer to make it more reliable

2020-08-14 Thread GitBox
rajinisivaram opened a new pull request #9181: URL: https://github.com/apache/kafka/pull/9181 The test has been timing out occasionally and it is on the first send on a producer, so increasing timeout to 30s similar to some of the other timeouts in BaseProducerSendTest. ### Committe

[GitHub] [kafka] chia7712 opened a new pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-08-14 Thread GitBox
chia7712 opened a new pull request #9182: URL: https://github.com/apache/kafka/pull/9182 issue: https://issues.apache.org/jira/browse/KAFKA-10403 It seems to me the metrics is a "kind" of public interface so users should be able to access metrics of kafka server without scala library

[GitHub] [kafka] ijuma commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-08-14 Thread GitBox
ijuma commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-674160788 Can you please include more detail on how it fails currently? I assume it's some kind of deserialization error? Thi

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-14 Thread GitBox
bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-674162578 Java 8 failed on an unrelated test `kafka.api.SaslSslConsumerTest.testCoordinatorFailover` created a Jira ticket. retest this please --

[GitHub] [kafka] rajinisivaram opened a new pull request #9183: KAFKA-10404; Use higher poll timeout to avoid rebalance in testCoordinatorFailover

2020-08-14 Thread GitBox
rajinisivaram opened a new pull request #9183: URL: https://github.com/apache/kafka/pull/9183 Tests use 6s poll timeout, which isn't sufficient to ensure that clients don't leave the group due to poll timeout. The PR increases poll timeout to 15s. Session timeout of 5s is also low, but lea

[GitHub] [kafka] ijuma commented on pull request #9067: MINOR: Streams integration tests should not call exit

2020-08-14 Thread GitBox
ijuma commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-674193106 @mjsax did you run checkstyle and spotBugs before pushing the 2.6 change? It seems like it broke the build: https://ci-builds.apache.org/job/Kafka/job/kafka-2.6-jdk8/3/console

[GitHub] [kafka] rajinisivaram opened a new pull request #9184: KAFKA-8033; Wait for NoOffsetForPartitionException in testFetchInvalidOffset

2020-08-14 Thread GitBox
rajinisivaram opened a new pull request #9184: URL: https://github.com/apache/kafka/pull/9184 We wait only 50ms in consumer.poll() and expect NoOffsetForPartitionException, but the exception is thrown only when initializing partition offsets after coordinator is known. Increased poll time

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-14 Thread GitBox
bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-674229113 Java 8 passed Java 14 failed with `org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState` Java 11 failed with `kafka.api.PlaintextAdmi

[GitHub] [kafka] ijuma commented on pull request #9180: MINOR: corrected unit tests

2020-08-14 Thread GitBox
ijuma commented on pull request #9180: URL: https://github.com/apache/kafka/pull/9180#issuecomment-674304221 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] chia7712 commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-08-15 Thread GitBox
chia7712 commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-674370125 > Can you please include more detail on how it fails currently? I assume it's some kind of deserialization error? You are right. The root cause is deserialization error. Cu

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-15 Thread GitBox
bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-674393672 Java 11 passed Java 14 failed due to ` Execution failed for task ':connect:api:javadoc'.` ? (0 tests failed Java 8 appears hung Trying this one more time retest thi

[GitHub] [kafka] chia7712 opened a new pull request #9185: MINOR: use the link of JDK 11 to replace the dynamic url when buildin…

2020-08-15 Thread GitBox
chia7712 opened a new pull request #9185: URL: https://github.com/apache/kafka/pull/9185 The official supported JDKs are 8 and 11 so we should only expose static API link of either JDK 8 or JDK 11. For example, the exposed API link is JDK 11 even if the JDK version used to build kafka is 1

[GitHub] [kafka] chia7712 commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-08-15 Thread GitBox
chia7712 commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-674414560 ```javadoc: error - Error fetching URL: https://docs.oracle.com/en/java/javase/15/docs/api/``` The link of API is a bit weird to me. I have filed #9185 to fix it. ---

[GitHub] [kafka] bbejeck merged pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-15 Thread GitBox
bbejeck merged pull request #9108: URL: https://github.com/apache/kafka/pull/9108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-15 Thread GitBox
bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-674419779 merged #9108 into trunk Thanks for the contribution @albert02lowis! This is an automated message from the A

[GitHub] [kafka] albert02lowis commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-15 Thread GitBox
albert02lowis commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-674421636 Thanks for the reviews too @bbejeck and @abbccdda ! Really excited as this is my first contribution 🙏🏻 Thi

[GitHub] [kafka] stanislavkozlovski commented on pull request #6669: KAFKA-8238: Adding Number of messages/bytes read

2020-08-16 Thread GitBox
stanislavkozlovski commented on pull request #6669: URL: https://github.com/apache/kafka/pull/6669#issuecomment-674497333 Hey there @vamossagar12, are you still working on this PR? This is an automated message from the Apache

[GitHub] [kafka] JoelWee opened a new pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-16 Thread GitBox
JoelWee opened a new pull request #9186: URL: https://github.com/apache/kafka/pull/9186 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] JoelWee commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-16 Thread GitBox
JoelWee commented on pull request #9186: URL: https://github.com/apache/kafka/pull/9186#issuecomment-674500361 [KAFKA-10277](https://issues.apache.org/jira/browse/KAFKA-10277?jql=project%20%3D%20KAFKA%20AND%20labels%20%3D%20newbie%20AND%20status%20%3D%20Open%20ORDER%20BY%20updated%20DESC)

[GitHub] [kafka] rajinisivaram commented on pull request #9181: KAFKA-9516; Increase timeout in testNonBlockingProducer to make it more reliable

2020-08-16 Thread GitBox
rajinisivaram commented on pull request #9181: URL: https://github.com/apache/kafka/pull/9181#issuecomment-674503723 @ijuma Thanks for the review, merging to trunk, 2.6 and 2.5. This is an automated message from the Apache Gi

[GitHub] [kafka] rajinisivaram merged pull request #9181: KAFKA-9516; Increase timeout in testNonBlockingProducer to make it more reliable

2020-08-16 Thread GitBox
rajinisivaram merged pull request #9181: URL: https://github.com/apache/kafka/pull/9181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #9184: KAFKA-8033; Wait for NoOffsetForPartitionException in testFetchInvalidOffset

2020-08-16 Thread GitBox
rajinisivaram commented on pull request #9184: URL: https://github.com/apache/kafka/pull/9184#issuecomment-674505814 @ijuma Thanks for the review. Yes, NoOffsetForPartitionException continues to be thrown as soon as possible, typically less than 50ms. Merging to trunk, 2.6 and 2.5. -

[GitHub] [kafka] rajinisivaram merged pull request #9184: KAFKA-8033; Wait for NoOffsetForPartitionException in testFetchInvalidOffset

2020-08-16 Thread GitBox
rajinisivaram merged pull request #9184: URL: https://github.com/apache/kafka/pull/9184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer

2020-08-16 Thread GitBox
rajinisivaram commented on pull request #9143: URL: https://github.com/apache/kafka/pull/9143#issuecomment-674507951 @skaundinya15 Thanks for running the tests, merging to trunk. This is an automated message from the Apache G

[GitHub] [kafka] rajinisivaram merged pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer

2020-08-16 Thread GitBox
rajinisivaram merged pull request #9143: URL: https://github.com/apache/kafka/pull/9143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9142: MINOR: Fix delete_topic for system tests

2020-08-16 Thread GitBox
rajinisivaram commented on a change in pull request #9142: URL: https://github.com/apache/kafka/pull/9142#discussion_r471094493 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None, use_zk_to_create_topic=True

[GitHub] [kafka] rajinisivaram commented on pull request #9183: KAFKA-10404; Use higher poll timeout to avoid rebalance in testCoordinatorFailover

2020-08-16 Thread GitBox
rajinisivaram commented on pull request #9183: URL: https://github.com/apache/kafka/pull/9183#issuecomment-674528245 @omkreddy Thanks for the review, merging to trunk, 2.6 and 2.5. This is an automated message from the Apache

[GitHub] [kafka] rajinisivaram merged pull request #9183: KAFKA-10404; Use higher poll timeout to avoid rebalance in testCoordinatorFailover

2020-08-16 Thread GitBox
rajinisivaram merged pull request #9183: URL: https://github.com/apache/kafka/pull/9183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-16 Thread GitBox
rajinisivaram commented on pull request #8768: URL: https://github.com/apache/kafka/pull/8768#issuecomment-674533627 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] vamossagar12 commented on pull request #6669: KAFKA-8238: Adding Number of messages/bytes read

2020-08-16 Thread GitBox
vamossagar12 commented on pull request #6669: URL: https://github.com/apache/kafka/pull/6669#issuecomment-674534010 > Hey there @vamossagar12, are you still working on this PR? hey @stanislavkozlovski I think I had made some final changes but couldn't get past the final review(I sho

[GitHub] [kafka] lbradstreet opened a new pull request #9187: MINOR: bump mockito to 3.5.0

2020-08-16 Thread GitBox
lbradstreet opened a new pull request #9187: URL: https://github.com/apache/kafka/pull/9187 3.5.0 no longer uses any reflection and is backwards compatible. The lack of reflection could be helpful when writing jmh benchmark tests as often these mocks can completely throw off benchmark resu

[GitHub] [kafka] lbradstreet commented on pull request #9187: MINOR: bump mockito to 3.5.0

2020-08-16 Thread GitBox
lbradstreet commented on pull request #9187: URL: https://github.com/apache/kafka/pull/9187#issuecomment-674551252 I thought this might be useful for jmh benchmarks as reflection can often throw us off. I'm not sure we use the inline mock maker anywhere though. ---

[GitHub] [kafka] rajinisivaram commented on pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-16 Thread GitBox
rajinisivaram commented on pull request #8768: URL: https://github.com/apache/kafka/pull/8768#issuecomment-674554549 @apovzner DynamicBrokerReconfigurationTest.testAddRemoveSaslListeners failed in all three PR builds, so probably related? ``` 15:55:45 kafka.server.DynamicBrokerReconfi

[GitHub] [kafka] huxihx commented on pull request #7711: KAFKA-9157: Avoid generating empty segments if all records are deleted after cleaning

2020-08-16 Thread GitBox
huxihx commented on pull request #7711: URL: https://github.com/apache/kafka/pull/7711#issuecomment-674612527 @junrao Could you take some time to review this patch? Thanks :) This is an automated message from the Apache Git S

[GitHub] [kafka] Spatterjaaay opened a new pull request #9188: break when dst is full so that unwrap isn't called when appreadbuffer…

2020-08-16 Thread GitBox
Spatterjaaay opened a new pull request #9188: URL: https://github.com/apache/kafka/pull/9188 … may have data There are a couple of different situations which can result in BUFFER_OVERFLOW on read with the current implementation, due to the while loop structure (such as TLS compr

[GitHub] [kafka] huxihx opened a new pull request #9189: Kafka 10407: Have KafkaLog4jAppender support `linger.ms` and `batch.size`

2020-08-16 Thread GitBox
huxihx opened a new pull request #9189: URL: https://github.com/apache/kafka/pull/9189 https://issues.apache.org/jira/browse/KAFKA-10407 Currently, KafkaLog4jAppender does not support `linger.ms` or `batch.size`. In some situations, those two parameters are good to tune the performan

[GitHub] [kafka] apovzner commented on pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-16 Thread GitBox
apovzner commented on pull request #8768: URL: https://github.com/apache/kafka/pull/8768#issuecomment-674639202 Hi @rajinisivaram, the test failure turned out to be a bug where I did not remove connection rate sensors on listener removal. I fixed the code and tests now pass.

[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-16 Thread GitBox
kkonstantine commented on pull request #9172: URL: https://github.com/apache/kafka/pull/9172#issuecomment-674644885 Thanks @rhauch ! Tested manually with transforms from the `plugin.path` as well. Merging on `trunk` and backporting to `2.6`. -

[GitHub] [kafka] kkonstantine edited a comment on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-16 Thread GitBox
kkonstantine edited a comment on pull request #9172: URL: https://github.com/apache/kafka/pull/9172#issuecomment-674644885 Thanks @rhauch ! Tested manually with transforms from the `plugin.path` as well. Merging on `trunk` and backporting to `2.6`. (2/3 builds were green) ---

[GitHub] [kafka] kkonstantine merged pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-16 Thread GitBox
kkonstantine merged pull request #9172: URL: https://github.com/apache/kafka/pull/9172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] carlos-verdes commented on pull request #9176: Allow replace all for RegexRouter

2020-08-16 Thread GitBox
carlos-verdes commented on pull request #9176: URL: https://github.com/apache/kafka/pull/9176#issuecomment-674684857 @kkonstantine can you help me with this PR or point to me to someone who can help? I really would appreciate :) -

[GitHub] [kafka] jwijgerd opened a new pull request #9190: 2.5.x rebase from upstream

2020-08-17 Thread GitBox
jwijgerd opened a new pull request #9190: URL: https://github.com/apache/kafka/pull/9190 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] jwijgerd closed pull request #9190: 2.5.x rebase from upstream

2020-08-17 Thread GitBox
jwijgerd closed pull request #9190: URL: https://github.com/apache/kafka/pull/9190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] rajinisivaram commented on pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-17 Thread GitBox
rajinisivaram commented on pull request #8768: URL: https://github.com/apache/kafka/pull/8768#issuecomment-674767765 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] rajinisivaram commented on pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-17 Thread GitBox
rajinisivaram commented on pull request #8768: URL: https://github.com/apache/kafka/pull/8768#issuecomment-674768235 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] rajinisivaram commented on pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-17 Thread GitBox
rajinisivaram commented on pull request #8768: URL: https://github.com/apache/kafka/pull/8768#issuecomment-674769912 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] dongjinleekr commented on pull request #9189: KAFKA-10407: Have KafkaLog4jAppender support `linger.ms` and `batch.size`

2020-08-17 Thread GitBox
dongjinleekr commented on pull request #9189: URL: https://github.com/apache/kafka/pull/9189#issuecomment-674807281 Hi @huxihx, It seems like this feature requires a KIP. Isn't it? This is an automated message from the

[GitHub] [kafka] huxihx commented on pull request #9189: KAFKA-10407: Have KafkaLog4jAppender support `linger.ms` and `batch.size`

2020-08-17 Thread GitBox
huxihx commented on pull request #9189: URL: https://github.com/apache/kafka/pull/9189#issuecomment-674828127 @dongjinleekr Thanks for the comments. I think it needs no KIP for this patch, since it does not break any compatibility. It's totally okay for you not to specify them when using K

[GitHub] [kafka] jeqo commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-17 Thread GitBox
jeqo commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r471449807 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java ## @@ -374,7 +412,7 @@ public Bytes peekNextKey() {

[GitHub] [kafka] jeqo commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-17 Thread GitBox
jeqo commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r471451498 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java ## @@ -374,7 +412,7 @@ public Bytes peekNextKey() {

[GitHub] [kafka] jeqo commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-17 Thread GitBox
jeqo commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r471459574 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java ## @@ -188,7 +188,55 @@ public void testPutGetRang

[GitHub] [kafka] rajinisivaram commented on pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-17 Thread GitBox
rajinisivaram commented on pull request #8768: URL: https://github.com/apache/kafka/pull/8768#issuecomment-674884255 @apovzner Thanks for the updates, LGTM. Merging to trunk. This is an automated message from the Apache Git S

[GitHub] [kafka] rajinisivaram merged pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-17 Thread GitBox
rajinisivaram merged pull request #8768: URL: https://github.com/apache/kafka/pull/8768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dongjinleekr commented on pull request #9189: KAFKA-10407: Have KafkaLog4jAppender support `linger.ms` and `batch.size`

2020-08-17 Thread GitBox
dongjinleekr commented on pull request #9189: URL: https://github.com/apache/kafka/pull/9189#issuecomment-674898490 @huxihx > Besides, deliveryTimeoutMs is added by #5425 without any KIP covered. Great! It perfectly makes sense. --

[GitHub] [kafka] vvcephei closed pull request #9074: KAFKA-10287: PROPOSAL: safe offset tracking

2020-08-17 Thread GitBox
vvcephei closed pull request #9074: URL: https://github.com/apache/kafka/pull/9074 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] cadonna opened a new pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-17 Thread GitBox
cadonna opened a new pull request #9191: URL: https://github.com/apache/kafka/pull/9191 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade not

[GitHub] [kafka] cadonna commented on pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-17 Thread GitBox
cadonna commented on pull request #9191: URL: https://github.com/apache/kafka/pull/9191#issuecomment-674933287 FYI: @guozhangwang @ableegoldman @vvcephei @mjsax @abbccdda This is an automated message from the Apache Git Serv

[GitHub] [kafka] astubbs commented on pull request #9031: KAFKA-10298: replace abstract Windows with a proper interface

2020-08-17 Thread GitBox
astubbs commented on pull request #9031: URL: https://github.com/apache/kafka/pull/9031#issuecomment-674942888 Jira: https://issues.apache.org/jira/browse/KAFKA-10298 This is an automated message from the Apache Git Service.

[GitHub] [kafka] astubbs edited a comment on pull request #9031: KAFKA-10298: replace abstract Windows with a proper interface

2020-08-17 Thread GitBox
astubbs edited a comment on pull request #9031: URL: https://github.com/apache/kafka/pull/9031#issuecomment-674942888 Jira: https://issues.apache.org/jira/browse/KAFKA-10298 KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-645%3A+Replace+Windows+with+a+proper+interface --

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-17 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-674954410 JDK 8 and Scala 1.12 had following test failures: ``` org.apache.kafka.connect.runtime.WorkerSourceTaskWithTopicCreationTest.testCommitFailure kafka.api.Plaint

[GitHub] [kafka] cwildman commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-08-17 Thread GitBox
cwildman commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-674974228 Noticed this didn't make the 2.6 release. Would it be possible to backport this to older 2.x versions? Or is 2.6.1 coming soon? Dealing with some environments with bad settings f

[GitHub] [kafka] vvcephei commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-17 Thread GitBox
vvcephei commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r471582580 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -415,9 +416,40 @@ public final Sens

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-17 Thread GitBox
junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r471627837 ## File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] ableegoldman commented on a change in pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-17 Thread GitBox
ableegoldman commented on a change in pull request #9191: URL: https://github.com/apache/kafka/pull/9191#discussion_r471696179 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apach

[GitHub] [kafka] andrewegel opened a new pull request #9192: MINOR: Use new version of ducktape

2020-08-17 Thread GitBox
andrewegel opened a new pull request #9192: URL: https://github.com/apache/kafka/pull/9192 - bcrypt (a dependency of ducktape) dropped Python2.7 support. ducktape-0.7.9 now pins bcrypt to a Python2.7-supported version. *More detailed description of your change, if necessary. The

[GitHub] [kafka] chrisbeard opened a new pull request #9193: KAFKA-10281: [WIP] Add log compression analysis tool KIP-640

2020-08-17 Thread GitBox
chrisbeard opened a new pull request #9193: URL: https://github.com/apache/kafka/pull/9193 This is a starting point for the implementation of the tool proposed in [KIP-640](https://cwiki.apache.org/confluence/display/KAFKA/KIP-640%3A+Add+log+compression+analysis+tool). I consider thi

[GitHub] [kafka] soarez commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-17 Thread GitBox
soarez commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-675134899 Pinging @mjsax. Don't forget to review this. This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] soarez commented on pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

2020-08-17 Thread GitBox
soarez commented on pull request #9064: URL: https://github.com/apache/kafka/pull/9064#issuecomment-675135083 Ping @mjsax - a reminder to review this This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-17 Thread GitBox
junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r471806378 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -977,14 +1179,30 @@ class KafkaController(val config: KafkaConfig, /**

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-17 Thread GitBox
ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r471798256 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,301 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-17 Thread GitBox
ableegoldman commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r471836789 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java ## @@ -188,7 +188,55 @@ public void testPu

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

2020-08-17 Thread GitBox
dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r466653159 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -504,6 +515,7 @@ public void onSuccess(Byt

[GitHub] [kafka] cmccabe opened a new pull request #9194: KAFKA-10384: Separate converters from generated messages

2020-08-17 Thread GitBox
cmccabe opened a new pull request #9194: URL: https://github.com/apache/kafka/pull/9194 For the generated message code, put the JSON conversion functionality in a separate JsonConverter class. Make MessageDataGenerator simply another generator class, alongside the new JsonConver

[GitHub] [kafka] omkreddy closed pull request #9192: MINOR: Use new version of ducktape

2020-08-17 Thread GitBox
omkreddy closed pull request #9192: URL: https://github.com/apache/kafka/pull/9192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] omkreddy commented on pull request #9192: MINOR: Use new version of ducktape

2020-08-17 Thread GitBox
omkreddy commented on pull request #9192: URL: https://github.com/apache/kafka/pull/9192#issuecomment-675202022 Merged to trunk, 2.6, 2.5, 2.4 branches. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] omkreddy edited a comment on pull request #9192: MINOR: Use new version of ducktape

2020-08-17 Thread GitBox
omkreddy edited a comment on pull request #9192: URL: https://github.com/apache/kafka/pull/9192#issuecomment-675202022 Merged to trunk and all the branches upto 1.0. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] kkonstantine commented on pull request #9176: Allow replace all for RegexRouter

2020-08-17 Thread GitBox
kkonstantine commented on pull request #9176: URL: https://github.com/apache/kafka/pull/9176#issuecomment-675264751 Thanks @carlos-verdes I'll try to take a look within the next couple of weeks (taking some time off in the meantime). Without commenting on the approach yet, I'm p

[GitHub] [kafka] chia7712 commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-08-18 Thread GitBox
chia7712 commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-675344226 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-18 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-67533 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] Sasilekha opened a new pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer

2020-08-18 Thread GitBox
Sasilekha opened a new pull request #9195: URL: https://github.com/apache/kafka/pull/9195 In NioEchoServer the enum has its constructor declared as private, which is redundant. We can remove this. public class NioEchoServer extends Thread { public enum MetricType {

[GitHub] [kafka] Sasilekha commented on pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer

2020-08-18 Thread GitBox
Sasilekha commented on pull request #9195: URL: https://github.com/apache/kafka/pull/9195#issuecomment-675358144 Hi @ notifygd Can you please review? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] stanislavkozlovski commented on pull request #6669: KAFKA-8238: Adding Number of messages/bytes read

2020-08-18 Thread GitBox
stanislavkozlovski commented on pull request #6669: URL: https://github.com/apache/kafka/pull/6669#issuecomment-675358064 Yeah, that'd be awesome! This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] jeqo commented on pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-18 Thread GitBox
jeqo commented on pull request #9138: URL: https://github.com/apache/kafka/pull/9138#issuecomment-675384593 @ableegoldman, this PR is ready for review 👍 This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] nizhikov opened a new pull request #9196: KAFKA-10402: Upgrade system tests to python3

2020-08-18 Thread GitBox
nizhikov opened a new pull request #9196: URL: https://github.com/apache/kafka/pull/9196 For now, Kafka system tests use python2 which is outdated and not supported. This PR upgrades python to the third version. ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] cadonna commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r472100951 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorder.java ## @@ -56,6 +62,9 @@ public void maybeClos

[GitHub] [kafka] rhauch commented on pull request #9176: Allow replace all for RegexRouter

2020-08-18 Thread GitBox
rhauch commented on pull request #9176: URL: https://github.com/apache/kafka/pull/9176#issuecomment-675475664 @kkonstantine is correct that this changes the public API and therefore requires a KIP. Please also create a Jira issue, and change the title of this PR so that it starts w

[GitHub] [kafka] cadonna commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r472200360 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -415,9 +416,40 @@ public final Senso

[GitHub] [kafka] cadonna commented on a change in pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9191: URL: https://github.com/apache/kafka/pull/9191#discussion_r472217989 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cadonna commented on a change in pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9191: URL: https://github.com/apache/kafka/pull/9191#discussion_r472228811 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] vvcephei commented on a change in pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

2020-08-18 Thread GitBox
vvcephei commented on a change in pull request #9174: URL: https://github.com/apache/kafka/pull/9174#discussion_r472242890 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -805,10 +805,10 @@ public void advanceWallClockTime(

<    8   9   10   11   12   13   14   15   16   17   >