Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-06-13 Thread via GitHub
OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2970470301 > I am wondering if we should include topicId in recordsByPartition in sendProduceRequest(). This way, we don't need to check metadata for topicId since it could change over time.

[jira] [Resolved] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-06-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-18729. Resolution: Fixed > Improve consumer check for assigned topics from regex > --

[jira] [Commented] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-06-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17973503#comment-17973503 ] Lianet Magrans commented on KAFKA-18729: Hey [~m1a2st], this ended up fixed by K

[jira] [Created] (KAFKA-19407) OffsetsOutOfOrderException on followers due to the race condition in the leader

2025-06-13 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-19407: Summary: OffsetsOutOfOrderException on followers due to the race condition in the leader Key: KAFKA-19407 URL: https://issues.apache.org/jira/browse/KAFKA-19407 Proje

Re: [PR] KAFKA-18193 Refactor Kafka Streams CloseOptions to Fluent API Style [kafka]

2025-06-13 Thread via GitHub
m1a2st commented on PR #19955: URL: https://github.com/apache/kafka/pull/19955#issuecomment-2970549653 This KIP has passed. [LINK](https://lists.apache.org/thread/40w9kvd6o80nl2qbsl2lg9s2zl4oldtk) -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] KAFKA-19168: MirrorMaker kafka_metrics_count metric is always incorrect [kafka]

2025-06-13 Thread via GitHub
Yunyung commented on PR #19573: URL: https://github.com/apache/kafka/pull/19573#issuecomment-2970556035 > In the Jira I suggested using the connector instance name and the task number. This should be unique in a Connect cluster. Hi @mimaison, what I meant above is: Cluster A -> B creates

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145226103 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Softwar

[jira] [Updated] (KAFKA-19407) OffsetsOutOfOrderException on followers due to the race condition in the leader

2025-06-13 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-19407: - Description: h2. Environment * Kafka version: 3.3.2 (But we suppose this issue still exists in

[PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-13 Thread via GitHub
OmniaGM opened a new pull request, #19964: URL: https://github.com/apache/kafka/pull/19964 - Metadata doesn't have the full view of topicNames to ids during rebootstrap of client or when topic has been deleted/recreated. The solution is to pass down topic id and stop trying to figure it out

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145495966 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] KAFKA-18486:Remove ReplicaManager#becomeLeaderOrFollower in `testVerificationErrorConversions` [kafka]

2025-06-13 Thread via GitHub
Yunyung commented on code in PR #19923: URL: https://github.com/apache/kafka/pull/19923#discussion_r2145732650 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2752,9 +2753,8 @@ class ReplicaManagerTest { val replicaManager = setUpReplicaManagerW

Re: [PR] KAFKA-18486:Remove ReplicaManager#becomeLeaderOrFollower in `testReplicaAlterLogDirs` [kafka]

2025-06-13 Thread via GitHub
Yunyung commented on code in PR #19922: URL: https://github.com/apache/kafka/pull/19922#discussion_r2145732147 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -5880,13 +5881,9 @@ class ReplicaManagerTest { topicId = None ) - val le

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-06-13 Thread via GitHub
OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2970615262 I have raised this https://github.com/apache/kafka/pull/19964 pr, trying to update `ProducerSendWhileDeletionTest` to cover this case better -- This is an automated message from the Apa

Re: [PR] KAFKA-18486:Remove ReplicaManager#becomeLeaderOrFollower in `testReplicaAlterLogDirs` [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on code in PR #19922: URL: https://github.com/apache/kafka/pull/19922#discussion_r2145771137 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -5880,13 +5881,9 @@ class ReplicaManagerTest { topicId = None ) - val l

Re: [PR] KAFKA-18486:Remove ReplicaManager#becomeLeaderOrFollower in `testVerificationErrorConversions` [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on PR #19923: URL: https://github.com/apache/kafka/pull/19923#issuecomment-2971199645 > I'll create a MINOR to fix it. @Yunyung yes, please file a minor to fix them -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] (wip )KAFKA-19042 consumer bounce test [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on code in PR #19822: URL: https://github.com/apache/kafka/pull/19822#discussion_r2145809584 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerBounceTest.java: ## @@ -0,0 +1,802 @@ +/* + * Licensed to the Apache Softw

[PR] KAFKA-18486: Migrate ReplicaManagerTest to use applyDelta [kafka]

2025-06-13 Thread via GitHub
Yunyung opened a new pull request, #19965: URL: https://github.com/apache/kafka/pull/19965 Change becomeLeaderOrFollower to applyDelta in following test cases: - testTransactionAddPartitionRetry - testTransactionVerificationBlocksOutOfOrderSequence - testTransactionVerificationDy

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
jolshan commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145501061 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14895: [2/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on code in PR #19933: URL: https://github.com/apache/kafka/pull/19933#discussion_r2145520517 ## server/src/main/java/org/apache/kafka/server/transaction/AddPartitionsToTxnManager.java: ## @@ -243,11 +243,10 @@ public void addOrVerifyTransaction(

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145528984 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
jolshan commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145501061 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-13 Thread via GitHub
lianetm commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2141084110 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -470,7 +475,19 @@ protected Map prepareFetchRequests() }

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
jolshan commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145476487 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-13 Thread via GitHub
lianetm commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2141104339 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -1135,7 +1134,9 @@ CompletableFuture revokePartitions(Set pa

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
jolshan commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145476487 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
jolshan commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145476487 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
jolshan commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145501061 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-19279: Make DefaultMessageFormatter public [kafka]

2025-06-13 Thread via GitHub
aniruddha-navare commented on PR #19785: URL: https://github.com/apache/kafka/pull/19785#issuecomment-2971030967 @kumarlokesh @Yunyung - Do we have any updates on this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-14895: [2/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-13 Thread via GitHub
brandboat commented on code in PR #19933: URL: https://github.com/apache/kafka/pull/19933#discussion_r2145579341 ## server/src/main/java/org/apache/kafka/server/transaction/AddPartitionsToTxnManager.java: ## @@ -243,11 +243,10 @@ public void addOrVerifyTransaction(

[jira] [Updated] (KAFKA-19407) OffsetsOutOfOrderException on followers due to the race condition in the leader

2025-06-13 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-19407: - Description: h2. Environment * Kafka version: 3.3.2 (But we suppose this issue still exists in

[jira] [Updated] (KAFKA-19407) OffsetsOutOfOrderException on followers due to the race condition in the leader

2025-06-13 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-19407: - Description: h2. Environment * Kafka version: 3.3.2 (But we suppose this issue still exists in

[jira] [Updated] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-06-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18729: --- Component/s: clients > Improve consumer check for assigned topics from regex > -

[jira] [Commented] (KAFKA-19397) TransactionManager.handleCompletedBatch throws NPE

2025-06-13 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17973501#comment-17973501 ] Lucas Brutschy commented on KAFKA-19397: Note that there is some further analysi

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2145528984 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache Softwar

[jira] [Comment Edited] (KAFKA-19397) TransactionManager.handleCompletedBatch throws NPE

2025-06-13 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17973501#comment-17973501 ] Lucas Brutschy edited comment on KAFKA-19397 at 6/13/25 1:41 PM: -

[jira] (KAFKA-19397) TransactionManager.handleCompletedBatch throws NPE

2025-06-13 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19397 ] Omnia Ibrahim deleted comment on KAFKA-19397: --- was (Author: omnia_h_ibrahim): [https://github.com/apache/kafka/pull/19964] > TransactionManager.handleCompletedBatch throws NPE > --

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146347071 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -555,21 +560,12 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146249146 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -555,21 +560,12 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on PR #19913: URL: https://github.com/apache/kafka/pull/19913#issuecomment-2971922729 One more side comments: if we want to reduce the size of this PR, we could also do a separate PR that only adds the new exception classes. It would just add some "dead code" until we use th

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146257048 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -461,15 +469,22 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146244267 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -555,21 +560,12 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146256034 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -90,6 +92,8 @@ public InternalTopicManager(final Time time,

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146261373 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -461,15 +469,22 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146260537 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -74,11 +76,14 @@ public class InternalTopicManager { private

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146261373 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -461,15 +469,22 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146263823 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -461,15 +469,22 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
mjsax commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146265222 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -555,21 +560,12 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146341727 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -555,21 +560,12 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2146343971 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -90,6 +92,8 @@ public InternalTopicManager(final Time time,

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
k-apol commented on PR #19913: URL: https://github.com/apache/kafka/pull/19913#issuecomment-2972089424 > One more side comments: if we want to reduce the size of this PR, we could also do a separate PR that only adds the new exception classes. It would just add some "dead code" until we use

[PR] KAFKA-1940: Remove BrokerTopicStats#removeOldFollowerMetrics [kafka]

2025-06-13 Thread via GitHub
gongxuanzhang opened a new pull request, #19962: URL: https://github.com/apache/kafka/pull/19962 about https://issues.apache.org/jira/browse/KAFKA-19406 BTW: whether we should rename `ReplicaManager#updateLeaderAndFollowerMetrics` -- This is an automated message from the Apache Git

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-13 Thread via GitHub
TaiJuWu commented on PR #19699: URL: https://github.com/apache/kafka/pull/19699#issuecomment-2969548176 @FrankYang0529 Just remainder, there is a conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-17607) Add CI step to verify LICENSE-binary

2025-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17970030#comment-17970030 ] Mickael Maison commented on KAFKA-17607: The PR has been merged, can we now clos

[jira] [Commented] (KAFKA-17645) KIP-1052: Enable warmup in producer performance test

2025-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17970189#comment-17970189 ] Mickael Maison commented on KAFKA-17645: We're over 1 week after feature freeze

Re: [PR] MINOR: Cleanups in ConfigurationUtils [kafka]

2025-06-13 Thread via GitHub
reftel commented on PR #18576: URL: https://github.com/apache/kafka/pull/18576#issuecomment-2969596240 This was the fix for [CVE-2025-27817](https://www.cve.org/CVERecord?id=CVE-2025-27817) , right? -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Kafka-16355: Fix ConcurrentModificationException in evictWhile Method [kafka]

2025-06-13 Thread via GitHub
abhi-ksolves commented on PR #16554: URL: https://github.com/apache/kafka/pull/16554#issuecomment-2969638341 Hi @mjsax Sorry for the delay; I got involved in a lot of things. Will start to review this soon. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-13 Thread via GitHub
mimaison commented on PR #19931: URL: https://github.com/apache/kafka/pull/19931#issuecomment-2969958088 ping @jolshan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] KAFKA-18061 AddRaftVoter responds with error message "NONE" instead of null [kafka]

2025-06-13 Thread via GitHub
aiven-anton commented on PR #17930: URL: https://github.com/apache/kafka/pull/17930#issuecomment-2970158437 Bumping this one again, possible to get this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2144965738 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -569,7 +579,7 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2144968721 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -555,21 +560,12 @@ public Set makeReady(final Map topics) {

Re: [PR] KAFKA-10357: Add explicit internal topic initialization for Kafka Streams [kafka]

2025-06-13 Thread via GitHub
k-apol commented on code in PR #19913: URL: https://github.com/apache/kafka/pull/19913#discussion_r2144967161 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -90,6 +92,8 @@ public InternalTopicManager(final Time time,

Re: [PR] KAFKA-18462: Upgrade RocksDB dependency from 9.7.3 to 10.1.3 [kafka]

2025-06-13 Thread via GitHub
brandboat commented on PR #19880: URL: https://github.com/apache/kafka/pull/19880#issuecomment-2970221940 Gentle ping @cadonna, should I open a PR against the 4.1 branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-18462: Upgrade RocksDB dependency from 9.7.3 to 10.1.3 [kafka]

2025-06-13 Thread via GitHub
cadonna merged PR #19880: URL: https://github.com/apache/kafka/pull/19880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-18495) Remove Invalid 'numberOfOpenFiles' Metric from RocksDB State Store

2025-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17968855#comment-17968855 ] Mickael Maison commented on KAFKA-18495: I stumbled on this by accident and I do

[jira] [Commented] (KAFKA-19404) Connect's plugin.path documentation does not match behavior

2025-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17969004#comment-17969004 ] Mickael Maison commented on KAFKA-19404: So in your example, if you wanted isola

Re: [PR] KAFKA-18486: Migrate ReplicaManagerTest to use applyDelta [kafka]

2025-06-13 Thread via GitHub
chia7712 merged PR #19952: URL: https://github.com/apache/kafka/pull/19952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18486: Migrate ReplicaManagerTest RemoteFetchExpiresPerSecMetric and RemoteLogReaderMetrics with applyDelta [kafka]

2025-06-13 Thread via GitHub
chia7712 merged PR #19960: URL: https://github.com/apache/kafka/pull/19960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18486: Migrate ReplicaManagerTest to use applyDelta [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on PR #19954: URL: https://github.com/apache/kafka/pull/19954#issuecomment-2969447894 @DL1231 could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-19340: Move DelayedRemoteFetch to the storage module [kafka]

2025-06-13 Thread via GitHub
DL1231 commented on PR #19876: URL: https://github.com/apache/kafka/pull/19876#issuecomment-2969446947 I compared the performance of this patch with the current version in catch-up read scenarios with tiered storage enabled. Use command: > sh kafka-consumer-perf-test.sh --topic topic-t

Re: [PR] KAFKA-1940: Remove BrokerTopicStats#removeOldFollowerMetrics [kafka]

2025-06-13 Thread via GitHub
chia7712 commented on code in PR #19962: URL: https://github.com/apache/kafka/pull/19962#discussion_r2144435339 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2201,9 +2201,7 @@ class ReplicaManager(val config: KafkaConfig, private def updateLeaderAndFollower

[jira] [Commented] (KAFKA-19404) Connect's plugin.path documentation does not match behavior

2025-06-13 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17970231#comment-17970231 ] Greg Harris commented on KAFKA-19404: - No, both `/var/plugins` and `/var/plugins/nes

Re: [PR] MINOR: Cleanups in ConfigurationUtils [kafka]

2025-06-13 Thread via GitHub
showuon commented on PR #18576: URL: https://github.com/apache/kafka/pull/18576#issuecomment-2969678658 @reftel , yes, and this [PR](https://github.com/apache/kafka/pull/18523) is the 2nd part of the fix. -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (KAFKA-19404) Connect's plugin.path documentation does not match behavior

2025-06-13 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17970353#comment-17970353 ] Greg Harris commented on KAFKA-19404: - When I say "irrelevant" i don't mean "they ar

Re: [PR] KAFKA-19340: Move DelayedRemoteFetch to the storage module [kafka]

2025-06-13 Thread via GitHub
apoorvmittal10 commented on PR #19876: URL: https://github.com/apache/kafka/pull/19876#issuecomment-2969708948 > @frankvicky @apoorvmittal10 PTAL when you get a chance, thanks in advance. Thanks for the PR, I am a bot occupied with queues as of now. It's on my list to review, will tak

[PR] MINOR: fix MetadataRequest and MetadataResponse doc [kafka]

2025-06-13 Thread via GitHub
juha-aiven opened a new pull request, #19963: URL: https://github.com/apache/kafka/pull/19963 MetadataRequest and MetadataResponse version 0 is still supported. Remove from README.md mentioning that they're not supported. It's unclear how such a mention was ever included in the file. It has

[jira] [Commented] (KAFKA-19404) Connect's plugin.path documentation does not match behavior

2025-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17970918#comment-17970918 ] Mickael Maison commented on KAFKA-19404: Thanks Chris. I realize I did not fully

Re: [PR] MINOR: rename exception `e` to `swallow` where appropriate [kafka]

2025-06-13 Thread via GitHub
chia7712 merged PR #19948: URL: https://github.com/apache/kafka/pull/19948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18627: Deprecated "org.apache.kafka.disallowed.login.modules" [kafka]

2025-06-13 Thread via GitHub
gongxuanzhang commented on code in PR #18683: URL: https://github.com/apache/kafka/pull/18683#discussion_r2144692245 ## clients/src/test/java/org/apache/kafka/common/security/JaasContextTest.java: ## @@ -224,8 +225,7 @@ public void testDisallowedLoginModulesSystemProperty() thr

Re: [PR] MINOR: Cleanups in ConfigurationUtils [kafka]

2025-06-13 Thread via GitHub
reftel commented on PR #18576: URL: https://github.com/apache/kafka/pull/18576#issuecomment-2969721002 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Resolved] (KAFKA-17607) Add CI step to verify LICENSE-binary

2025-06-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17607. Fix Version/s: 4.1.0 Resolution: Fixed > Add CI step to verify LICENSE-binary > --

[jira] [Commented] (KAFKA-16700) Kafka Streams: possible message loss on KTable-KTable FK Left Join

2025-06-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17974004#comment-17974004 ] Karsten Stöckmann commented on KAFKA-16700: --- [~mjsax] I'm sorry for the delay

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-13 Thread via GitHub
junrao commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2146568617 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -609,7 +607,22 @@ private void handleProduceResponse(ClientResponse response, Ma

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-2972205411 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19381: add ConfigDef.ConfigKey.Builder [kafka]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #19912: URL: https://github.com/apache/kafka/pull/19912#issuecomment-2972205233 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18489 - Fix Connector tasks metrics task-startup-attempts, task… [kafka]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #18762: URL: https://github.com/apache/kafka/pull/18762#issuecomment-2972220727 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: use placeholders to replace string concatenation in Metrics log [kafka]

2025-06-13 Thread via GitHub
github-actions[bot] closed pull request #18831: MINOR: use placeholders to replace string concatenation in Metrics log URL: https://github.com/apache/kafka/pull/18831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-18489 - Fix Connector tasks metrics task-startup-attempts, task… [kafka]

2025-06-13 Thread via GitHub
github-actions[bot] closed pull request #18762: KAFKA-18489 - Fix Connector tasks metrics task-startup-attempts, task… URL: https://github.com/apache/kafka/pull/18762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] MINOR: use placeholders to replace string concatenation in Metrics log [kafka]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #18831: URL: https://github.com/apache/kafka/pull/18831#issuecomment-2972220751 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18201: testGroupMetadataMessageFormatter fails for new consumer protocol [kafka]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #18198: URL: https://github.com/apache/kafka/pull/18198#issuecomment-2972220664 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18149: Docs improvement for dynamic kraft quorum [kafka]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #18350: URL: https://github.com/apache/kafka/pull/18350#issuecomment-2972220691 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18486: Migrate ReplicaManagerTest to use applyDelta [kafka]

2025-06-13 Thread via GitHub
frankvicky merged PR #19954: URL: https://github.com/apache/kafka/pull/19954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac