Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-06-03 Thread via GitHub
lucasbru commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2935052103 @OmniaGM Hey, I detected the following NPE during Kafka Streams soak testing (on trunk): ``` [2025-05-29 04:06:05,855] ERROR [kafka-producer-network-thread | i-07bbab180f6062ba

Re: [PR] KAFKA-17747: [7/N] Add integration test for rack aware assignment [kafka]

2025-06-03 Thread via GitHub
dajac commented on code in PR #19856: URL: https://github.com/apache/kafka/pull/19856#discussion_r2123327253 ## clients/src/main/java/org/apache/kafka/clients/GroupRebalanceConfig.java: ## @@ -53,8 +54,15 @@ public GroupRebalanceConfig(AbstractConfig config, ProtocolType protoc

[jira] [Closed] (KAFKA-19341) Execution of HighWatermarkUpdate failed

2025-06-03 Thread Patrik Kleindl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrik Kleindl closed KAFKA-19341. -- > Execution of HighWatermarkUpdate failed > --- > >

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-06-03 Thread via GitHub
k-raina commented on code in PR #19881: URL: https://github.com/apache/kafka/pull/19881#discussion_r2123469195 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -718,7 +717,7 @@ private Optional> createPushRequest(ClientTel

Re: [PR] KAFKA-18376: High CPU load when AsyncKafkaConsumer uses a small max poll value [kafka]

2025-06-03 Thread via GitHub
dajac commented on code in PR #19865: URL: https://github.com/apache/kafka/pull/19865#discussion_r2123811226 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -176,6 +181,15 @@ void runOnce() { */ private void proce

[jira] [Resolved] (KAFKA-19256) Only send IQ information on assignment changes

2025-06-03 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-19256. Resolution: Fixed > Only send IQ information on assignment changes > -

Re: [PR] KAFKA-17747: [5/N] Replace subscription metadata with metadata hash in stream group [kafka]

2025-06-03 Thread via GitHub
lucasbru merged PR #19802: URL: https://github.com/apache/kafka/pull/19802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete all groups) [2/N] [kafka]

2025-06-03 Thread via GitHub
lucasbru commented on code in PR #19758: URL: https://github.com/apache/kafka/pull/19758#discussion_r2123533779 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -398,6 +403,127 @@ protected Admin createAdminClient(Map configOverrides) throws

Re: [PR] KAFKA-17747: [7/N] Add integration test for rack aware assignment [kafka]

2025-06-03 Thread via GitHub
FrankYang0529 commented on code in PR #19856: URL: https://github.com/apache/kafka/pull/19856#discussion_r2123564124 ## clients/src/main/java/org/apache/kafka/clients/GroupRebalanceConfig.java: ## @@ -53,8 +54,15 @@ public GroupRebalanceConfig(AbstractConfig config, ProtocolTyp

Re: [PR] KAFKA-17747: [7/N] Add integration test for rack aware assignment [kafka]

2025-06-03 Thread via GitHub
FrankYang0529 commented on code in PR #19856: URL: https://github.com/apache/kafka/pull/19856#discussion_r2123571086 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManager.java: ## @@ -306,6 +307,13 @@ public ConsumerGroupHeartbeatRe

Re: [PR] KAFKA-17853: Fix termination issue in ConsoleConsumer and ConsoleShareConsumer [kafka]

2025-06-03 Thread via GitHub
ShivsundarR commented on code in PR #19886: URL: https://github.com/apache/kafka/pull/19886#discussion_r2123616059 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -184,6 +196,7 @@ private void trySend(final long currentTimeM

Re: [PR] KAFKA-17747: [5/N] Replace subscription metadata with metadata hash in stream group [kafka]

2025-06-03 Thread via GitHub
FrankYang0529 commented on code in PR #19802: URL: https://github.com/apache/kafka/pull/19802#discussion_r2122885582 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -4434,6 +4435,15 @@ public void testUpdateStreamsGroupS

Re: [PR] KAFKA-17853: Fix termination issue in ConsoleConsumer and ConsoleShareConsumer [kafka]

2025-06-03 Thread via GitHub
ShivsundarR commented on code in PR #19886: URL: https://github.com/apache/kafka/pull/19886#discussion_r2123616437 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -144,6 +145,17 @@ public void tryConnect(Node node) { *

Re: [PR] [WIP] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-06-03 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2933264201 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (offset-related APIs) [1/N] [kafka]

2025-06-03 Thread via GitHub
aliehsaeedii commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2122958629 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -330,13 +403,433 @@ Map getOffsets(StreamsGroupDescription description)

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (offset-related APIs) [1/N] [kafka]

2025-06-03 Thread via GitHub
aliehsaeedii commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2122917642 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -330,13 +403,433 @@ Map getOffsets(StreamsGroupDescription description)

Re: [PR] KAFKA-14895: [1/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-03 Thread via GitHub
brandboat commented on code in PR #19879: URL: https://github.com/apache/kafka/pull/19879#discussion_r2122883306 ## core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala: ## @@ -275,7 +275,7 @@ abstract class QuorumTestHarness extends Logging { formatter.addD

Re: [PR] KAFKA-19338: Error on read/write of uninitialized share part. [kafka]

2025-06-03 Thread via GitHub
smjn commented on code in PR #19861: URL: https://github.com/apache/kafka/pull/19861#discussion_r2122975078 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -658,28 +645,14 @@ private CoordinatorRecord generateShareStateReco

[jira] [Commented] (KAFKA-19221) IOException on log segment close shouldn't be ignored

2025-06-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955830#comment-17955830 ] Mickael Maison commented on KAFKA-19221: Code freeze is on June 25, so you still

Re: [PR] [KAFKA-19328] SharePartitionManagerTest testMultipleConcurrentShareFetches doAnswer chaining needs verification [kafka]

2025-06-03 Thread via GitHub
apoorvmittal10 commented on PR #19872: URL: https://github.com/apache/kafka/pull/19872#issuecomment-2934231660 > @apoorvmittal10 , please let us know if you think what @ji-seung-ryu has done is enough, or we require more exploration. This test without these removed assertions is not d

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-06-03 Thread via GitHub
apoorvmittal10 commented on code in PR #19881: URL: https://github.com/apache/kafka/pull/19881#discussion_r2123173713 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -718,7 +717,7 @@ private Optional> createPushRequest(Cl

Re: [PR] MINOR: Cleanup Connect Module (1/n) [kafka]

2025-06-03 Thread via GitHub
m1a2st commented on code in PR #19869: URL: https://github.com/apache/kafka/pull/19869#discussion_r2123355432 ## connect/api/src/main/java/org/apache/kafka/connect/data/Values.java: ## @@ -1273,9 +1254,7 @@ public boolean canDetect(Object value) { } if

Re: [PR] KAFKA-18376: High CPU load when AsyncKafkaConsumer uses a small max poll value [kafka]

2025-06-03 Thread via GitHub
AndrewJSchofield commented on code in PR #19865: URL: https://github.com/apache/kafka/pull/19865#discussion_r2123377334 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -176,6 +181,15 @@ void runOnce() { */ private

[jira] [Resolved] (KAFKA-19338) Share coordinator read state and write state should return error, if the share partition is not initialized.

2025-06-03 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19338. -- Fix Version/s: 4.1.0 Resolution: Fixed > Share coordinator read state and write

Re: [PR] KAFKA-19338: Error on read/write of uninitialized share part. [kafka]

2025-06-03 Thread via GitHub
AndrewJSchofield merged PR #19861: URL: https://github.com/apache/kafka/pull/19861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-06-03 Thread via GitHub
dajac commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2123076152 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -451,6 +450,35 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, } }

Re: [PR] MINOR: Cleanup ShareFetchAcknowledgeRequestTest [kafka]

2025-06-03 Thread via GitHub
sjhajharia commented on PR #19852: URL: https://github.com/apache/kafka/pull/19852#issuecomment-2934067128 Hey @frankvicky / @chia7712 , Inviting you for reviews too. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] MINOR: Remove unused code from storage classes [kafka]

2025-06-03 Thread via GitHub
kamalcph commented on code in PR #19853: URL: https://github.com/apache/kafka/pull/19853#discussion_r2122841310 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -435,14 +423,6 @@ public int remoteLogMetadataCustomMetadataMaxB

Re: [PR] MINOR: Remove unused code from storage classes [kafka]

2025-06-03 Thread via GitHub
wernerdv commented on code in PR #19853: URL: https://github.com/apache/kafka/pull/19853#discussion_r2122913734 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -435,14 +423,6 @@ public int remoteLogMetadataCustomMetadataMaxB

Re: [PR] KAFKA-19338: Error on read/write of uninitialized share part. [kafka]

2025-06-03 Thread via GitHub
smjn commented on code in PR #19861: URL: https://github.com/apache/kafka/pull/19861#discussion_r2122975078 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -658,28 +645,14 @@ private CoordinatorRecord generateShareStateReco

[jira] [Commented] (KAFKA-19341) Execution of HighWatermarkUpdate failed

2025-06-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955835#comment-17955835 ] David Jacot commented on KAFKA-19341: - [~pkleindl] This bug was indeed fixed in 4.0.

Re: [PR] MINOR: Cleanup Connect Module (1/n) [kafka]

2025-06-03 Thread via GitHub
sjhajharia commented on code in PR #19869: URL: https://github.com/apache/kafka/pull/19869#discussion_r2123416469 ## connect/api/src/test/java/org/apache/kafka/connect/header/ConnectHeadersTest.java: ## @@ -380,9 +381,9 @@ public void shouldValidateBuildInTypes() { asse

Re: [PR] MINOR: Cleanup Connect Module (1/n) [kafka]

2025-06-03 Thread via GitHub
sjhajharia commented on PR #19869: URL: https://github.com/apache/kafka/pull/19869#issuecomment-2934616417 Hey @m1a2st , Thanks for the review. Requesting a re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-19250 : txnProducer.abortTransaction() API should not return abortable exception [kafka]

2025-06-03 Thread via GitHub
k-raina commented on PR #19656: URL: https://github.com/apache/kafka/pull/19656#issuecomment-2934966301 Unrelated test failures as similiar failures are in another PR Job https://github.com/apache/kafka/actions/runs/15096607388/job/42432258294 -- This is an automated message from the A

[jira] [Commented] (KAFKA-19341) Execution of HighWatermarkUpdate failed

2025-06-03 Thread Patrik Kleindl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955852#comment-17955852 ] Patrik Kleindl commented on KAFKA-19341: [~dajac]  Unless it was changed by acci

Re: [PR] KAFKA-19353: Upgrade note and initial docs for KIP-932 [kafka]

2025-06-03 Thread via GitHub
AndrewJSchofield merged PR #19863: URL: https://github.com/apache/kafka/pull/19863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-19353) Preview documentation

2025-06-03 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19353. -- Fix Version/s: 4.1.0 Resolution: Fixed > Preview documentation > --

Re: [PR] KAFKA-17853: Fix termination issue in ConsoleConsumer and ConsoleShareConsumer [kafka]

2025-06-03 Thread via GitHub
apoorvmittal10 commented on PR #19886: URL: https://github.com/apache/kafka/pull/19886#issuecomment-2935232432 Great to see the fix in the area, thanks for looking into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-06-03 Thread via GitHub
apoorvmittal10 merged PR #19881: URL: https://github.com/apache/kafka/pull/19881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.

Re: [PR] KAFKA-18376: High CPU load when AsyncKafkaConsumer uses a small max poll value [kafka]

2025-06-03 Thread via GitHub
dajac commented on code in PR #19865: URL: https://github.com/apache/kafka/pull/19865#discussion_r2123811226 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -176,6 +181,15 @@ void runOnce() { */ private void proce

[jira] [Created] (KAFKA-19363) Enhance share group assignor for heterogeneous subscription type

2025-06-03 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19363: Summary: Enhance share group assignor for heterogeneous subscription type Key: KAFKA-19363 URL: https://issues.apache.org/jira/browse/KAFKA-19363 Project: Kaf

[jira] [Created] (KAFKA-19364) Production-ready documentation

2025-06-03 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19364: Summary: Production-ready documentation Key: KAFKA-19364 URL: https://issues.apache.org/jira/browse/KAFKA-19364 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-19362) Enhance share group assignor for homogeneous subscription type

2025-06-03 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19362: Summary: Enhance share group assignor for homogeneous subscription type Key: KAFKA-19362 URL: https://issues.apache.org/jira/browse/KAFKA-19362 Project: Kafka

Re: [PR] KAFKA-18376: High CPU load when AsyncKafkaConsumer uses a small max poll value [kafka]

2025-06-03 Thread via GitHub
kirktrue closed pull request #19865: KAFKA-18376: High CPU load when AsyncKafkaConsumer uses a small max poll value URL: https://github.com/apache/kafka/pull/19865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-18376: High CPU load when AsyncKafkaConsumer uses a small max poll value [kafka]

2025-06-03 Thread via GitHub
kirktrue commented on PR #19865: URL: https://github.com/apache/kafka/pull/19865#issuecomment-2935534963 Thanks for the feedback. I'm going to close this PR due to some testing errors on my part. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (offset-related APIs) [1/N] [kafka]

2025-06-03 Thread via GitHub
lucasbru commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2124050789 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -330,13 +403,433 @@ Map getOffsets(StreamsGroupDescription description)

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
lianetm commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2123890568 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/JwtBearerJwtRetriever.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Assigned] (KAFKA-19155) Update docs/security.html for streams-related RPCs

2025-06-03 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19155: -- Assignee: Lucas Brutschy > Update docs/security.html for streams-related RPCs > -

[PR] KAFKA-19155: Update docs/security.html for streams-related RPCs [kafka]

2025-06-03 Thread via GitHub
lucasbru opened a new pull request, #19887: URL: https://github.com/apache/kafka/pull/19887 We need to add the correct ACLs for the streams-related RPCs in docs/security.html. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-19155: Update docs/security.html for streams-related RPCs [kafka]

2025-06-03 Thread via GitHub
lucasbru commented on PR #19887: URL: https://github.com/apache/kafka/pull/19887#issuecomment-2935753224 @AndrewJSchofield - since you recently did this for share... could you give it a quick look? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-19155: Update docs/security.html for streams-related RPCs [kafka]

2025-06-03 Thread via GitHub
Copilot commented on code in PR #19887: URL: https://github.com/apache/kafka/pull/19887#discussion_r2124128766 ## docs/security.html: ## @@ -2273,6 +2273,36 @@

[jira] [Commented] (KAFKA-19341) Execution of HighWatermarkUpdate failed

2025-06-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955932#comment-17955932 ] David Jacot commented on KAFKA-19341: - [~pkleindl] I checked CP 7.9 and you're right

Re: [PR] [KAFKA-19328] SharePartitionManagerTest testMultipleConcurrentShareFetches doAnswer chaining needs verification [kafka]

2025-06-03 Thread via GitHub
ji-seung-ryu commented on PR #19872: URL: https://github.com/apache/kafka/pull/19872#issuecomment-2935974699 Thank you, @adixitconfluent @apoorvmittal10 I got your point. I am wondering the the purpose of assert of doAsnwer chain (check the value of share partition nextFetchOffset). Actual

Re: [PR] KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group [kafka]

2025-06-03 Thread via GitHub
AndrewJSchofield commented on PR #19796: URL: https://github.com/apache/kafka/pull/19796#issuecomment-2935986055 @FrankYang0529 I think you are planning a follow-on PR with additional testing when rebalance occurs. Apart from that future work, this looks ready to merge. -- This is an aut

[jira] [Created] (KAFKA-19365) Metric for Unclean Recoveries

2025-06-03 Thread Jonah Hooper (Jira)
Jonah Hooper created KAFKA-19365: Summary: Metric for Unclean Recoveries Key: KAFKA-19365 URL: https://issues.apache.org/jira/browse/KAFKA-19365 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group [kafka]

2025-06-03 Thread via GitHub
AndrewJSchofield merged PR #19796: URL: https://github.com/apache/kafka/pull/19796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] [KAFKA-19328] SharePartitionManagerTest testMultipleConcurrentShareFetches doAnswer chaining needs verification [kafka]

2025-06-03 Thread via GitHub
adixitconfluent commented on PR #19872: URL: https://github.com/apache/kafka/pull/19872#issuecomment-2936051198 @ji-seung-ryu I think we should get rid of this test `testMultipleConcurrentShareFetches`. When this test was written originally, we didn't have the `DelayedShareFetchPurgatory`.

[jira] [Commented] (KAFKA-19354) KRaft observer unable to recover after re-bootstrapping to follower

2025-06-03 Thread Justin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955941#comment-17955941 ] Justin Chen commented on KAFKA-19354: - Hi José, I was able to reproduce the issue wi

Re: [PR] KAFKA-18462: Upgrade RocksDB dependency from 9.7.3 to 10.2.1 [kafka]

2025-06-03 Thread via GitHub
brandboat commented on code in PR #19880: URL: https://github.com/apache/kafka/pull/19880#discussion_r2124381733 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java: ## @@ -574,17 +574,6 @@ public long

[jira] [Assigned] (KAFKA-18682) Designated Leadership Elections

2025-06-03 Thread Mahsa Seifikar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahsa Seifikar reassigned KAFKA-18682: -- Assignee: Mahsa Seifikar (was: Jonah Hooper) > Designated Leadership Elections > ---

Re: [PR] KAFKA-18462: Upgrade RocksDB dependency from 9.7.3 to 10.2.1 [kafka]

2025-06-03 Thread via GitHub
brandboat commented on code in PR #19880: URL: https://github.com/apache/kafka/pull/19880#discussion_r2124465505 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java: ## @@ -574,17 +574,6 @@ public long

Re: [PR] KAFKA-18462: Upgrade RocksDB dependency from 9.7.3 to 10.2.1 [kafka]

2025-06-03 Thread via GitHub
brandboat commented on code in PR #19880: URL: https://github.com/apache/kafka/pull/19880#discussion_r2124465505 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java: ## @@ -574,17 +574,6 @@ public long

Re: [PR] KAFKA-19176: Update Transactional producer to translate retriable into abortable exceptions [kafka]

2025-06-03 Thread via GitHub
k-raina commented on code in PR #19522: URL: https://github.com/apache/kafka/pull/19522#discussion_r2124500762 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -771,6 +773,15 @@ public synchronized void maybeTransitionToErrorSt

Re: [PR] KAFKA-19176: Update Transactional producer to translate retriable into abortable exceptions [kafka]

2025-06-03 Thread via GitHub
k-raina commented on code in PR #19522: URL: https://github.com/apache/kafka/pull/19522#discussion_r2124500762 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -771,6 +773,15 @@ public synchronized void maybeTransitionToErrorSt

[PR] [WIP] MINOR: Refactor brokerContactTimesMs from AtomicLong to Long [kafka]

2025-06-03 Thread via GitHub
apalan60 opened a new pull request, #19888: URL: https://github.com/apache/kafka/pull/19888 Simplify `brokerContactTimesMs` by switching from `ConcurrentHashMap `to `ConcurrentHashMap `and using `compute()` for atomic updates. This removes mutable holders without affecting thread safety (s

[jira] [Commented] (KAFKA-19354) KRaft observer unable to recover after re-bootstrapping to follower

2025-06-03 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955957#comment-17955957 ] Alyssa Huang commented on KAFKA-19354: -- Hey Justin, I believe what José is saying t

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
kirktrue commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124593326 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/assertion/AssertionUtils.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apa

[jira] [Created] (KAFKA-19366) Do not resolve address in QuorumConfig and DynamicVoter

2025-06-03 Thread Jira
José Armando García Sancio created KAFKA-19366: -- Summary: Do not resolve address in QuorumConfig and DynamicVoter Key: KAFKA-19366 URL: https://issues.apache.org/jira/browse/KAFKA-19366 Pr

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
kirktrue commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124631708 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -129,6 +130,186 @@ public class SaslConfigs { + " authentication provider.

Re: [PR] KAFKA-19324: org.apache.kafka.common.test.TestUtils should be package-private [kafka]

2025-06-03 Thread via GitHub
YutaLin commented on code in PR #19884: URL: https://github.com/apache/kafka/pull/19884#discussion_r2124626925 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/TestUtils.java: ## @@ -32,10 +28,7 @@ import java.io.File; import java.io.IOException;

Re: [PR] KAFKA-19176: Update Transactional producer to translate retriable into abortable exceptions [kafka]

2025-06-03 Thread via GitHub
jolshan merged PR #19522: URL: https://github.com/apache/kafka/pull/19522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: fixing updateBrokerContactTime [kafka]

2025-06-03 Thread via GitHub
apalan60 commented on code in PR #19828: URL: https://github.com/apache/kafka/pull/19828#discussion_r2124660956 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,7 +267,8 @@ public long newActiveControllers() { } p

Re: [PR] KAFKA-19325 improve forceComplete() in DelayedOperation [kafka]

2025-06-03 Thread via GitHub
apoorvmittal10 commented on code in PR #19862: URL: https://github.com/apache/kafka/pull/19862#discussion_r2124860736 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/core/TestPurgatoryPerformance.java: ## @@ -479,7 +479,8 @@ public void onComplete() { @Override

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
lianetm commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124874851 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/JwtResponseParser.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Softw

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
lianetm commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124901126 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -129,6 +130,186 @@ public class SaslConfigs { + " authentication provider."

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
kirktrue commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124903893 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/JwtBearerJwtRetriever.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
kirktrue commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124903048 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/JwtResponseParser.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Soft

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
kirktrue commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124904323 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/ClientCredentialsJwtRetriever.java: ## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
kirktrue commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124904551 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -143,7 +311,7 @@ public class SaslConfigs { public static final String SASL_OAUT

Re: [PR] KAFKA-19176: Update Transactional producer to translate retriable into abortable exceptions [kafka]

2025-06-03 Thread via GitHub
jolshan commented on code in PR #19522: URL: https://github.com/apache/kafka/pull/19522#discussion_r2124459206 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -771,6 +773,15 @@ public synchronized void maybeTransitionToErrorSt

[PR] KAFKA-18913: State Updater thread not shutting down during teardown i… [kafka]

2025-06-03 Thread via GitHub
janchilling opened a new pull request, #19889: URL: https://github.com/apache/kafka/pull/19889 …n StreamThreadTest fix Updated the code to start the State Updater Thread only after the Stream Thread is started. Changes done : 1. Moved the starting of the StateUpdater thread

[PR] KAFKA-18486: Remove ReplicaManager#becomeLeaderOrFollower [kafka]

2025-06-03 Thread via GitHub
YutaLin opened a new pull request, #19890: URL: https://github.com/apache/kafka/pull/19890 Description: * replace RPC with KRaft mechanism to test activeProducerState in ReplicaManagerTest Reviewers: PoAn Yang [pay...@apache.org](mailto:pay...@apache.org), Ken Huang [s7133...

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-06-03 Thread via GitHub
jim0987795064 commented on PR #19776: URL: https://github.com/apache/kafka/pull/19776#issuecomment-2937201446 Hello, @chia7712 @m1a2st I've addressed the issues mentioned above. Could you please review these? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-18913: State Updater thread not shutting down during teardown i… [kafka]

2025-06-03 Thread via GitHub
janchilling commented on PR #19889: URL: https://github.com/apache/kafka/pull/19889#issuecomment-2937205109 Hi @cadonna , Here is the fix for the issue that we discussed(`StateUpdater` thread being left to run even though an IllegalStateException thrown before the `StreamThread` is c

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
lianetm commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2124982659 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/JwtResponseParser.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Softw

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-03 Thread via GitHub
loicgreffier commented on code in PR #18739: URL: https://github.com/apache/kafka/pull/18739#discussion_r2125005143 ## streams/src/main/java/org/apache/kafka/streams/errors/ErrorHandlerContext.java: ## @@ -147,4 +147,38 @@ public interface ErrorHandlerContext { * @return T

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-03 Thread via GitHub
loicgreffier commented on code in PR #18739: URL: https://github.com/apache/kafka/pull/18739#discussion_r2125005325 ## streams/src/main/java/org/apache/kafka/streams/processor/RecordContext.java: ## @@ -110,4 +110,37 @@ public interface RecordContext { */ Headers head

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-03 Thread via GitHub
loicgreffier commented on code in PR #18739: URL: https://github.com/apache/kafka/pull/18739#discussion_r2125012007 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -1890,6 +1892,69 @@ public void shouldNotSendIfSendOfOtherTa

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-03 Thread via GitHub
loicgreffier commented on code in PR #18739: URL: https://github.com/apache/kafka/pull/18739#discussion_r2125010510 ## streams/src/main/java/org/apache/kafka/streams/processor/RecordContext.java: ## @@ -110,4 +110,37 @@ public interface RecordContext { */ Headers head

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-03 Thread via GitHub
loicgreffier commented on code in PR #18739: URL: https://github.com/apache/kafka/pull/18739#discussion_r2125010998 ## streams/src/main/java/org/apache/kafka/streams/processor/RecordContext.java: ## @@ -110,4 +110,37 @@ public interface RecordContext { */ Headers head

Re: [PR] KAFKA-19044: Handle tasks that are not present in the current topology [kafka]

2025-06-03 Thread via GitHub
bbejeck commented on code in PR #19722: URL: https://github.com/apache/kafka/pull/19722#discussion_r2125005760 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/TopologyMetadataTest.java: ## @@ -113,14 +103,4 @@ void testIsStatefulThrowsExceptionWhen

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-03 Thread via GitHub
loicgreffier commented on PR #18739: URL: https://github.com/apache/kafka/pull/18739#issuecomment-2937388257 @cadonna - I've mainly updated `ProcessingExceptionHandlerIntegrationTest.java` to assert the presence of the source raw key and source raw value. - I’ve added a new param

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-06-03 Thread via GitHub
kirktrue commented on code in PR #19754: URL: https://github.com/apache/kafka/pull/19754#discussion_r2125121230 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/JwtResponseParser.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Soft

Re: [PR] MINOR: Refactor brokerContactTimesMs from AtomicLong to Long [kafka]

2025-06-03 Thread via GitHub
Yunyung commented on PR #19888: URL: https://github.com/apache/kafka/pull/19888#issuecomment-2937664018 https://github.com/apache/kafka/blob/8c71ab03b59324249b59139f105ebd023e385e66/metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java#L78 This is the s

Re: [PR] KAFKA-19250 : txnProducer.abortTransaction() API should not return abortable exception [kafka]

2025-06-03 Thread via GitHub
jolshan merged PR #19656: URL: https://github.com/apache/kafka/pull/19656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[PR] MINOR: Remove unnecessary checks. [kafka]

2025-06-03 Thread via GitHub
gongxuanzhang opened a new pull request, #19891: URL: https://github.com/apache/kafka/pull/19891 The `String.split` method never returns an array containing null elements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group [kafka]

2025-06-03 Thread via GitHub
FrankYang0529 commented on PR #19796: URL: https://github.com/apache/kafka/pull/19796#issuecomment-2938154649 @AndrewJSchofield I tried to add an integration test. However, the `GroupMetadataManager` doesn't support to use other assignors. Currently, there is no usage of `withShareGroupAssi

[jira] [Resolved] (KAFKA-19177) Return InvalidTxnStateException as Abortable for Transaction producer API

2025-06-03 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina resolved KAFKA-19177. --- Resolution: Fixed > Return InvalidTxnStateException as Abortable for Transaction producer A

[jira] [Resolved] (KAFKA-19176) Update Transactional producer to translate retriable into abortable exceptions

2025-06-03 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina resolved KAFKA-19176. --- Resolution: Fixed > Update Transactional producer to translate retriable into abortable > e

[jira] [Resolved] (KAFKA-19250) abortTransactions should not return abortable exception

2025-06-03 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina resolved KAFKA-19250. --- Resolution: Fixed > abortTransactions should not return abortable exception > --

  1   2   >