FrankYang0529 commented on code in PR #19802:
URL: https://github.com/apache/kafka/pull/19802#discussion_r2122885582


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -4434,6 +4435,15 @@ public void testUpdateStreamsGroupSizeCounter() {
                     .build()))
             .build();
 
+        for (int i = 1; i < 4; i++) {

Review Comment:
   I moved `setConfiguredTopology` to `GroupMetadataManagerTestContext`. If a 
stream group has topology, the context calls 
`InternalTopicManager.configureTopics` and set the result to the group.
   
   Only `testStreamsStreamsGroupStates` does 
`InternalTopicManager.configureTopics` in `GroupMetadataManagerTest.java`. It 
tried to replay records to rebuild the group. Since we don't have subscription 
metadata now, it has to call `InternalTopicManager.configureTopics` and set the 
result to configured topology.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to