Re: [PR] MINOR: Upgrade to Gradle 8.14.1 [kafka]

2025-05-27 Thread via GitHub
fvaleri commented on PR #19780: URL: https://github.com/apache/kafka/pull/19780#issuecomment-2911770995 There are a couple of failing tests that seems to be flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-19285: Added more tests in SharePartitionManagerTest [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield commented on code in PR #19778: URL: https://github.com/apache/kafka/pull/19778#discussion_r2108705314 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -276,6 +278,91 @@ public void testNewContextReturnsFinalContextWhenTopicPartiti

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete all groups) [2/N] [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield commented on code in PR #19758: URL: https://github.com/apache/kafka/pull/19758#discussion_r2108655166 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -398,6 +403,127 @@ protected Admin createAdminClient(Map configOverrides

Re: [PR] KAFKA-18687: Setting the subscriptionMetadata during conversion to consumer group [kafka]

2025-05-27 Thread via GitHub
dajac merged PR #19790: URL: https://github.com/apache/kafka/pull/19790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-18687) New group coordinator triggers assignment recalculation on consumer group upgrade due to static member replacement

2025-05-27 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18687. - Fix Version/s: 4.0.1 4.1.0 Resolution: Fixed > New group coordinator t

Re: [PR] KAFKA-18687: Setting the subscriptionMetadata during conversion to consumer group [kafka]

2025-05-27 Thread via GitHub
dajac commented on PR #19790: URL: https://github.com/apache/kafka/pull/19790#issuecomment-2911844249 Merged it to trunk and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] MINOR: Remove flakiness caused when producing aborted transaction in ShareConsumerTest [kafka]

2025-05-27 Thread via GitHub
adixitconfluent opened a new pull request, #19824: URL: https://github.com/apache/kafka/pull/19824 ### About This PR attempts to removed the flakiness in `testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck` and `testAlterReadCommittedToReadUncommittedIsolationLevelWithRe

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-27 Thread via GitHub
dajac commented on PR #19761: URL: https://github.com/apache/kafka/pull/19761#issuecomment-2911847729 @FrankYang0529 We just merged https://github.com/apache/kafka/pull/19790. Could you please rebase? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] MINOR: Upgrade to Gradle 8.14.1 [kafka]

2025-05-27 Thread via GitHub
showuon commented on PR #19780: URL: https://github.com/apache/kafka/pull/19780#issuecomment-2911938507 > We just use the command that regenerates the file - that used all before. Not sure if that changed. Let's move to `bin` as suggested. And we can always move back to `all` if need

Re: [PR] MINOR: Upgrade to Gradle 8.14.1 [kafka]

2025-05-27 Thread via GitHub
showuon merged PR #19780: URL: https://github.com/apache/kafka/pull/19780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete all groups) [2/N] [kafka]

2025-05-27 Thread via GitHub
lucasbru commented on code in PR #19758: URL: https://github.com/apache/kafka/pull/19758#discussion_r2108793364 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -398,6 +403,127 @@ protected Admin createAdminClient(Map configOverrides) throws

Re: [PR] KAFKA-19330: Change MockSerializer/Deserializer to use String serializer instead of byte[] [kafka]

2025-05-27 Thread via GitHub
chia7712 commented on PR #19812: URL: https://github.com/apache/kafka/pull/19812#issuecomment-2911986064 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-7542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-19330: Change MockSerializer/Deserializer to use String serializer instead of byte[] [kafka]

2025-05-27 Thread via GitHub
chia7712 merged PR #19812: URL: https://github.com/apache/kafka/pull/19812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-27 Thread via GitHub
chia7712 commented on PR #19741: URL: https://github.com/apache/kafka/pull/19741#issuecomment-2911987458 @mingyen066 please fix conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Resolved] (KAFKA-19330) MockSerializer should extend Serializer

2025-05-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19330. Fix Version/s: 4.1.0 Resolution: Fixed > MockSerializer should extend Serializer >

[jira] [Updated] (KAFKA-19337) Bug in ShareCoordinatorShard.generateShareStateRecord prevents stateEpoch update misses.

2025-05-27 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan updated KAFKA-19337: Description: {{private CoordinatorRecord generateShareStateRecord(}} {{  WriteShareGroupSt

[jira] [Updated] (KAFKA-19337) Bug in ShareCoordinatorShard.generateShareStateRecord prevents stateEpoch update misses.

2025-05-27 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan updated KAFKA-19337: Description: {{private CoordinatorRecord generateShareStateRecord(}} {{  WriteShareGroupSt

[jira] [Updated] (KAFKA-19337) Bug in ShareCoordinatorShard.generateShareStateRecord causes stateEpoch update misses.

2025-05-27 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan updated KAFKA-19337: Summary: Bug in ShareCoordinatorShard.generateShareStateRecord causes stateEpoch update mi

[PR] MINOR: Migrate usages of the deprecated Endpoint#listenerName to the Endpoint#listener [kafka]

2025-05-27 Thread via GitHub
mingyen066 opened a new pull request, #19825: URL: https://github.com/apache/kafka/pull/19825 [KIP-1143](https://cwiki.apache.org/confluence/x/LwqWF) replaced `Optional listenerName()` with `String listener()`. This patch migrates the usage from the deprecated method to the new one.

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-05-27 Thread via GitHub
brandboat commented on code in PR #19793: URL: https://github.com/apache/kafka/pull/19793#discussion_r2108937663 ## server/src/main/java/org/apache/kafka/server/DelayedProduce.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Created] (KAFKA-19339) Move DelayedFetch to server module

2025-05-27 Thread Kuan Po Tseng (Jira)
Kuan Po Tseng created KAFKA-19339: - Summary: Move DelayedFetch to server module Key: KAFKA-19339 URL: https://issues.apache.org/jira/browse/KAFKA-19339 Project: Kafka Issue Type: Sub-task

[jira] [Assigned] (KAFKA-19332) Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck and testAlterReadCommittedToReadUncommittedIsolationLevelWithRejectAck

2025-05-27 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-19332: - Assignee: Abhinav Dixit > Fix flaky test : > testAlterReadCommittedToReadUncommittedIs

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

2025-05-27 Thread via GitHub
sjhajharia commented on PR #19510: URL: https://github.com/apache/kafka/pull/19510#issuecomment-2912067260 Gentle reminder @frankvicky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-19042: [9/N] Move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-27 Thread via GitHub
Rancho-7 commented on PR #19685: URL: https://github.com/apache/kafka/pull/19685#issuecomment-2912306275 fixed it. @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (KAFKA-19338) Share coordinator read state and write state should return error, if the share partition is not initialized.

2025-05-27 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-19338: --- Summary: Share coordinator read state and write state should return error, if the share partition is not initialized. Key: KAFKA-19338 URL: https://issues.apache.org/jira/br

[jira] [Created] (KAFKA-19342) Add AuthorizerIntegrationTest for alter share group offsets

2025-05-27 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19342: Summary: Add AuthorizerIntegrationTest for alter share group offsets Key: KAFKA-19342 URL: https://issues.apache.org/jira/browse/KAFKA-19342 Project: Kafka

[jira] [Updated] (KAFKA-19341) Execution of HighWatermarkUpdate failed

2025-05-27 Thread Patrik Kleindl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrik Kleindl updated KAFKA-19341: --- Description: We got the following Exception multiple times in our logs when a client showed

[jira] [Created] (KAFKA-19341) Execution of HighWatermarkUpdate failed

2025-05-27 Thread Patrik Kleindl (Jira)
Patrik Kleindl created KAFKA-19341: -- Summary: Execution of HighWatermarkUpdate failed Key: KAFKA-19341 URL: https://issues.apache.org/jira/browse/KAFKA-19341 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-19337) Bug in ShareCoordinatorShard.generateShareStateRecord prevents stateEpoch update misses.

2025-05-27 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-19337: --- Summary: Bug in ShareCoordinatorShard.generateShareStateRecord prevents stateEpoch update misses. Key: KAFKA-19337 URL: https://issues.apache.org/jira/browse/KAFKA-19337

Re: [PR] MINOR: Remove flakiness caused when producing aborted transaction in ShareConsumerTest [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield merged PR #19824: URL: https://github.com/apache/kafka/pull/19824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Updated] (KAFKA-19340) Move DelayedRemoteFetch to the storage module

2025-05-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding updated KAFKA-19340: - Priority: Minor (was: Major) > Move DelayedRemoteFetch to the storage module >

[jira] [Created] (KAFKA-19340) Move DelayedRemoteFetch to the storage module

2025-05-27 Thread Lan Ding (Jira)
Lan Ding created KAFKA-19340: Summary: Move DelayedRemoteFetch to the storage module Key: KAFKA-19340 URL: https://issues.apache.org/jira/browse/KAFKA-19340 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (offset-related APIs) [1/N] [kafka]

2025-05-27 Thread via GitHub
lucasbru commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2108855809 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -330,13 +403,433 @@ Map getOffsets(StreamsGroupDescription description)

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-05-27 Thread via GitHub
m1a2st commented on code in PR #19793: URL: https://github.com/apache/kafka/pull/19793#discussion_r2108484602 ## core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala: ## @@ -271,9 +271,10 @@ class LocalLeaderEndPointTest extends Logging { o

Re: [PR] KAFKA-19042: [10/N] Move PlaintextConsumerAssignTest to clients-integration-tests module [kafka]

2025-05-27 Thread via GitHub
m1a2st commented on code in PR #19773: URL: https://github.com/apache/kafka/pull/19773#discussion_r2108531921 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerAssignTest.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apach

[jira] [Updated] (KAFKA-17301) lz4-java is not maintained anymore

2025-05-27 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-17301: --- Description: lz4-java has not made a release since June 2021. It still depends on lz4 1.9.3

Re: [PR] KAFKA-19042: [10/N] Move PlaintextConsumerAssignTest to clients-integration-tests module [kafka]

2025-05-27 Thread via GitHub
m1a2st commented on code in PR #19773: URL: https://github.com/apache/kafka/pull/19773#discussion_r2108558629 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerAssignTest.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apach

Re: [PR] KAFKA-19320: Added share_consume_bench_test.py system tests [kafka]

2025-05-27 Thread via GitHub
DL1231 commented on code in PR #19811: URL: https://github.com/apache/kafka/pull/19811#discussion_r2108439612 ## tests/kafkatest/tests/core/share_consume_bench_test.py: ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor lice

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-05-27 Thread via GitHub
frankvicky commented on code in PR #19793: URL: https://github.com/apache/kafka/pull/19793#discussion_r2108582444 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -983,23 +1003,25 @@ class ReplicaManager(val config: KafkaConfig, delayedProducePurgatory.tryC

Re: [PR] KAFKA-19154; Offset Fetch API should return INVALID_OFFSET if requested topic id does not match persisted one [kafka]

2025-05-27 Thread via GitHub
dajac commented on code in PR #19744: URL: https://github.com/apache/kafka/pull/19744#discussion_r2108655384 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -859,6 +859,7 @@ boolean hasCommittedOffset( * * @retu

[PR] KAFKA-19042: [12/N] Move PlaintextConsumerSubscriptionTest to client-integration-tests module [kafka]

2025-05-27 Thread via GitHub
m1a2st opened a new pull request, #19827: URL: https://github.com/apache/kafka/pull/19827 Use Java to rewrite PlaintextConsumerSubscriptionTest by new test infra and move it to client-integration-tests module. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (KAFKA-18823) native docker don't honor the result of checking sign key

2025-05-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18823. Resolution: Duplicate see https://github.com/apache/kafka/pull/18844 > native docker don'

Re: [PR] KAFKA-19154; Offset Fetch API should return INVALID_OFFSET if requested topic id does not match persisted one [kafka]

2025-05-27 Thread via GitHub
dajac merged PR #19744: URL: https://github.com/apache/kafka/pull/19744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-19154) Return INVALID_OFFSET if requested topic id does not match persisted one

2025-05-27 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-19154. - Fix Version/s: 4.1.0 Resolution: Fixed > Return INVALID_OFFSET if requested topic id does

[PR] MINOR: fixing updateBrokerContactTime [kafka]

2025-05-27 Thread via GitHub
kevin-wu24 opened a new pull request, #19828: URL: https://github.com/apache/kafka/pull/19828 Fix `updateBrokerContactTime` so that existing brokers still have their contact time updated when they are already tracked. Also, update the unit test to test this case. -- This is an automa

Re: [PR] MINOR: fixing updateBrokerContactTime [kafka]

2025-05-27 Thread via GitHub
brandboat commented on code in PR #19828: URL: https://github.com/apache/kafka/pull/19828#discussion_r2109362637 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,7 +267,11 @@ public long newActiveControllers() { }

Re: [PR] MINOR: fixing updateBrokerContactTime [kafka]

2025-05-27 Thread via GitHub
brandboat commented on code in PR #19828: URL: https://github.com/apache/kafka/pull/19828#discussion_r2109362637 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,7 +267,11 @@ public long newActiveControllers() { }

Re: [PR] MINOR: fixing updateBrokerContactTime [kafka]

2025-05-27 Thread via GitHub
kevin-wu24 commented on code in PR #19828: URL: https://github.com/apache/kafka/pull/19828#discussion_r2109394645 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,7 +267,11 @@ public long newActiveControllers() { }

Re: [PR] KAFKA-19042: [11/N] move ConsumerWithLegacyMessageFormatIntegrationTest to clients-integration-tests module [kafka]

2025-05-27 Thread via GitHub
Rancho-7 commented on code in PR #19810: URL: https://github.com/apache/kafka/pull/19810#discussion_r2109104806 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerWithLegacyMessageFormatIntegrationTest.java: ## @@ -0,0 +1,226 @@ +/* + *

[PR] MINOR: Align tool output for deletion of groups [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield opened a new pull request, #19829: URL: https://github.com/apache/kafka/pull/19829 This PR makes some trivial improvements to the output formatting of the tools that are used to delete consumer groups and share groups. * In general, group IDs are enclosed in single qu

[PR] MINOR: Improve share coordinator record schemas [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield opened a new pull request, #19830: URL: https://github.com/apache/kafka/pull/19830 This PR makes some very small improvements to the record schemas for the share coordinator. * It removes the health warnings about incompatible changes. All changes are compatible now.

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109905205 ## core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala: ## @@ -17,16 +17,21 @@ package kafka.server import kafka.server.ClientQuotaManager.Base

[jira] [Updated] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-19259: --- Attachment: console-consumer-classic-vs-consumer.mov > Async consumer fetch intermittent del

Re: [PR] KAFKA-19310: (MINOR) Missing mocks for DelayedShareFetchTest tests related to Memory Records slicing [kafka]

2025-05-27 Thread via GitHub
adixitconfluent commented on PR #19823: URL: https://github.com/apache/kafka/pull/19823#issuecomment-2913794461 > > @apoorvmittal10 , the tests in `DelayedShareFetchTest` should only test whether the functionalities of `DelayedShareFetch` are working. Considering that, the changed functions

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954402#comment-17954402 ] Lianet Magrans commented on KAFKA-19259: Hey [~goyarpit], sorry I've been away b

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2110041979 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -155,6 +155,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] KAFKA-19310: (MINOR) Missing mocks for DelayedShareFetchTest tests related to Memory Records slicing [kafka]

2025-05-27 Thread via GitHub
adixitconfluent commented on PR #19823: URL: https://github.com/apache/kafka/pull/19823#issuecomment-2913779258 > The exception is because of the call `RecordBatch firstOverlapBatch = iterator.next();` in ShareFetchUtils when MemoryRecords is Empty. In the actual runs this scenario cannot h

Re: [PR] KAFKA-19310: (MINOR) Missing mocks for DelayedShareFetchTest tests related to Memory Records slicing [kafka]

2025-05-27 Thread via GitHub
apoorvmittal10 commented on PR #19823: URL: https://github.com/apache/kafka/pull/19823#issuecomment-2913786625 > @apoorvmittal10 , the tests in `DelayedShareFetchTest` should only test whether the functionalities of `DelayedShareFetch` are working. Considering that, the changed functions on

[jira] [Commented] (KAFKA-19266) Eliminate flakiness in test SharePartitionTest.testAcquisitionLockTimeoutForBatchesPostStartOffsetMovement

2025-05-27 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954406#comment-17954406 ] Abhinav Dixit commented on KAFKA-19266: --- The develocity link posted in description

[jira] [Resolved] (KAFKA-19266) Eliminate flakiness in test SharePartitionTest.testAcquisitionLockTimeoutForBatchesPostStartOffsetMovement

2025-05-27 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-19266. --- Resolution: Not A Problem > Eliminate flakiness in test > SharePartitionTest.testAcquisitio

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2110082036 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -451,6 +451,37 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
josefk31 commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2110071531 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -451,6 +451,37 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, }

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-27 Thread via GitHub
chia7712 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2109448024 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-27 Thread via GitHub
mingyen066 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2109523667 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-05-27 Thread via GitHub
johnny94 commented on code in PR #19793: URL: https://github.com/apache/kafka/pull/19793#discussion_r2110841393 ## server/src/main/java/org/apache/kafka/server/DelayedProduce.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] [WIP] MINOR: bump dependency test [kafka]

2025-05-27 Thread via GitHub
showuon closed pull request #19833: [WIP] MINOR: bump dependency test URL: https://github.com/apache/kafka/pull/19833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] KAFKA-19342: Authorization tests for alter share-group offsets [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield commented on code in PR #19826: URL: https://github.com/apache/kafka/pull/19826#discussion_r2111042578 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -288,7 +290,8 @@ class AuthorizerIntegrationTest extends AbstractAuthorize

Re: [PR] MINOR: Align tool output for deletion of groups [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield merged PR #19829: URL: https://github.com/apache/kafka/pull/19829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[PR] KAFKA-19336 Upgrade Jackson to 2.19.0 [kafka]

2025-05-27 Thread via GitHub
johnny94 opened a new pull request, #19835: URL: https://github.com/apache/kafka/pull/19835 `JsonNode.fields()` method has been deprecated by - https://github.com/FasterXML/jackson-databind/issues/4863 - https://github.com/FasterXML/jackson-databind/pull/4871 So modified accordi

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-05-27 Thread via GitHub
frankvicky commented on code in PR #19793: URL: https://github.com/apache/kafka/pull/19793#discussion_r2110852699 ## server/src/main/java/org/apache/kafka/server/DelayedProduce.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[PR] [WIP] MINOR: bump dependency test [kafka]

2025-05-27 Thread via GitHub
showuon opened a new pull request, #19834: URL: https://github.com/apache/kafka/pull/19834 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

[jira] [Created] (KAFKA-19344) Move assignable share partition method from describer to group spec.

2025-05-27 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-19344: --- Summary: Move assignable share partition method from describer to group spec. Key: KAFKA-19344 URL: https://issues.apache.org/jira/browse/KAFKA-19344 Project: K

Re: [PR] KAFKA-19335: Membership managers send negative epoch in JOINING [kafka]

2025-05-27 Thread via GitHub
lucasbru commented on code in PR #19818: URL: https://github.com/apache/kafka/pull/19818#discussion_r2109724048 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java: ## @@ -137,16 +137,23 @@ public void onHeartbeatSuccess(ShareGroupHe

[PR] [WIP] MINOR: bump dependency test [kafka]

2025-05-27 Thread via GitHub
showuon opened a new pull request, #19833: URL: https://github.com/apache/kafka/pull/19833 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] KAFKA-15370: Support Participation in 2PC (KIP-939) (K/N) [kafka]

2025-05-27 Thread via GitHub
artemlivshits commented on code in PR #19751: URL: https://github.com/apache/kafka/pull/19751#discussion_r2110652240 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -135,10 +136,10 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-19342: Authorization tests for alter share-group offsets [kafka]

2025-05-27 Thread via GitHub
DL1231 commented on code in PR #19826: URL: https://github.com/apache/kafka/pull/19826#discussion_r2110675097 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -288,7 +290,8 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrati

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-27 Thread via GitHub
cmccabe merged PR #19692: URL: https://github.com/apache/kafka/pull/19692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-27 Thread via GitHub
cmccabe merged PR #19689: URL: https://github.com/apache/kafka/pull/19689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR; Fix some Request toString methods (#19655) [kafka]

2025-05-27 Thread via GitHub
cmccabe merged PR #19690: URL: https://github.com/apache/kafka/pull/19690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-27 Thread via GitHub
cmccabe commented on PR #19692: URL: https://github.com/apache/kafka/pull/19692#issuecomment-2914348549 For failures, I see these, which appear to be unrelated: ``` [2025-05-12T23:40:32.246Z] Gradle Test Run :core:test > Gradle Test Executor 70 > UserClientIdQuotaTest > testProducerCon

Re: [PR] KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939) [kafka]

2025-05-27 Thread via GitHub
artemlivshits commented on code in PR #19714: URL: https://github.com/apache/kafka/pull/19714#discussion_r2110441628 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -884,6 +884,50 @@ public void abortTransaction() throws ProducerFencedExcept

[jira] [Updated] (KAFKA-19335) Streams group heartbeat sometimes fails with INVALID_REQUEST

2025-05-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19335: Component/s: streams > Streams group heartbeat sometimes fails with INVALID_REQUEST >

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-05-27 Thread via GitHub
mumrah commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2109579630 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -639,12 +637,6 @@ object KafkaMetadataLog extends Logging { nodeId ) -// Print a warnin

Re: [PR] MINOR: Fix initProducerId throttle time to non-zero [kafka]

2025-05-27 Thread via GitHub
jolshan merged PR #19801: URL: https://github.com/apache/kafka/pull/19801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[PR] KAFKA-19271: allow intercepting internal method call [kafka]

2025-05-27 Thread via GitHub
mjsax opened a new pull request, #19832: URL: https://github.com/apache/kafka/pull/19832 To allow intercepting the internal subscribe call to the async-consumer, we need to extend ConsumerWrapper interface accordingly, instead of returning the wrapped async-consumer back to the KS runtime.

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
ahuang98 commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109645774 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -155,6 +155,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, case

[jira] [Created] (KAFKA-19343) Misconfigured broker listeners causes unrecoverable controller error

2025-05-27 Thread Jira
José Armando García Sancio created KAFKA-19343: -- Summary: Misconfigured broker listeners causes unrecoverable controller error Key: KAFKA-19343 URL: https://issues.apache.org/jira/browse/KAFKA-19343

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109889445 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -155,6 +155,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109894483 ## core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala: ## @@ -17,16 +17,21 @@ package kafka.server import kafka.server.ClientQuotaManager.Base

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109894197 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -155,6 +155,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109905205 ## core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala: ## @@ -17,16 +17,21 @@ package kafka.server import kafka.server.ClientQuotaManager.Base

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109927773 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -451,6 +451,37 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109950623 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -155,6 +155,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-27 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109950623 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -155,6 +155,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] KAFKA-19335: Membership managers send negative epoch in JOINING [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield commented on code in PR #19818: URL: https://github.com/apache/kafka/pull/19818#discussion_r2108744389 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java: ## @@ -137,16 +137,23 @@ public void onHeartbeatSuccess(Shar

[jira] [Commented] (KAFKA-14895) Move AddPartitionsToTxnManager files to java

2025-05-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954375#comment-17954375 ] Justine Olshan commented on KAFKA-14895: [~brandboat] please take it. thanks! >

Re: [PR] KAFKA-19335: Membership managers send negative epoch in JOINING [kafka]

2025-05-27 Thread via GitHub
lucasbru commented on PR #19818: URL: https://github.com/apache/kafka/pull/19818#issuecomment-2913320474 @ShivsundarR @lianetm ready for re-review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-27 Thread via GitHub
kevin-wu24 commented on PR #19668: URL: https://github.com/apache/kafka/pull/19668#issuecomment-2913325616 A note about `KafkaRaftClient#maybeSendRequest` and the `RequestManager`, stemming sort of off of the redundancy mentioned for FETCH [here](https://github.com/apache/kafka/pull/19668#d

Re: [PR] KAFKA-19335: Membership managers send negative epoch in JOINING [kafka]

2025-05-27 Thread via GitHub
lucasbru commented on code in PR #19818: URL: https://github.com/apache/kafka/pull/19818#discussion_r2109726136 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManagerTest.java: ## @@ -561,10 +568,42 @@ public void testIgnoreHeartbeatResponse

[PR] KAFKA-19342: Authorization tests for alter share-group offsets [kafka]

2025-05-27 Thread via GitHub
AndrewJSchofield opened a new pull request, #19826: URL: https://github.com/apache/kafka/pull/19826 Add integration tests for alter share group offsets API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

  1   2   >