ahuang98 commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2109645774
########## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ########## @@ -155,6 +155,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, case None => new DefaultQuotaCallback } private val clientQuotaType = QuotaType.toClientQuotaType(quotaType) + private val activeQuotaEntities = new ConcurrentHashMap[ClientQuotaEntity, Boolean]() Review Comment: hm, but then we have to iterate through the entire map to understand what quota types are enabled? why doesn't it work to store the counts? e.g. having the keys be user, userClient, client, and the values are the number of those types which are active -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org