[jira] [Commented] (KAFKA-10731) Add Support for SSL hot reload

2025-05-10 Thread Jonathan Lacefield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950683#comment-17950683 ] Jonathan Lacefield commented on KAFKA-10731:  Is this a dup of https://issue

[jira] [Resolved] (KAFKA-19220) add tests to ensure the internal configs don't return by public APIs by default

2025-05-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19220. Fix Version/s: 4.1.0 Resolution: Fixed > add tests to ensure the internal configs d

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
FrankYang0529 commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083217276 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2253,44 +2262,49 @@ public void testPollAuthenticationFailure(GroupProto

Re: [PR] KAFKA-18695: Remove quorum=kraft from all integration tests [kafka]

2025-05-10 Thread via GitHub
chia7712 commented on code in PR #19633: URL: https://github.com/apache/kafka/pull/19633#discussion_r2083222547 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -2955,7 +2886,7 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerInteg

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-10 Thread via GitHub
chia7712 commented on code in PR #19661: URL: https://github.com/apache/kafka/pull/19661#discussion_r2083214768 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -54,33 +54,55 @@ public class FileRecords extends AbstractRecords implements Closeable

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
FrankYang0529 commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083214975 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -404,11 +405,11 @@ public void testPollReturnsRecords(GroupProtocol grou

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-05-10 Thread via GitHub
chia7712 merged PR #19482: URL: https://github.com/apache/kafka/pull/19482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-10 Thread via GitHub
chia7712 commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2083219505 ## core/src/main/scala/kafka/server/LocalLeaderEndPoint.scala: ## @@ -216,8 +221,8 @@ class LocalLeaderEndPoint(sourceBroker: BrokerEndPoint, partitionsWithEr

Re: [PR] KAFKA-19220: Add tests to ensure the internal configs don't return by public APIs by default [kafka]

2025-05-10 Thread via GitHub
chia7712 merged PR #19650: URL: https://github.com/apache/kafka/pull/19650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18695: Remove quorum=kraft from all integration tests [kafka]

2025-05-10 Thread via GitHub
chia7712 commented on PR #19633: URL: https://github.com/apache/kafka/pull/19633#issuecomment-2868963687 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-19243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Move logDirs config out of KafkaConfig [kafka]

2025-05-10 Thread via GitHub
chia7712 commented on PR #19579: URL: https://github.com/apache/kafka/pull/19579#issuecomment-2868974596 @Yunyung please check the failed tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-18695: Remove quorum=kraft from all integration tests [kafka]

2025-05-10 Thread via GitHub
mingyen066 commented on code in PR #19633: URL: https://github.com/apache/kafka/pull/19633#discussion_r2083223060 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -2955,7 +2886,7 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerInt

[jira] [Resolved] (KAFKA-19109) Don't print null in kafka-metadata-quorum describe status

2025-05-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19109. Fix Version/s: 4.1.0 Resolution: Fixed > Don't print null in kafka-metadata-quorum

Re: [PR] KAFKA-19109: Don't print null in kafka-metadata-quorum describe status [kafka]

2025-05-10 Thread via GitHub
chia7712 merged PR #19543: URL: https://github.com/apache/kafka/pull/19543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19206: ConsumerNetworkThread.cleanup() throws NullPointerException if initializeResources() previously failed [kafka]

2025-05-10 Thread via GitHub
chia7712 commented on code in PR #19569: URL: https://github.com/apache/kafka/pull/19569#discussion_r2083227021 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -339,11 +339,20 @@ void cleanup() { log.trace("Closing

Re: [PR] KAFKA-19068: Eliminate the duplicate type check in creating ControlRecord [kafka]

2025-05-10 Thread via GitHub
chia7712 merged PR #19346: URL: https://github.com/apache/kafka/pull/19346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19068) Eliminate the duplicate type check in creating ControlRecord

2025-05-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19068. Fix Version/s: 4.1.0 Resolution: Fixed > Eliminate the duplicate type check in crea

Re: [PR] KAFKA-18695: Remove quorum=kraft and kip932 from all integration tests [kafka]

2025-05-10 Thread via GitHub
mingyen066 commented on code in PR #19633: URL: https://github.com/apache/kafka/pull/19633#discussion_r2083223060 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -2955,7 +2886,7 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerInt

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-05-10 Thread via GitHub
kamalcph merged PR #19336: URL: https://github.com/apache/kafka/pull/19336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-17019) Producer TimeoutException should include root cause

2025-05-10 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950675#comment-17950675 ] sanghyeok An commented on KAFKA-17019: -- Thanks a lot! I assigned this issue to mys

[jira] [Assigned] (KAFKA-17019) Producer TimeoutException should include root cause

2025-05-10 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sanghyeok An reassigned KAFKA-17019: Assignee: sanghyeok An > Producer TimeoutException should include root cause > --

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
m1a2st commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083125691 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2674,8 +2690,8 @@ public void testCurrentLag(GroupProtocol groupProtocol) thro

Re: [PR] KAFKA-19248: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-05-10 Thread via GitHub
snehashisp commented on PR #18325: URL: https://github.com/apache/kafka/pull/18325#issuecomment-2868819839 Hi @gharris1727. Have addressed the comments in this PR, PTAL soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] MINOR: Move logDirs config out of KafkaConfig [kafka]

2025-05-10 Thread via GitHub
TaiJuWu commented on code in PR #19579: URL: https://github.com/apache/kafka/pull/19579#discussion_r2083357389 ## checkstyle/import-control-clients-integration-tests.xml: ## @@ -21,7 +21,6 @@ - Review Comment: Should we change to `` ? In order to reminde

Re: [PR] KAFKA-17339: LocalLogManager should support RaftClient#schedulePreparedAppend [kafka]

2025-05-10 Thread via GitHub
TaiJuWu commented on PR #17544: URL: https://github.com/apache/kafka/pull/17544#issuecomment-2869289547 @peterxcli Could you help to resolve this conflict and re-trigger CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] MINOR: Move logDirs config out of KafkaConfig [kafka]

2025-05-10 Thread via GitHub
TaiJuWu commented on code in PR #19579: URL: https://github.com/apache/kafka/pull/19579#discussion_r2083357389 ## checkstyle/import-control-clients-integration-tests.xml: ## @@ -21,7 +21,6 @@ - Review Comment: Should we change to `` ? In order to reminde

[PR] KAFKA-13555: Use input partitions for StickyTaskAssignor [WIP] [kafka]

2025-05-10 Thread via GitHub
lorcanj opened a new pull request, #19670: URL: https://github.com/apache/kafka/pull/19670 Addresses: [KAFKA-13555](https://issues.apache.org/jira/browse/KAFKA-13555) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
Yunyung commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083239520 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -404,11 +405,11 @@ public void testPollReturnsRecords(GroupProtocol groupProto

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-10 Thread via GitHub
chia7712 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2083236898 ## clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java: ## @@ -78,6 +78,24 @@ public static AlterShareGroupOffsetsRequest parse(R

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-05-10 Thread via GitHub
apalan60 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2868724157 > @apalan60 thanks for this patch. Is it possible to replace `ProducerStateManagerConfig` by `TransactionLogConfig`? In the `DynamicProducerStateManagerConfig` we create `TransactionLogC

[PR] jprnt01/streams/examples/src/main/java/org/apache/kafka/streams/exampl… [kafka]

2025-05-10 Thread via GitHub
aryojp opened a new pull request, #19671: URL: https://github.com/apache/kafka/pull/19671 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comme

Re: [PR] MINOR: Fix some Request toString methods [kafka]

2025-05-10 Thread via GitHub
cmccabe merged PR #19655: URL: https://github.com/apache/kafka/pull/19655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-10 Thread via GitHub
ahuang98 commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082083752 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTime

[jira] [Comment Edited] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-10 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950685#comment-17950685 ] Arpit Goyal edited comment on KAFKA-19259 at 5/10/25 1:39 PM:

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-10 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950685#comment-17950685 ] Arpit Goyal commented on KAFKA-19259: - Hi Lianet Can i pick this ? > Async consume

[jira] [Created] (KAFKA-19261) Move ConnectionQuotas to server module

2025-05-10 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19261: -- Summary: Move ConnectionQuotas to server module Key: KAFKA-19261 URL: https://issues.apache.org/jira/browse/KAFKA-19261 Project: Kafka Issue Type: Sub-ta

[jira] [Assigned] (KAFKA-19261) Move ConnectionQuotas to server module

2025-05-10 Thread Chang Chi Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chang Chi Hsu reassigned KAFKA-19261: - Assignee: Chang Chi Hsu (was: Chia-Ping Tsai) > Move ConnectionQuotas to server module

[jira] [Resolved] (KAFKA-17274) Remove deprecate `TransactionLogMessageFormatter`, GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`

2025-05-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17274. Fix Version/s: (was: 5.0.0) Resolution: Duplicate the deprecated classes are al

[jira] [Created] (KAFKA-19260) Move LoggingController to server module

2025-05-10 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19260: -- Summary: Move LoggingController to server module Key: KAFKA-19260 URL: https://issues.apache.org/jira/browse/KAFKA-19260 Project: Kafka Issue Type: Sub-t

[jira] [Assigned] (KAFKA-19260) Move LoggingController to server module

2025-05-10 Thread Yunchi Pang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunchi Pang reassigned KAFKA-19260: --- Assignee: Yunchi Pang (was: Chia-Ping Tsai) > Move LoggingController to server module > --

[jira] [Commented] (KAFKA-18486) Remove ReplicaManager#becomeLeaderOrFollower

2025-05-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950705#comment-17950705 ] Chia-Ping Tsai commented on KAFKA-18486: [~dajac] any updates? > Remove Replica

Re: [PR] MINOR: Move logDirs config out of KafkaConfig [kafka]

2025-05-10 Thread via GitHub
Yunyung commented on PR #19579: URL: https://github.com/apache/kafka/pull/19579#issuecomment-2869081857 > @Yunyung please check the failed tests Done. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-13555: Use input partitions for StickyTaskAssignor [WIP] [kafka]

2025-05-10 Thread via GitHub
lorcanj commented on PR #19670: URL: https://github.com/apache/kafka/pull/19670#issuecomment-2869110421 The assignment logic for active tasks now primarily uses the number of input partitions as a proxy for individual task weight. The trigger for rebalancing active tasks considers the

[jira] [Commented] (KAFKA-13555) Consider number if input topic partitions for task assignment

2025-05-10 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950712#comment-17950712 ] Lorcan commented on KAFKA-13555: Hi all, here's the PR link: [https://github.com/apache

[jira] [Comment Edited] (KAFKA-13555) Consider number if input topic partitions for task assignment

2025-05-10 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950712#comment-17950712 ] Lorcan edited comment on KAFKA-13555 at 5/10/25 7:02 PM: - Hi all

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083380718 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -404,11 +405,11 @@ public void testPollReturnsRecords(GroupProtocol groupProtoco

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083380270 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -404,11 +405,11 @@ public void testPollReturnsRecords(GroupProtocol groupProtoco

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083381315 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2253,44 +2262,49 @@ public void testPollAuthenticationFailure(GroupProtocol gro

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083381645 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3513,6 +3533,7 @@ public void testEmptyGroupId(GroupProtocol groupProtocol) {

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083381608 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3505,6 +3524,7 @@ public void testClientInstanceIdNoTelemetryReporterRegistered

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083381191 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2209,26 +2215,29 @@ public void testPartitionsForNonExistingTopic(GroupProtocol

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r208338 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1959,17 +1963,19 @@ public void testCloseShouldBeIdempotent(GroupProtocol group

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on PR #19669: URL: https://github.com/apache/kafka/pull/19669#issuecomment-2869374025 Thanks for the review. Updated the PR and left a few replies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-05-10 Thread via GitHub
github-actions[bot] commented on PR #19496: URL: https://github.com/apache/kafka/pull/19496#issuecomment-2869378168 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] jprnt02 [kafka]

2025-05-10 Thread via GitHub
aryojp opened a new pull request, #19672: URL: https://github.com/apache/kafka/pull/19672 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comme

Re: [PR] KAFKA-17688 Move TransactionsTest to storage module [kafka]

2025-05-10 Thread via GitHub
github-actions[bot] commented on PR #17732: URL: https://github.com/apache/kafka/pull/17732#issuecomment-2869395389 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P