Re: [PR] KAFKA-17184: Fix the error thrown while accessing the RemoteIndexCache [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19462: URL: https://github.com/apache/kafka/pull/19462#issuecomment-2817822197 @kamalcph the new test `testPendingTaskSize` could be hanging (see https://github.com/apache/kafka/actions/runs/14560322254/job/40842877645?pr=19521), and I have opened https://issues.ap

Re: [PR] MINOR: Fix typo in ApiKeyVersionsProvider exception message [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19521: URL: https://github.com/apache/kafka/pull/19521#issuecomment-2817819997 the hanging test is traced by https://issues.apache.org/jira/browse/KAFKA-19180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (KAFKA-19180) Fix the hanging testPendingTaskSize

2025-04-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19180: -- Summary: Fix the hanging testPendingTaskSize Key: KAFKA-19180 URL: https://issues.apache.org/jira/browse/KAFKA-19180 Project: Kafka Issue Type: Improveme

[jira] [Commented] (KAFKA-19180) Fix the hanging testPendingTaskSize

2025-04-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946065#comment-17946065 ] Chia-Ping Tsai commented on KAFKA-19180: the check of `assertEquals(2, scheduler

Re: [PR] MINOR: Fix typo in ApiKeyVersionsProvider exception message [kafka]

2025-04-21 Thread via GitHub
chia7712 merged PR #19521: URL: https://github.com/apache/kafka/pull/19521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19179: remove the dot from thread_dump_url [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on code in PR #19525: URL: https://github.com/apache/kafka/pull/19525#discussion_r2052080927 ## .github/scripts/junit.py: ## @@ -361,7 +361,7 @@ def split_report_path(base_path: str, report_path: str) -> Tuple[str, str]: failure_messages.append(f"Gra

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2817853834 the timeout is traced by https://issues.apache.org/jira/browse/KAFKA-19180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (KAFKA-19180) Fix the hanging testPendingTaskSize

2025-04-21 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946067#comment-17946067 ] Jhen-Yung Hsu commented on KAFKA-19180: --- I'm working on this, thanks :) > Fix the

[jira] [Assigned] (KAFKA-19180) Fix the hanging testPendingTaskSize

2025-04-21 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-19180: - Assignee: Jhen-Yung Hsu (was: Chia-Ping Tsai) > Fix the hanging testPendingTaskSize >

[PR] KAFKA-19180: Fix the hanging testPendingTaskSize (WIP) [kafka]

2025-04-21 Thread via GitHub
Yunyung opened a new pull request, #19526: URL: https://github.com/apache/kafka/pull/19526 Jira: https://issues.apache.org/jira/browse/KAFKA-19180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-19179: remove the dot from thread_dump_url [kafka]

2025-04-21 Thread via GitHub
FrankYang0529 commented on code in PR #19525: URL: https://github.com/apache/kafka/pull/19525#discussion_r2052129769 ## .github/scripts/junit.py: ## @@ -361,7 +361,7 @@ def split_report_path(base_path: str, report_path: str) -> Tuple[str, str]: failure_messages.append(

Re: [PR] KAFKA-19180: Fix the hanging testPendingTaskSize (WIP) [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on code in PR #19526: URL: https://github.com/apache/kafka/pull/19526#discussion_r2052123890 ## core/src/test/scala/unit/kafka/utils/SchedulerTest.scala: ## @@ -220,7 +220,9 @@ class SchedulerTest { scheduler.scheduleOnce("task1", task1, 0) scheduler

Re: [PR] KAFKA-19042: [6/N] Move PlaintextConsumerFetchTest to client-integration-tests module [kafka]

2025-04-21 Thread via GitHub
m1a2st commented on PR #19520: URL: https://github.com/apache/kafka/pull/19520#issuecomment-2819822694 Thanks for @FrankYang0529 comments, addressed all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-4759 Add support for IPv4 and IPv6 ranges in AclAuthorizer [kafka]

2025-04-21 Thread via GitHub
github-actions[bot] commented on PR #9937: URL: https://github.com/apache/kafka/pull/9937#issuecomment-2819983618 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-4759 Add support for IPv4 and IPv6 ranges in AclAuthorizer [kafka]

2025-04-21 Thread via GitHub
github-actions[bot] closed pull request #9937: KAFKA-4759 Add support for IPv4 and IPv6 ranges in AclAuthorizer URL: https://github.com/apache/kafka/pull/9937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18046: cache calls to LoggerFactory.getLogger() inside LogContext [kafka]

2025-04-21 Thread via GitHub
github-actions[bot] commented on PR #17896: URL: https://github.com/apache/kafka/pull/17896#issuecomment-2819983767 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18046: cache calls to LoggerFactory.getLogger() inside LogContext [kafka]

2025-04-21 Thread via GitHub
github-actions[bot] closed pull request #17896: KAFKA-18046: cache calls to LoggerFactory.getLogger() inside LogContext URL: https://github.com/apache/kafka/pull/17896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-19179: remove the dot from thread_dump_url [kafka]

2025-04-21 Thread via GitHub
frankvicky merged PR #19525: URL: https://github.com/apache/kafka/pull/19525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[PR] KAFKA-19183: Remove kafka.utils.Pool and refactor usages [kafka]

2025-04-21 Thread via GitHub
RaphaelFakhri opened a new pull request, #19531: URL: https://github.com/apache/kafka/pull/19531 ## Problem The `kafka.utils.Pool` class is a thin Scala wrapper around `java.util.concurrent.ConcurrentHashMap`. While it provides a convenient `getAndMaybePut` method, the underlying fun

Re: [PR] KAFKA-19139 Plugin#wrapInstance should use LinkedHashMap instead of Map [kafka]

2025-04-21 Thread via GitHub
frankvicky commented on code in PR #19519: URL: https://github.com/apache/kafka/pull/19519#discussion_r2053226336 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3746,7 +3746,9 @@ private MetricName expectedMetricName(String clientId, S

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

2025-04-21 Thread via GitHub
m1a2st commented on PR #19393: URL: https://github.com/apache/kafka/pull/19393#issuecomment-2820100352 Thanks for @chia7712 comments, addressed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-18322) Add StickyTaskAssignor

2025-04-21 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946318#comment-17946318 ] Alieh Saeedi commented on KAFKA-18322: -- PR: https://github.com/apache/kafka/pull/18

Re: [PR] [KAFKA-15580] First attempt at UncleanRecoveryManager [kafka]

2025-04-21 Thread via GitHub
github-actions[bot] commented on PR #19468: URL: https://github.com/apache/kafka/pull/19468#issuecomment-2819963675 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19048: Minimal movement replica balancing algorithm for reassignment [kafka]

2025-04-21 Thread via GitHub
github-actions[bot] commented on PR #19297: URL: https://github.com/apache/kafka/pull/19297#issuecomment-2819963775 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-04-21 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2819963821 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-04-21 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2819963851 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-19131) Exception thrown while updating the RemoteLogReader threads

2025-04-21 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946290#comment-17946290 ] PoAn Yang commented on KAFKA-19131: --- [~ckamal] yes, I'm working on it. I will create a

[PR] Add demo template for transactional client [kafka]

2025-04-21 Thread via GitHub
k-raina opened a new pull request, #15913: URL: https://github.com/apache/kafka/pull/15913 This is example code template for Transactional Client. This code assumes that new Exception types have already been implemented. This PR will be merged after: https://cwiki.apache.org/confluen

[jira] [Commented] (KAFKA-19131) Exception thrown while updating the RemoteLogReader threads

2025-04-21 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946182#comment-17946182 ] Kamal Chandraprakash commented on KAFKA-19131: -- [~yangpoan]  Are you worki

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-04-21 Thread via GitHub
junrao commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2052715308 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -585,32 +585,62 @@ object KafkaMetadataLog extends Logging { config: MetadataLogConfig, nodeId:

[jira] [Commented] (KAFKA-19014) Potential race condition in remote-log-reader and remote-log-index-cleaner thread

2025-04-21 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946185#comment-17946185 ] Kamal Chandraprakash commented on KAFKA-19014: -- In KAFKA-17184, a 10 second

Re: [PR] KAFKA-19019: Add support for remote storage fetch for share groups [kafka]

2025-04-21 Thread via GitHub
junrao commented on code in PR #19437: URL: https://github.com/apache/kafka/pull/19437#discussion_r2052746487 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -277,22 +316,32 @@ public boolean tryComplete() { return false; } catch (Exc

[jira] [Comment Edited] (KAFKA-19014) Potential race condition in remote-log-reader and remote-log-index-cleaner thread

2025-04-21 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946185#comment-17946185 ] Kamal Chandraprakash edited comment on KAFKA-19014 at 4/21/25 5:26 PM: ---

[jira] [Resolved] (KAFKA-19014) Potential race condition in remote-log-reader and remote-log-index-cleaner thread

2025-04-21 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash resolved KAFKA-19014. -- Fix Version/s: 4.1.0 Assignee: Kamal Chandraprakash Resolution:

Re: [PR] [WIP]: Backport java 24 all2 [kafka]

2025-04-21 Thread via GitHub
showuon closed pull request #19368: [WIP]: Backport java 24 all2 URL: https://github.com/apache/kafka/pull/19368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-19180: Fix the hanging testPendingTaskSize [kafka]

2025-04-21 Thread via GitHub
kamalcph commented on PR #19526: URL: https://github.com/apache/kafka/pull/19526#issuecomment-2818316925 LGTM, thanks for fixing this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Assigned] (KAFKA-19069) DumpLogSegments does not dump the LEADER_CHANGE record

2025-04-21 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-19069: - Assignee: Jhen-Yung Hsu (was: Cheng Yi Chang) > DumpLogSegments does not dump the LEAD

[jira] [Commented] (KAFKA-19069) DumpLogSegments does not dump the LEADER_CHANGE record

2025-04-21 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946164#comment-17946164 ] Jhen-Yung Hsu commented on KAFKA-19069: --- I'm working on this, thanks :) > DumpLog

Re: [PR] KAFKA-14487: Move LogManager static methods/fields to storage module [kafka]

2025-04-21 Thread via GitHub
mimaison merged PR #19302: URL: https://github.com/apache/kafka/pull/19302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19181) Investigate system test failures

2025-04-21 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-19181: - Summary: Investigate system test failures Key: KAFKA-19181 URL: https://issues.apache.org/jira/browse/KAFKA-19181 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-21 Thread via GitHub
apoorvmittal10 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2052300583 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -122,15 +113,9 @@ public synchronized ShareSession remove(ShareSessio

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-21 Thread via GitHub
apoorvmittal10 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2052300583 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -122,15 +113,9 @@ public synchronized ShareSession remove(ShareSessio

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-21 Thread via GitHub
ahuang98 commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2052945464 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftVersionUpgrade.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-21 Thread via GitHub
apoorvmittal10 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2052247183 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -122,15 +113,9 @@ public synchronized ShareSession remove(ShareSessio

[jira] [Commented] (KAFKA-19183) Move Pool and PoolTest to server module

2025-04-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946119#comment-17946119 ] Chia-Ping Tsai commented on KAFKA-19183: It seems to me Pool is unnecessary afte

Re: [PR] KAFKA-19179: remove the dot from thread_dump_url [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on code in PR #19525: URL: https://github.com/apache/kafka/pull/19525#discussion_r2052355478 ## .github/scripts/junit.py: ## @@ -361,7 +361,7 @@ def split_report_path(base_path: str, report_path: str) -> Tuple[str, str]: failure_messages.append(f"Gra

[jira] [Commented] (KAFKA-19183) Move Pool and PoolTest to server module

2025-04-21 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946124#comment-17946124 ] PoAn Yang commented on KAFKA-19183: --- [~chia7712], thanks for the suggestion. I will ch

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-21 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2052372535 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -122,15 +113,9 @@ public synchronized ShareSession remove(ShareSessio

[jira] [Updated] (KAFKA-19183) Replace Pool with ConcurrentHashMap

2025-04-21 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19183: -- Description: 1. Replace Pool.scala with ConcurrentHashMap directly. 2. Remove PoolTest.scala. was:

[jira] [Updated] (KAFKA-19183) Replace Pool with ConcurrentHashMap

2025-04-21 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19183: -- Summary: Replace Pool with ConcurrentHashMap (was: Move Pool and PoolTest to server module) > Replac

Re: [PR] MINOR: ignore null judgement in LogCleaner [kafka]

2025-04-21 Thread via GitHub
frankvicky merged PR #19524: URL: https://github.com/apache/kafka/pull/19524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-17573: Move KRaftMetadataCache to metadata module [kafka]

2025-04-21 Thread via GitHub
FrankYang0529 commented on PR #19232: URL: https://github.com/apache/kafka/pull/19232#issuecomment-2818879120 @chia7712, I addressed all comments. Could you review again when you have time? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-04-21 Thread via GitHub
jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2052656744 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,21 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-21 Thread via GitHub
ahuang98 commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2052997970 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2130,6 +2136,444 @@ void testFollowerSendsUpdateVoter() throws Exception {

Re: [PR] KAFKA-19179: remove the dot from thread_dump_url [kafka]

2025-04-21 Thread via GitHub
frankvicky commented on PR #19525: URL: https://github.com/apache/kafka/pull/19525#issuecomment-2818419704 @gongxuanzhang: Could you please merge the trunk to include #19526 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-19160: Improve performance of fetching stable offsets [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on code in PR #19497: URL: https://github.com/apache/kafka/pull/19497#discussion_r2052397193 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -650,24 +658,18 @@ public int deleteAllOffsets( // Del

[jira] [Commented] (KAFKA-19183) Replace Pool with ConcurrentHashMap

2025-04-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946134#comment-17946134 ] Ismael Juma commented on KAFKA-19183: - The main difference is that `Pool` sets the v

[jira] [Commented] (KAFKA-19183) Replace Pool with ConcurrentHashMap

2025-04-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946135#comment-17946135 ] Ismael Juma commented on KAFKA-19183: - Not sure if that's worth having a separate cl

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-21 Thread via GitHub
apalan60 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2818448633 @chia7712 Thanks for the kind reminder, merging the trunk now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2818434084 @apalan60 could you please rebase code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (KAFKA-19183) Replace Pool with ConcurrentHashMap

2025-04-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946137#comment-17946137 ] Chia-Ping Tsai commented on KAFKA-19183: {quote} Not sure if that's worth having

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2052293842 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -122,15 +113,9 @@ public synchronized ShareSession remove(ShareSession ses

Re: [PR] KAFKA-19180: Fix the hanging testPendingTaskSize [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19526: URL: https://github.com/apache/kafka/pull/19526#issuecomment-2818242350 @kamalcph WDYT? This PR uses a loop to ensure the test passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Resolved] (KAFKA-19180) Fix the hanging testPendingTaskSize

2025-04-21 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash resolved KAFKA-19180. -- Fix Version/s: 4.1.0 Resolution: Fixed > Fix the hanging testPendingTas

[PR] [WIP]KAFKA-18896 add KIP-877 support for Login [kafka]

2025-04-21 Thread via GitHub
m1a2st opened a new pull request, #19527: URL: https://github.com/apache/kafka/pull/19527 add KIP-877 support for Login -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-21 Thread via GitHub
apoorvmittal10 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2052543453 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSession.java: ## @@ -138,6 +118,12 @@ public synchronized Map> up return result;

[jira] [Commented] (KAFKA-18216) High water mark or last stable offset aren't always updated after a fetch request is completed

2025-04-21 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946150#comment-17946150 ] TengYao Chi commented on KAFKA-18216: - Hi [~pnee] [~lianetm]  I have tried to repro

[jira] [Created] (KAFKA-19184) Document kraft version upgrade

2025-04-21 Thread Jira
José Armando García Sancio created KAFKA-19184: -- Summary: Document kraft version upgrade Key: KAFKA-19184 URL: https://issues.apache.org/jira/browse/KAFKA-19184 Project: Kafka Is

Re: [PR] KAFKA-19019: Add support for remote storage fetch for share groups [kafka]

2025-04-21 Thread via GitHub
junrao commented on code in PR #19437: URL: https://github.com/apache/kafka/pull/19437#discussion_r2052697705 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -252,13 +291,19 @@ public boolean tryComplete() { // replicaManager.readFromLog t

Re: [PR] MINOR: Use readable interface to parse response [kafka]

2025-04-21 Thread via GitHub
jsancio commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2052833219 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -152,19 +151,19 @@ public boolean zkMigrationReady() { return data.zk

Re: [PR] KAFKA-19156: removed group.share.max.groups config and initialized ShareSessionCache with maxEntries set as group.share.max.share.sessions [kafka]

2025-04-21 Thread via GitHub
apoorvmittal10 commented on code in PR #19505: URL: https://github.com/apache/kafka/pull/19505#discussion_r2052858046 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigTest.java: ## @@ -89,24 +87,6 @@ public void testInvalidConfig

Re: [PR] MINOR: Use readable interface to parse response [kafka]

2025-04-21 Thread via GitHub
jsancio commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2052834226 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java: ## @@ -106,189 +107,189 @@ public static AbstractResponse parseResponse(ByteBuffer buf

Re: [PR] KAFKA-17541:[1/2] Improve handling of delivery count [kafka]

2025-04-21 Thread via GitHub
apoorvmittal10 commented on code in PR #19430: URL: https://github.com/apache/kafka/pull/19430#discussion_r2052861184 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -197,6 +197,16 @@ public byte id() { } } +/** + * The DeliveryCountOp

Re: [PR] MINOR: redundant gradle expression is removed [kafka]

2025-04-21 Thread via GitHub
apoorvmittal10 commented on PR #19200: URL: https://github.com/apache/kafka/pull/19200#issuecomment-2819324703 @dejan2609 Sorry for the delay, I was away for sometime. The PR is on my pending list for review now. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

2025-04-21 Thread via GitHub
mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r2052898296 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -335,6 +345,28 @@ private static QueryResult runWindowRangeQuery(final Que

Re: [PR] MINOR: Use readable interface to parse response [kafka]

2025-04-21 Thread via GitHub
soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2052926304 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -152,19 +151,19 @@ public boolean zkMigrationReady() { return data

[jira] [Resolved] (KAFKA-19019) Verify Share Fetch with Tiered Storage

2025-04-21 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-19019. - Fix Version/s: 4.1.0 Resolution: Fixed merged the PR to trunk > Verify Share Fetch with Tiered S

Re: [PR] KAFKA-19019: Add support for remote storage fetch for share groups [kafka]

2025-04-21 Thread via GitHub
junrao merged PR #19437: URL: https://github.com/apache/kafka/pull/19437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-21 Thread via GitHub
cmccabe commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2053109111 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -225,6 +272,32 @@ private ApiError updateFeature( if (featureName.equal

Re: [PR] KAFKA-19082: [1/4] Add client config for enable2PC and overloaded initProducerId (KIP-939) [kafka]

2025-04-21 Thread via GitHub
rreddy-22 commented on code in PR #19429: URL: https://github.com/apache/kafka/pull/19429#discussion_r2053115299 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -273,17 +276,29 @@ public TransactionManager(final LogContext logC

Re: [PR] KAFKA-19082: [1/4] Add client config for enable2PC and overloaded initProducerId (KIP-939) [kafka]

2025-04-21 Thread via GitHub
rreddy-22 commented on code in PR #19429: URL: https://github.com/apache/kafka/pull/19429#discussion_r2053117512 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -654,6 +657,46 @@ public void initTransactions() { transactionManager.ma

Re: [PR] KAFKA-19042: [6/N] Move PlaintextConsumerFetchTest to client-integration-tests module [kafka]

2025-04-21 Thread via GitHub
FrankYang0529 commented on code in PR #19520: URL: https://github.com/apache/kafka/pull/19520#discussion_r2052284015 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientsTestUtils.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-19180: Fix the hanging testPendingTaskSize [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19526: URL: https://github.com/apache/kafka/pull/19526#issuecomment-2818302529 I'm going to merge it to unlock other PRs. Please feel free to leave comments and we can address them in follow-up -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-19180: Fix the hanging testPendingTaskSize [kafka]

2025-04-21 Thread via GitHub
chia7712 merged PR #19526: URL: https://github.com/apache/kafka/pull/19526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18760: Deprecate Optional and return String from public Endpoint#listener [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19191: URL: https://github.com/apache/kafka/pull/19191#issuecomment-2818304933 @FrankYang0529 please rebase code to include the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-19068: Eliminate the duplicate type check in creating ControlRecord [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19346: URL: https://github.com/apache/kafka/pull/19346#issuecomment-2818305443 @Rancho-7 please rebase code to include recent fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (KAFKA-18933) Add integration tests for :clients outside of :core

2025-04-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18933. Fix Version/s: 4.1.0 Resolution: Fixed > Add integration tests for :clients outside

[jira] [Created] (KAFKA-19182) Move SchedulerTest to server module

2025-04-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19182: -- Summary: Move SchedulerTest to server module Key: KAFKA-19182 URL: https://issues.apache.org/jira/browse/KAFKA-19182 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-19179: remove the dot from thread_dump_url [kafka]

2025-04-21 Thread via GitHub
gongxuanzhang commented on code in PR #19525: URL: https://github.com/apache/kafka/pull/19525#discussion_r2052352772 ## .github/scripts/junit.py: ## @@ -361,7 +361,7 @@ def split_report_path(base_path: str, report_path: str) -> Tuple[str, str]: failure_messages.append(

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2025-04-21 Thread via GitHub
chia7712 merged PR #17099: URL: https://github.com/apache/kafka/pull/17099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19183) Move Pool and PoolTest to server module

2025-04-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-19183: - Summary: Move Pool and PoolTest to server module Key: KAFKA-19183 URL: https://issues.apache.org/jira/browse/KAFKA-19183 Project: Kafka Issue Type: Sub-task

[jira] [Resolved] (KAFKA-8830) KIP-512: make Record Headers available in onAcknowledgement

2025-04-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-8830. --- Fix Version/s: 4.1.0 Resolution: Fixed > KIP-512: make Record Headers available in onA

[PR] KAFKA-19178: Replace Vector by ArrayList for PluginClassLoader#getResources [kafka]

2025-04-21 Thread via GitHub
Rancho-7 opened a new pull request, #19529: URL: https://github.com/apache/kafka/pull/19529 jira: https://issues.apache.org/jira/browse/KAFKA-19178 The vector is a synchronized collection, and in the case we don't need to sync. Also, we can use `Collections.enumeration` to convert col