apoorvmittal10 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2052543453
########## server/src/main/java/org/apache/kafka/server/share/session/ShareSession.java: ########## @@ -138,6 +118,12 @@ public synchronized Map<ModifiedTopicIdPartitionType, List<TopicIdPartition>> up return result; } + public synchronized int updateCachedSize() { Review Comment: This method needs javadoc comments saying specially about the return data and what the return value represents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org