[jira] [Created] (KAFKA-19106) Improve Connect SourceTask commit()

2025-04-08 Thread Sudesh Wasnik (Jira)
Sudesh Wasnik created KAFKA-19106: - Summary: Improve Connect SourceTask commit() Key: KAFKA-19106 URL: https://issues.apache.org/jira/browse/KAFKA-19106 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-08 Thread via GitHub
smjn commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r2032615403 ## clients/src/main/java/org/apache/kafka/common/requests/DeleteShareGroupOffsetsRequest.java: ## @@ -59,19 +55,20 @@ public DeleteShareGroupOffsetsRequest(DeleteShareGro

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-08 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r2032764208 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -10780,6 +10784,156 @@ public void testAlterShareGroupOffsetsWithErrorI

Re: [PR] KAFKA-19090: Move DelayedFuture and DelayedFuturePurgatory to server-common module [kafka]

2025-04-08 Thread via GitHub
mimaison commented on code in PR #19390: URL: https://github.com/apache/kafka/pull/19390#discussion_r2032754487 ## core/src/test/scala/integration/kafka/server/DelayedFutureTest.scala: ## @@ -16,22 +16,22 @@ */ package integration.kafka.server -import kafka.server.DelayedFu

Re: [PR] MINOR: Small cleanups in server's tests [kafka]

2025-04-08 Thread via GitHub
wernerdv commented on code in PR #19395: URL: https://github.com/apache/kafka/pull/19395#discussion_r2032448060 ## server/src/test/java/org/apache/kafka/network/SocketServerConfigsTest.java: ## @@ -22,8 +22,8 @@ import org.junit.jupiter.api.Test; -import java.util.Arrays;

[PR] Fix Patch: CVE-2023-25194 for Kafka 2.8.2 [kafka]

2025-04-08 Thread via GitHub
atu-sharm opened a new pull request, #19412: URL: https://github.com/apache/kafka/pull/19412 Backporting the CVE-2023-25194 for Kafka 2.8.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-19101 Remove ControllerMutationQuotaManager#throttleTimeMs unused parameter [kafka]

2025-04-08 Thread via GitHub
frankvicky commented on code in PR #19410: URL: https://github.com/apache/kafka/pull/19410#discussion_r2032789570 ## core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala: ## @@ -63,7 +63,7 @@ abstract class AbstractControllerMutationQuota(private val time: Time

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-08 Thread via GitHub
mimaison commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2032797613 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java: ## @@ -0,0 +1,652 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Created] (KAFKA-19105) Add Audit Logging for Authentication Events with Performance Consideration

2025-04-08 Thread lujie (Jira)
lujie created KAFKA-19105: - Summary: Add Audit Logging for Authentication Events with Performance Consideration Key: KAFKA-19105 URL: https://issues.apache.org/jira/browse/KAFKA-19105 Project: Kafka

Re: [PR] Add a recommendation on choosing the size of the block cache for RocksDB [kafka]

2025-04-08 Thread via GitHub
github-actions[bot] commented on PR #18280: URL: https://github.com/apache/kafka/pull/18280#issuecomment-2785142809 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-08 Thread via GitHub
AndrewJSchofield commented on PR #18976: URL: https://github.com/apache/kafka/pull/18976#issuecomment-2785760847 A couple of compile failures. The clients build with Java 11 and some of the changes made recently I think require Java 16+. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-19100: Use ProcessRole instead of String in AclApis [kafka]

2025-04-08 Thread via GitHub
mimaison merged PR #19406: URL: https://github.com/apache/kafka/pull/19406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19037: Integrate consumer-side code with Streams [kafka]

2025-04-08 Thread via GitHub
lucasbru commented on PR #19377: URL: https://github.com/apache/kafka/pull/19377#issuecomment-2785874803 PS: @cadonna looks like you have to add back `@SuppresWarnings(this-escape)` for CI to pass -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-08 Thread via GitHub
smjn commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r2032597713 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1947,13 +1947,27 @@ default ListShareGroupOffsetsResult listShareGroupOffsets(Map groupIds) {

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-08 Thread via GitHub
smjn commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r2032600549 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupOffsetsOptions.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-08 Thread via GitHub
smjn commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r2032618471 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -10780,6 +10784,156 @@ public void testAlterShareGroupOffsetsWithErrorInOnePartit

Re: [PR] MINOR: Small cleanups in server tests [kafka]

2025-04-08 Thread via GitHub
mimaison merged PR #19395: URL: https://github.com/apache/kafka/pull/19395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] [WIP] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-04-08 Thread via GitHub
AndrewJSchofield commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2785568108 @JimmyWang6 Thanks for taking another look at this. I don't think you've discovered problems, just realised the manner in which this operation will have to work. I would look at

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-08 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2032648047 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1407,7 +1408,7 @@ class LogManager(logDirs: Seq[File], } } finally { if (cleaner != null)

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-08 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2032650604 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1384,7 +1385,7 @@ class LogManager(logDirs: Seq[File], val deletableLogs = { if (cleaner != null)

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-08 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2032661374 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java: ## @@ -0,0 +1,652 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-08 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2032529508 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2090,6 +2091,307 @@ public void testComplexS

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-08 Thread via GitHub
m1a2st commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2032907056 ## core/src/main/java/kafka/server/QuotaFactory.java: ## @@ -113,22 +116,43 @@ public void shutdown() { } } -public static QuotaManagers instantiate(

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-08 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2032967770 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -169,6 +169,9 @@ public void start(Map props) { "refreshi

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-08 Thread via GitHub
mimaison commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2032963353 ## core/src/main/java/kafka/server/QuotaFactory.java: ## @@ -113,22 +116,43 @@ public void shutdown() { } } -public static QuotaManagers instantiat

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-08 Thread via GitHub
Rancho-7 commented on PR #19347: URL: https://github.com/apache/kafka/pull/19347#issuecomment-2786278465 I did a quick comparison based on different config combinations. (1)If we keep all the configs, the output is like this: ``` (base) lansg:kafka/ (KAFKA-19027✗) $ start=$(date

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-08 Thread via GitHub
m1a2st commented on code in PR #19347: URL: https://github.com/apache/kafka/pull/19347#discussion_r2033270926 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -66,13 +68,28 @@ import java.util.stream.IntStream; import java.util

[jira] [Commented] (KAFKA-19109) Don't print null in kafka-metadata-quorum describe status

2025-04-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941898#comment-17941898 ] José Armando García Sancio commented on KAFKA-19109: [~yangpoan] yes

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-08 Thread via GitHub
junrao commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2033582699 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2090,6 +2091,339 @@ public void testComplexShareConsu

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-08 Thread via GitHub
chia7712 commented on code in PR #19319: URL: https://github.com/apache/kafka/pull/19319#discussion_r2032812457 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerCompressionTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-08 Thread via GitHub
m1a2st commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2032907056 ## core/src/main/java/kafka/server/QuotaFactory.java: ## @@ -113,22 +116,43 @@ public void shutdown() { } } -public static QuotaManagers instantiate(

[jira] [Comment Edited] (KAFKA-19106) Improve Connect SourceTask commit()

2025-04-08 Thread Sudesh Wasnik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941842#comment-17941842 ] Sudesh Wasnik edited comment on KAFKA-19106 at 4/8/25 10:17 AM: --

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-08 Thread via GitHub
Rancho-7 commented on code in PR #19347: URL: https://github.com/apache/kafka/pull/19347#discussion_r2033222436 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java: ## @@ -38,58 +34,15 @@ import java.util.function.Consumer; import ja

[jira] [Updated] (KAFKA-19108) Consider improving the UI when describing static voters

2025-04-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19108: --- Description: The kafka-metadata-quorum describe tool prints the zero

Re: [PR] KAFKA-19099: Remove GroupSyncKey, GroupJoinKey, and MemberKey [kafka]

2025-04-08 Thread via GitHub
chia7712 merged PR #19413: URL: https://github.com/apache/kafka/pull/19413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15853: Move ShareCoordinatorConfig and GroupCoordinatorConfig out of KafkaConfig [kafka]

2025-04-08 Thread via GitHub
chia7712 commented on code in PR #19409: URL: https://github.com/apache/kafka/pull/19409#discussion_r2033749105 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -194,16 +193,9 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) private val _qu

[jira] [Resolved] (KAFKA-19099) Remove GroupSyncKey, GroupJoinKey, and MemberKey

2025-04-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19099. Fix Version/s: 4.1.0 Resolution: Fixed > Remove GroupSyncKey, GroupJoinKey, and Mem

Re: [PR] MINOR: remove unused function BrokerRegistration#isMigratingZkBroker [kafka]

2025-04-08 Thread via GitHub
chia7712 merged PR #19330: URL: https://github.com/apache/kafka/pull/19330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] KAFKA-18900: Implement share.acknowledgment.mode to choose acknowledgement mode [kafka]

2025-04-08 Thread via GitHub
ShivsundarR opened a new pull request, #19417: URL: https://github.com/apache/kafka/pull/19417 *What* - This is in continuation to https://github.com/apache/kafka/commit/1da30bdedf457b507ed9879a78e31c9e4c74026c, where we will only choose the acknowledgement mode based on the config

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-08 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2032527377 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2090,6 +2091,307 @@ public void testComplexS

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-08 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2032965956 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -88,6 +88,9 @@ public MirrorCheckpointTask() {} this.topicFilt

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-08 Thread via GitHub
Rancho-7 commented on PR #19347: URL: https://github.com/apache/kafka/pull/19347#issuecomment-2786280714 (2)If we remove `OFFSETS_TOPIC_PARTITIONS_CONFIG` only, the output looks like this: ``` (base) lansg:kafka/ (KAFKA-19027✗) $ start=$(date +%s)

Re: [PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-08 Thread via GitHub
m1a2st commented on code in PR #19397: URL: https://github.com/apache/kafka/pull/19397#discussion_r2033040494 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -620,21 +621,22 @@ private Map instantiateConfigProviders( } }

[jira] [Resolved] (KAFKA-19100) Use ProcessRole.toString instead of String in AclApis

2025-04-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-19100. - Resolution: Fixed > Use ProcessRole.toString instead of String in AclApis >

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-08 Thread via GitHub
m1a2st commented on code in PR #19347: URL: https://github.com/apache/kafka/pull/19347#discussion_r2033151465 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java: ## @@ -38,58 +34,15 @@ import java.util.function.Consumer; import java

[jira] [Commented] (KAFKA-19109) Don't print null in kafka-metadata-quorum describe status

2025-04-08 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941895#comment-17941895 ] PoAn Yang commented on KAFKA-19109: --- Hi [~jsancio], if you are not working on this, ma

Re: [PR] KAFKA-19047: Allow quickly re-registering brokers that are in controlled shutdown [kafka]

2025-04-08 Thread via GitHub
cmccabe commented on PR #19296: URL: https://github.com/apache/kafka/pull/19296#issuecomment-2787475238 We talked about this a bit and I think allowing rapid re-registration of brokers that are in controlled shutdown is reasonable. The main use-case where this comes up is people running sin

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-08 Thread via GitHub
smjn commented on PR #18976: URL: https://github.com/apache/kafka/pull/18976#issuecomment-2787503527 > This PR is really quite close now, but there is one issue which I found during testing. > > Imagine that I have a share group SG1 which has the following offset information. >

[jira] [Updated] (KAFKA-19110) Add missing unit test for Streams-consumer integration

2025-04-08 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-19110: -- Parent: KAFKA-17125 Issue Type: Sub-task (was: Test) > Add missing unit test for Stre

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-08 Thread via GitHub
Rancho-7 commented on PR #19347: URL: https://github.com/apache/kafka/pull/19347#issuecomment-2786285563 (4)If we remove both `OFFSETS_TOPIC_PARTITIONS_CONFIG` and `GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG`, the output is like this: ``` (base) lansg:kafka/ (KAFKA-19027✗) $ start=$(d

[jira] [Created] (KAFKA-19109) Don't print null in kafka-metadata-quorum describe status

2025-04-08 Thread Jira
José Armando García Sancio created KAFKA-19109: -- Summary: Don't print null in kafka-metadata-quorum describe status Key: KAFKA-19109 URL: https://issues.apache.org/jira/browse/KAFKA-19109

[jira] [Commented] (KAFKA-19111) Remove ModernGroup#computeSubscriptionMetadata unused parameter

2025-04-08 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941936#comment-17941936 ] PoAn Yang commented on KAFKA-19111: --- Hi [~m1a2st], thanks for filing the issue. I thin

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-08 Thread via GitHub
satishd commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2033582721 ## docs/ops.html: ## @@ -4026,13 +4026,14 @@ Broker Configurations -By default, Kafka server will not enable tiered storage feature. remote.log.storage.system.enabl

[jira] [Commented] (KAFKA-19111) Remove ModernGroup#computeSubscriptionMetadata unused parameter

2025-04-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941940#comment-17941940 ] 黃竣陽 commented on KAFKA-19111: - Thanks for information, I will close this issue > Remove Mod

Re: [PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-08 Thread via GitHub
Yunyung commented on code in PR #19397: URL: https://github.com/apache/kafka/pull/19397#discussion_r2034037635 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -587,14 +588,14 @@ private Map configProviderProperties(String configProviderPrefix

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2025-04-08 Thread via GitHub
rich-c-shop commented on PR #17099: URL: https://github.com/apache/kafka/pull/17099#issuecomment-2787762389 > Run './gradlew :clients:spotlessApply' to fix these violations run it locally gives no error. I will follow CI result to fix the import ordering then. -- This is an automat

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-08 Thread via GitHub
junrao commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2034133896 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2090,6 +2091,335 @@ public void testComplexShareConsu

[PR] MINOR Fix PR Linter "Reviewers" handling [kafka]

2025-04-08 Thread via GitHub
mumrah opened a new pull request, #19415: URL: https://github.com/apache/kafka/pull/19415 This patch fixes the textwrap for Reviewers to support the RFC 822 folding rules. From the RFC, headers or trailers can break across multiple lines if there is a leading whitespace on subsequent lines.

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2025-04-08 Thread via GitHub
rich-c-shop commented on PR #17099: URL: https://github.com/apache/kafka/pull/17099#issuecomment-2788107901 @chia7712 I address the two minor comments and rebase on latest trunk. Do you have time to take final look to see if we are ok to merge? -- This is an automated message from the Apa

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-08 Thread via GitHub
chia7712 commented on PR #19384: URL: https://github.com/apache/kafka/pull/19384#issuecomment-2788376713 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-7542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-18983 Ensure all README.md(s) are mentioned by the root README.md [kafka]

2025-04-08 Thread via GitHub
frankvicky commented on code in PR #19420: URL: https://github.com/apache/kafka/pull/19420#discussion_r2034519733 ## docker/README.md: ## @@ -31,7 +31,7 @@ Building image and running tests using github actions - image-type - This is the type of image that we intend to build.

Re: [PR] KAFKA-18983 Ensure all README.md(s) are mentioned by the root README.md [kafka]

2025-04-08 Thread via GitHub
chia7712 commented on code in PR #19420: URL: https://github.com/apache/kafka/pull/19420#discussion_r2034606713 ## docker/README.md: ## @@ -31,7 +31,7 @@ Building image and running tests using github actions - image-type - This is the type of image that we intend to build. Th

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-08 Thread via GitHub
chia7712 merged PR #19384: URL: https://github.com/apache/kafka/pull/19384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-08 Thread via GitHub
AndrewJSchofield merged PR #18976: URL: https://github.com/apache/kafka/pull/18976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Created] (KAFKA-19114) Backport KAFKA-18991 to 4.0, 3.9 and 3.8

2025-04-08 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19114: -- Summary: Backport KAFKA-18991 to 4.0, 3.9 and 3.8 Key: KAFKA-19114 URL: https://issues.apache.org/jira/browse/KAFKA-19114 Project: Kafka Issue Type: Sub-

[jira] [Created] (KAFKA-19115) Utilize initiazed topics info to verify delete share group offsets

2025-04-08 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-19115: --- Summary: Utilize initiazed topics info to verify delete share group offsets Key: KAFKA-19115 URL: https://issues.apache.org/jira/browse/KAFKA-19115 Project: Kaf

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2025-04-08 Thread via GitHub
github-actions[bot] commented on PR #17099: URL: https://github.com/apache/kafka/pull/17099#issuecomment-2785142757 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Commented] (KAFKA-19112) cleanup.policy shouldn't be empty

2025-04-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942030#comment-17942030 ] 黃竣陽 commented on KAFKA-19112: - Hello [~junrao]  if you won’t work on this, may I take it, Th

Re: [PR] KAFKA-19024 Enhance the client behaviour when it tries to exceed the `group.share.max.groups` [kafka]

2025-04-08 Thread via GitHub
DL1231 commented on PR #19313: URL: https://github.com/apache/kafka/pull/19313#issuecomment-2787992272 @AndrewJSchofield, ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-08 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2033651560 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2090,6 +2091,339 @@ public void testComplexS

[jira] [Commented] (KAFKA-19112) cleanup.policy shouldn't be empty

2025-04-08 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942034#comment-17942034 ] Jun Rao commented on KAFKA-19112: - [~m1a2st] : Thanks for your interest. Feel free to ta

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-08 Thread via GitHub
cmccabe commented on PR #19416: URL: https://github.com/apache/kafka/pull/19416#issuecomment-2787916394 > Before the kraft version can be upgraded to version 1, all of the > brokers and controllers in the cluster need to support kraft version 1. > The check that all brokers support kraf

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2025-04-08 Thread via GitHub
rich-c-shop commented on PR #17099: URL: https://github.com/apache/kafka/pull/17099#issuecomment-2786823125 > This branch has conflicts that must be resolved I am going to rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-08 Thread via GitHub
Rancho-7 commented on PR #19347: URL: https://github.com/apache/kafka/pull/19347#issuecomment-2786282751 (3)If we remove `GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG` only, the output is like this: ``` (base) lansg:kafka/ (KAFKA-19027✗) $ start=$(date +%s)

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-08 Thread via GitHub
ahuang98 commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2034166958 ## raft/src/main/java/org/apache/kafka/raft/FollowerState.java: ## @@ -38,19 +40,20 @@ public class FollowerState implements EpochState { private final Set voters

Re: [PR] Minor : Increase Config change throwable log info to error [kafka]

2025-04-08 Thread via GitHub
github-actions[bot] commented on PR #14380: URL: https://github.com/apache/kafka/pull/14380#issuecomment-2788200635 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-08 Thread via GitHub
chia7712 commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2033634374 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -97,7 +97,7 @@ class SocketServer( private val memoryPool = if (config.queuedMaxBytes > 0) new Simpl

[jira] [Resolved] (KAFKA-18987) Include information about --standalone command in Static versus Dynamic KRaft Quorums documentation and errors

2025-04-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-18987. - Resolution: Fixed This issue fixed by https://github.com/apache/kafka/pull/19210/files > Include information ab

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-08 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2033651560 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2090,6 +2091,339 @@ public void testComplexS

Re: [PR] KAFKA-18892: Add KIP-877 support for ClientQuotaCallback [kafka]

2025-04-08 Thread via GitHub
mimaison commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2033693903 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -44,6 +44,12 @@ public static Plugin wrapInstance(T instance, Metrics metrics, String k

[jira] [Comment Edited] (KAFKA-18760) Deprecate Optional and return String from public EndPoint#Listener

2025-04-08 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936126#comment-17936126 ] PoAn Yang edited comment on KAFKA-18760 at 4/8/25 7:58 AM: --- KI

[jira] [Created] (KAFKA-19110) Add missing unit test for Streams-consumer integration

2025-04-08 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-19110: - Summary: Add missing unit test for Streams-consumer integration Key: KAFKA-19110 URL: https://issues.apache.org/jira/browse/KAFKA-19110 Project: Kafka Iss

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2025-04-08 Thread via GitHub
rich-c-shop commented on code in PR #17099: URL: https://github.com/apache/kafka/pull/17099#discussion_r2033443850 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1546,6 +1547,7 @@ private AppendCallbacks(Callback userCallback, ProducerInte

[jira] [Commented] (KAFKA-19110) Add missing unit test for Streams-consumer integration

2025-04-08 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941932#comment-17941932 ] PoAn Yang commented on KAFKA-19110: --- Hi [~cadonna], may I take this? Thank you. > Add

Re: [PR] KAFKA-15853: Move ShareCoordinatorConfig and GroupCoordinatorConfig out of KafkaConfig [kafka]

2025-04-08 Thread via GitHub
FrankYang0529 commented on code in PR #19409: URL: https://github.com/apache/kafka/pull/19409#discussion_r2033540925 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -194,16 +193,9 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) private va

Re: [PR] KAFKA-15853: Move ShareCoordinatorConfig and GroupCoordinatorConfig out of KafkaConfig [kafka]

2025-04-08 Thread via GitHub
FrankYang0529 closed pull request #19409: KAFKA-15853: Move ShareCoordinatorConfig and GroupCoordinatorConfig out of KafkaConfig URL: https://github.com/apache/kafka/pull/19409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-19090: Move DelayedFuture and DelayedFuturePurgatory to server-common module [kafka]

2025-04-08 Thread via GitHub
FrankYang0529 commented on PR #19390: URL: https://github.com/apache/kafka/pull/19390#issuecomment-2786970751 @mimaison Thanks for the review. I address all comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (KAFKA-19111) Remove ModernGroup#computeSubscriptionMetadata unused parameter

2025-04-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-19111. - Resolution: Won't Fix > Remove ModernGroup#computeSubscriptionMetadata unused parameter > --

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-08 Thread via GitHub
Rancho-7 commented on code in PR #19347: URL: https://github.com/apache/kafka/pull/19347#discussion_r2033100966 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -66,13 +68,28 @@ import java.util.stream.IntStream; import java.ut

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-08 Thread via GitHub
Rancho-7 commented on code in PR #19384: URL: https://github.com/apache/kafka/pull/19384#discussion_r2033114498 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( /* a meter to track the average free capacity o

[jira] [Commented] (KAFKA-18216) High water mark or last stable offset aren't always updated after a fetch request is completed

2025-04-08 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941901#comment-17941901 ] TengYao Chi commented on KAFKA-18216: - Hi [~lianetm]  Thanks for the information!

[jira] [Assigned] (KAFKA-19109) Don't print null in kafka-metadata-quorum describe status

2025-04-08 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-19109: - Assignee: PoAn Yang > Don't print null in kafka-metadata-quorum describe status > -

Re: [PR] DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" [kafka]

2025-04-08 Thread via GitHub
aliehsaeedii commented on code in PR #18800: URL: https://github.com/apache/kafka/pull/18800#discussion_r209555 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1250,6 +1238,7 @@ public KStream process( name,

[jira] [Commented] (KAFKA-3274) Document command line tools

2025-04-08 Thread Hugh Evans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941978#comment-17941978 ] Hugh Evans commented on KAFKA-3274: --- Hi [~gwenshap], Would it be ok for me to pick this

[PR] KAFKA-19099: Remove GroupSyncKey, GroupJoinKey, and MemberKey [kafka]

2025-04-08 Thread via GitHub
Rancho-7 opened a new pull request, #19413: URL: https://github.com/apache/kafka/pull/19413 jira: https://issues.apache.org/jira/browse/KAFKA-19099 They are useless after removing old coordinator. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" [kafka]

2025-04-08 Thread via GitHub
aliehsaeedii commented on code in PR #18800: URL: https://github.com/apache/kafka/pull/18800#discussion_r209555 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1250,6 +1238,7 @@ public KStream process( name,

[PR] MINOR: Remove the unused parameter from FetchSession update method [kafka]

2025-04-08 Thread via GitHub
shmily7829 opened a new pull request, #19414: URL: https://github.com/apache/kafka/pull/19414 Remove the unused parameter from the FetchSession update method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [KAFKA-8830] KIP-512: make Record Headers available in onAcknowledgement [kafka]

2025-04-08 Thread via GitHub
rich-c-shop commented on code in PR #17099: URL: https://github.com/apache/kafka/pull/17099#discussion_r2033386184 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1546,6 +1547,7 @@ private AppendCallbacks(Callback userCallback, ProducerInte

Re: [PR] KAFKA-18892: Add KIP-877 support for ClientQuotaCallback [kafka]

2025-04-08 Thread via GitHub
mimaison merged PR #19068: URL: https://github.com/apache/kafka/pull/19068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-19106) Improve Connect SourceTask commit()

2025-04-08 Thread Sudesh Wasnik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941842#comment-17941842 ] Sudesh Wasnik commented on KAFKA-19106: --- KIP : https://cwiki.apache.org/confluence

  1   2   >